From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 3B1434BFA3
for <ffmpegdev@gitmailbox.com>; Tue, 1 Apr 2025 09:35:27 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 143C1687CFB;
Tue, 1 Apr 2025 12:35:24 +0300 (EEST)
Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com
[209.85.167.43])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E49A687C68
for <ffmpeg-devel@ffmpeg.org>; Tue, 1 Apr 2025 12:35:18 +0300 (EEST)
Received: by mail-lf1-f43.google.com with SMTP id
2adb3069b0e04-549946c5346so5658326e87.2
for <ffmpeg-devel@ffmpeg.org>; Tue, 01 Apr 2025 02:35:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=martin-st.20230601.gappssmtp.com; s=20230601; t=1743500117; x=1744104917;
darn=ffmpeg.org;
h=mime-version:references:message-id:in-reply-to:subject:cc:to:from
:date:from:to:cc:subject:date:message-id:reply-to;
bh=xdiJVJHj+6CevhU5FL2BJJWGS2PGB6WAXIqtYlUFlgc=;
b=E9qR2uhhGwiLQA1wD3XTfoY0WTdNu59QsfxErTjlhcCO5mja/W6eab2XHHR2Cr7nl2
bJEotS4iG72b/hBscwiHnBUzbHyV6idSrum7fMzOdUJOU7NbpICTqwFH7G9THGxw5yKW
ycuh+fxhay7qbFtxFYlxxA6fTIfeLmeZNAJJ01M5NK/h6ziWqJh7FHJlRiWrZox+YHCC
vIQLILY0oHxmBrTpMbhje08R+3jskXJJOOXZvr6gOW1B00rUDx3U6Bru/dntIkooNwHb
YkSVsrLvfxsfBlk+Dg7jPdxBNt0GJSghEBnPpiFtmIofQgvTWEvrWCi/ZzVMHAwrLQ2C
vr0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743500117; x=1744104917;
h=mime-version:references:message-id:in-reply-to:subject:cc:to:from
:date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=xdiJVJHj+6CevhU5FL2BJJWGS2PGB6WAXIqtYlUFlgc=;
b=fw9ieRWKG26XMs4x4rh3fdJcGe8MOD36CrSyPHvUG6rmHNGGb75JL52rNojAf9vwUt
OjFf6h4OY8SaimuJN3vmRaIY2C3bLUA+djuDVW2h9At6j009krqvbBDIavgRtGJE2PUh
ZW7tH9ZG62iUc5LBkIH+ucc2l+Lfd6zHiaQCBrAkX5nZmCQNSRmd7wctb8MxXzwbqeqG
qzss3yzpZ2rFTNCVvOY+bUNXdvGu646n9BkvS2jNMIiRWVeD0qI9n05fuC28jtuaEPAu
4K+Jo+wm9BjQOinhCC28+FLWMAVnnyoCPqcOS0WwuLqJyUtWdNSizWT+xKueAu0AYXhY
d46A==
X-Gm-Message-State: AOJu0YxOtxoq6icT6znnRShNs1VdffUIDitOhoemgnhIlUi6EMJ0MIwX
eVy38WHRRcMcLGPVnXkCllmks9+VZvv0fniOtMCgSkI4T43G486LgCWmyA91yiV6YhJ+YjOkyLZ
ePA==
X-Gm-Gg: ASbGnctlkT9u6ImF7lyuN3nUak/Eze7lQEYlH63sha5ieuuulcuEe6zrXC/YrRYFuIJ
wmsc6rYPT2JRuqmTQHTWQPh7NAK3co77hs7I3Hr74QKGXF9C2VU8trb3ftGwv4g20s2/vIlU4hC
lY9HYtg4Ulo4IBOjMEbo7iFkTbjo3/BQ0FWTIZpP6RLJDlh6yWhweP3zcCZebAUyerGiRAJVpkn
urxBoThVDJCizlCzpnFOzSaZ8JEWmD59SY2qdgjXjGxJHjLfncnoT/es4v//5nBpZth6ueukGu1
ZHOXR9CftkbEk3BwKqsqQKUI9Il9RT3r9dKbUDgELQi8WnXavDUKePWUIrqiVivJHdTa03e/wtS
pWxJNy3lQv+q2JuvVLycA0GbpEUjIH/gKEf10TwE5
X-Google-Smtp-Source: AGHT+IFMjTxThUf80dVbytgCor05E8DAOv1A3sFmJ4p8z9QMeFYZLXpqiPec+xYhXtRkfkzwKTtK/w==
X-Received: by 2002:a05:6512:6d6:b0:546:2f7a:38c4 with SMTP id
2adb3069b0e04-54b10dc895emr3418877e87.13.1743500117367;
Tue, 01 Apr 2025 02:35:17 -0700 (PDT)
Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net
(tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2])
by smtp.gmail.com with ESMTPSA id
2adb3069b0e04-54b095a06easm1366073e87.219.2025.04.01.02.35.16
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 01 Apr 2025 02:35:16 -0700 (PDT)
Date: Tue, 1 Apr 2025 12:35:16 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <20250326103015.44296-3-martin@martin.st>
Message-ID: <a428bbd9-fcf2-ded9-ba53-25b9d11f1760@martin.st>
References: <20250326103015.44296-1-martin@martin.st>
<20250326103015.44296-3-martin@martin.st>
MIME-Version: 1.0
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH 3/4] checkasm: hevc_pel: Use helpers for
checking for writes out of bounds
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: yinshiyou-hf@loongson.cn, Lu Wang <wanglu@loongson.cn>,
jinbo <jinbo@loongson.cn>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-15"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/a428bbd9-fcf2-ded9-ba53-25b9d11f1760@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On Wed, 26 Mar 2025, Martin Storsj=F6 wrote:
> This allows catching whether the functions write outside of
> the designated rectangle, and if run with "checkasm -v", it also
> prints out on which side of the rectangle the overwrite was.
> ---
> tests/checkasm/hevc_pel.c | 157 ++++++++++++++++++++++----------------
> 1 file changed, 90 insertions(+), 67 deletions(-)
This patch exposes existing issues in the Loongson HEVC simd; running with =
"checkasm --test=3Dhevc_pel -v" after applying these patches, shows the =
following errors:
LSX:
- hevc_pel.qpel [OK]
- hevc_pel.qpel_uni [OK]
- hevc_pel.qpel_uni_w [OK]
put_hevc_pel_bi_pixels12_8_lsx (src/tests/checkasm/hevc_pel.c:272)
dst (12x12):
overwrite below
- hevc_pel.qpel_bi [FAILED]
- hevc_pel.epel [OK]
put_hevc_epel_uni_v24_8_lsx (src/tests/checkasm/hevc_pel.c:433)
dst (24x24):
overwrite below
put_hevc_epel_uni_hv12_8_lsx (src/tests/checkasm/hevc_pel.c:433)
dst (12x12):
overwrite below
- hevc_pel.epel_uni [FAILED]
- hevc_pel.epel_uni_w [OK]
put_hevc_epel_bi_hv6_8_lsx (src/tests/checkasm/hevc_pel.c:545)
dst (6x6):
overwrite below
- hevc_pel.epel_bi [FAILED]
LASX:
- hevc_pel.qpel_uni [OK]
- hevc_pel.qpel_uni_w [OK]
- hevc_pel.epel_uni_w [OK]
- hevc_pel.epel_bi [OK]
checkasm: 4 of 231 tests have failed
So the functions seem to produce more output rows than requested, for =
"uneven" heights like 6, 12 or 24 pixels.
Can someone from Loongson please have a look at this?
We don't seem to have any Loongson instances on fate, so can I go ahead =
and push this, without waiting for the Loongson assembly to be fixed? We =
do have some on patchwork though, so I guess that'll make patchwork noisy =
for everybody else until it is fixed, so I guess I'll have to hold off of =
this patch until it is fixed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".