From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C0E5645DB8 for ; Fri, 11 Aug 2023 17:50:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C12568C8BB; Fri, 11 Aug 2023 20:50:32 +0300 (EEST) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3A19E68C7EC for ; Fri, 11 Aug 2023 20:50:26 +0300 (EEST) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-977e0fbd742so303511266b.2 for ; Fri, 11 Aug 2023 10:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691776225; x=1692381025; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=tE3izPnTw4WvJzwdQDGhHA01qFhm3+LisrVfQ95JceU=; b=mzYGF1lg3o7Qt8Oh0neImW56usZYeWiIh801UMkr0FUpRhqsZHQw02ypKVSXePlRe8 esb0FmpvinEfAbxVKcaOGz3svMybRQ/5lk7gXUsw06q7a3tON4fSd1GVrqVUxsfQqX8c TxRc+e/XOOTYqu60W+KagLWPyVAP7Oz5QrFNRgWoZDBygpBdx+KQHT/xd+hE0tAJvw/y ciC+P05+0W8AuKMrFQl7WFHRaN6HPwizv9mXh70FWqwILxIDJOXR2OwqHqVbFyqv0pLW pqwokNHtX/I5auKPG4m6sAX9DIfwap+lFWnfpBrdq6oJLvx5jISAGR2RD0OalwMobh25 hOIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691776225; x=1692381025; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tE3izPnTw4WvJzwdQDGhHA01qFhm3+LisrVfQ95JceU=; b=iklR8UC8+GNznRoCX934hny76VWeUPJOOFCRrRcOLScPUfL3orFruvG7Azy28rc9R0 QYbfWum8VBjCcIpe8mby8NZCcK/7nx1wkSXKhPpUa0PU9rpyRm1kI9n42yZXct3nn7ga hvcX9crf7sHikigrxWsSOO/FFq6ynq5Iby1oLDZZe6JZxJ0aVmf3HcSJrlVzvoz3Qbu7 eWagMb9HnDOT+HERZ1DvTp8PUDj3VT/Dl6WshirYNqu7DVq4HGAHnU/pFoj8F+GqPqzs 8rCU+JhPlPggFQxbL3v91A08lUMMOsZi8w40qV5jNl5rkOuehO7hkO/XIKXKYSnyTLAU l+Jg== X-Gm-Message-State: AOJu0YyXV88T28KXNAKGIBIOJqKlHo5L04sK09Kv7Vrtq/g3JxvI0oc4 33JojwWFL8xdGn+9XqJaUKzVDWuSVZIn5t6g X-Google-Smtp-Source: AGHT+IHIk8lgF8/vKDakT1jhYaOE2d88l+SuIVXhd/MKSI8aUo6ioAw1+3N1pO4XR3L+zQtZb1U04w== X-Received: by 2002:a17:906:220f:b0:99c:e38c:31d with SMTP id s15-20020a170906220f00b0099ce38c031dmr2130705ejs.72.1691776224990; Fri, 11 Aug 2023 10:50:24 -0700 (PDT) Received: from [192.168.1.136] ([188.26.129.104]) by smtp.gmail.com with ESMTPSA id a13-20020a17090682cd00b00992f81122e1sm2511795ejy.21.2023.08.11.10.50.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Aug 2023 10:50:24 -0700 (PDT) Message-ID: Date: Fri, 11 Aug 2023 20:50:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Random Joe To: ffmpeg-devel@ffmpeg.org Content-Language: en-US Subject: [FFmpeg-devel] [PATCH v2] avcodec/cuviddec: update parser ulMaxNumDecodeSurfaces X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes video output stutter caused by different number of buffers in decoder vs parser introduced in 402d98c. Signed-off-by: Random Joe --- libavcodec/cuviddec.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 814bc53f70..1b62832eca 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -360,7 +360,14 @@ static int CUDAAPI cuvid_handle_video_sequence(void *opaque, CUVIDEOFORMAT* form } } - return 1; + // make CUVIDDECODECREATEINFO::ulNumDecodeSurfaces = CUVIDPARSERPARAMS::ulMaxNumDecodeSurfaces + // returning a value > 1 , will notify the driver to set the parser ulMaxNumDecodeSurfaces + // to this return value . + + if(ctx->cuparseinfo.ulMaxNumDecodeSurfaces != cuinfo.ulNumDecodeSurfaces) + return cuinfo.ulNumDecodeSurfaces; + else + return 1; } static int CUDAAPI cuvid_handle_picture_decode(void *opaque, CUVIDPICPARAMS* picparams) @@ -1022,7 +1029,9 @@ static av_cold int cuvid_decode_init(AVCodecContext *avctx) goto error; } - ctx->cuparseinfo.ulMaxNumDecodeSurfaces = ctx->nb_surfaces; + // set ulMaxNumDecodeSurfaces to a dummy value of 1 as recommended in NVDEC Programming Guide + // set the optimal value in pfnSequenceCallback where CUVIDEOFORMAT::min_num_decode_surfaces is reported + ctx->cuparseinfo.ulMaxNumDecodeSurfaces = 1; ctx->cuparseinfo.ulMaxDisplayDelay = (avctx->flags & AV_CODEC_FLAG_LOW_DELAY) ? 0 : CUVID_MAX_DISPLAY_DELAY; ctx->cuparseinfo.pUserData = avctx; ctx->cuparseinfo.pfnSequenceCallback = cuvid_handle_video_sequence; -- 2.39.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".