From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 255D643609 for ; Sat, 18 Jun 2022 22:24:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB44968B587; Sun, 19 Jun 2022 01:24:23 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AD8F968810B for ; Sun, 19 Jun 2022 01:24:16 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 25IMOGa4027145-25IMOGa5027145 for ; Sun, 19 Jun 2022 01:24:16 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 1DBEEA142E for ; Sun, 19 Jun 2022 01:24:16 +0300 (EEST) Date: Sun, 19 Jun 2022 01:24:16 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220617093141.9826-4-nil-admirari@mailo.com> Message-ID: References: <20220617093141.9826-1-nil-admirari@mailo.com> <20220617093141.9826-4-nil-admirari@mailo.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v17 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 17 Jun 2022, Nil Admirari wrote: > 1. getenv() is replaced with getenv_utf8() across libavformat. > 2. New versions of AviSynth+ are now called with UTF-8 filenames. > 3. Old versions of AviSynth are still using ANSI strings, > but MAX_PATH limit on filename is removed. > --- > libavformat/avisynth.c | 39 +++++++++++++++++++++++++++------------ > libavformat/http.c | 20 +++++++++++++------- > libavformat/ipfsgateway.c | 35 +++++++++++++++++++++++------------ > libavformat/tls.c | 11 +++++++++-- > 4 files changed, 72 insertions(+), 33 deletions(-) > > diff --git a/libavformat/http.c b/libavformat/http.c > index c8f3f4b6a3..d90117e422 100644 > --- a/libavformat/http.c > +++ b/libavformat/http.c > @@ -29,6 +29,7 @@ > #include "libavutil/avassert.h" > #include "libavutil/avstring.h" > #include "libavutil/bprint.h" > +#include "libavutil/getenv_utf8.h" > #include "libavutil/opt.h" > #include "libavutil/time.h" > #include "libavutil/parseutils.h" This actually causes some surprise breakage in MSVC builds. Here, getenv_utf8.h includes windows.h. If including windows.h and winsock2 headers in the same file, the winsock2 headers must be included before. I fixed it locally by moving this new include down, with a comment like this: /* This header can include . That header has to be included after * winsock2 headers (included by network.h and os_support.h above). */ #include "libavutil/getenv_utf8.h" (I had to do the same fixup in http.c and ipfsgateway.c.) If that seems fine to you and others, I can push this patchset maybe tomorrow. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".