From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07D2440A6E for ; Mon, 4 Apr 2022 22:28:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F0A8668B160; Tue, 5 Apr 2022 01:28:21 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ED973689F8F for ; Tue, 5 Apr 2022 01:28:15 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 234D2E6E36 for ; Tue, 5 Apr 2022 00:28:16 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id adDkK0nH7sAA for ; Tue, 5 Apr 2022 00:28:14 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 2E1A1E6E00 for ; Tue, 5 Apr 2022 00:28:14 +0200 (CEST) Date: Tue, 5 Apr 2022 00:28:14 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: Message-ID: References: <20220327060800.3732289-1-wangcao@google.com> <2ec3971d-f698-1369-1ace-eac613afc980@passwd.hu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/alimiter: Add "flush_buffer" option to flush the remaining valid data to the output X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 4 Apr 2022, Paul B Mahol wrote: > On Sun, Mar 27, 2022 at 11:41 PM Marton Balint wrote: > >> >> >> On Sat, 26 Mar 2022, Wang Cao wrote: >> >>> The change in the commit will add some samples to the end of the audio >>> stream. The intention is to add a "zero_delay" option eventually to not >>> have the delay in the begining the output from alimiter due to >>> lookahead. >> >> I was very much suprised to see that the alimiter filter actually delays >> the audio - as in extra samples are inserted in the beginning and some >> samples are cut in the end. This trashes A-V sync, so it is a bug IMHO. >> >> So unless somebody has some valid usecase for the legacy way of operation >> I'd just simply change it to be "zero delay" without any additional user >> option, in a single patch. >> > > > This is done by this patch in very complicated way and also it really > should be optional. But why does it make sense to keep the current (IMHO buggy) operational mode which adds silence in the beginning and trims the end? I understand that the original implementation worked like this, but libavfilter has packet timestamps and N:M filtering so there is absolutely no reason to use an 1:1 implementation and live with its limitations. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".