From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8A9FD42112 for ; Mon, 27 Jun 2022 16:48:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D51668B8E1; Mon, 27 Jun 2022 19:48:33 +0300 (EEST) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98F9768B7BF for ; Mon, 27 Jun 2022 19:48:27 +0300 (EEST) Received: by mail-ot1-f54.google.com with SMTP id m24-20020a0568301e7800b00616b5c114d4so5977494otr.11 for ; Mon, 27 Jun 2022 09:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=QGiHl3ikqtlafJ7bJBxLi0RgeWaNHCOvfq956spgwM4=; b=lT0W0AHOwOQK6hDeNIQJaQhHj1vZCQElVIlJRXqTQ2Oqykfis9CXbJ56LKzZiKmJLJ gO94rJDauvlccHpKQwMOvQXvJ7nffwbVFuxTh55KvziaVa7AS5iMA8ob61JJviCNdqQF W5H89vCVqFDL9QUH8zzThiPERVpABcoyh3sTPBRQAqamIb3EvzJOGIqWOKBTb6tEDsAQ vhD5V9F2X5tzjfZ8cbEfAS5FrWKotDCh5zkV2iGiudEEBRPDTSsFr5ZmHSczQk9rwFJH LCdtRtaVLGGEu/jCKtIuidwbkIIcUQFhi/yTcQFZrrdIuj8gXxNz7WnlvbSq0KfTi3op zoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=QGiHl3ikqtlafJ7bJBxLi0RgeWaNHCOvfq956spgwM4=; b=kOWlMsYdrA+0GgXRs9E8bB4b5ycsnM66QZXH2evekw0qI72G746K+989llGUrC4F1b 7U1lzQyv+tzQz2OFx8VpVqgCOzemvaTpUAj9HWRt7q+koHd+kBRO4Hes2dFEiUDWS7vs ZKRMpt5g7DfQ8BQZeOlvgKtp+B2pKW10Okl+SG09PJq9GU0ajPiBMRBpOJ6QrqQx93uD eAJIav0AHIc9VC1nmoTMXg4ifww2yppmcQT/+RSNnIBWmRnGRaJZy0IH99ejErKJbQRJ EnGsNrTf7VCAeepN6ZwTboTyzWytHOCFTkY0RrHkpcvnm2GCFrFdmc4KJkh4VWG01ooa A/ww== X-Gm-Message-State: AJIora9J7SOOzBvUcrc18gp4dJBQmPVzXN8lFcqujQiJ5PXyvsGQDasr hpKmG/QaEzaeUH8wlq3ZFYEPjYvpgt0= X-Google-Smtp-Source: AGRyM1th+vBMFXVST4zG4MqIMyxgKaG2CTvQ4eIwyCrcsxwnxbAsNkEEXVlhVC4RNSnu0oP8TZ0uFw== X-Received: by 2002:a05:6830:2055:b0:616:d118:8320 with SMTP id f21-20020a056830205500b00616d1188320mr2238241otp.20.1656348505111; Mon, 27 Jun 2022 09:48:25 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id l2-20020a05687040c200b00101fae1b82fsm7413665oal.4.2022.06.27.09.48.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 09:48:23 -0700 (PDT) Message-ID: Date: Mon, 27 Jun 2022 13:48:23 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220601180556.949526-1-vigneshv@google.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/27/2022 1:43 PM, Vignesh Venkatasubramanian wrote: > On Tue, Jun 21, 2022 at 10:12 AM Vignesh Venkatasubramanian > wrote: >> >> On Mon, Jun 13, 2022 at 10:17 AM James Zern >> wrote: >>> >>> On Wed, Jun 1, 2022 at 11:06 AM Vignesh Venkatasubramanian >>> wrote: >>>> >>>> AVIF specification allows for alpha channel as an auxiliary item (in >>>> case of still images) or as an auxiliary track (in case of animated >>>> images). Add support for both of these. The AVIF muxer will take >>>> exactly two streams (when alpha is present) as input (first one being >>>> the YUV planes and the second one being the alpha plane). >>>> >>>> The input has to come from two different images (one of it color and >>>> the other one being alpha), or it can come from a single file >>>> source with the alpha channel extracted using the "alphaextract" >>>> filter. >>>> >>>> Example using alphaextract: >>>> ffmpeg -i rgba.png -filter_complex "[0:v]alphaextract[a]" -map 0 -map "[a]" -still-picture 1 avif_with_alpha.avif >>>> >>>> Example using two sources (first source can be in any pixel format and >>>> the second source has to be in monochrome grey pixel format): >>>> ffmpeg -i color.avif -i grey.avif -map 0 -map 1 -c copy avif_with_alpha.avif >>>> >>>> The generated files pass the compliance checks in Compliance Warden: >>>> https://github.com/gpac/ComplianceWarden >>>> >>>> libavif (the reference avif library) is able to decode the files >>>> generated using this patch. >>>> >>>> They also play back properly (with transparent background) in: >>>> 1) Chrome >>>> 2) Firefox (only still AVIF, no animation support) >>>> >>>> Signed-off-by: Vignesh Venkatasubramanian >>>> --- >>>> libavformat/movenc.c | 188 +++++++++++++++++++++++++++++-------------- >>>> libavformat/movenc.h | 4 +- >>>> 2 files changed, 130 insertions(+), 62 deletions(-) >>>> >>> >>> lgtm. >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> >> Any more comments on this? If not can this be merged please? :) >> > > Another ping on this please. > >> -- >> Vignesh I thought James Zern had push access, which is why i didn't apply it as soon as he reviewed it. Sorry. Pushed it now. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".