From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4757649F9A for ; Sun, 17 Mar 2024 17:07:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1463668D16D; Sun, 17 Mar 2024 19:07:11 +0200 (EET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E6CA468C409 for ; Sun, 17 Mar 2024 19:07:03 +0200 (EET) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-414087091b3so11878145e9.0 for ; Sun, 17 Mar 2024 10:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1710695223; x=1711300023; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CesrYjnc+JYqX0qp3nqMDUW6SrH+tIzV+OgXaoOO8wA=; b=UQCGreljwdn2AbACm2qN2BtuubesgHPFHQZ+PcmGpGdm4TqqAJjNVEQ5VnSV6sIuO4 qdhuMBvKCz9tr/e+ASAUIRv6ZMqwP+0MzRL0ryDYqA2Sd85QYRKqEYlr9WNywvA71n5B 1x8ZjyHPUvDqAhfXnE/KQJY2nPEGHHKl4Nlv6liKZerH5EbGTFQ45FjBTp6Sso+v6iiE fPyLKUXGD2Y5fASamISYKOvxoTTeT687ATuWMQmXtl8qwC7hYwv80IFDBTootoDkYBh8 BNAbjlLvn38+n3U8I7JuUWCDoLWQV413Hi8omEPQKC97t5wIXWgrBOxC1aNMlUVWHoxy chMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710695223; x=1711300023; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CesrYjnc+JYqX0qp3nqMDUW6SrH+tIzV+OgXaoOO8wA=; b=FuIbud0pem9EW8qvUbghXS5n4qN0Ii+5aGR8IQisW4PXS0rWVtp61d/HLMrLvMBwhy D6+6khFsxRacq5bxrNqUzAb6p91I3oKLMROl2Xff3LNVRHk91uGbciQYMZ4cZZ3Gg575 KvtmbIXtgn59m0FIFEAN3jkK5e2F9asXXAr6aqly2n8otnrIp1gPImbxUYeiSbi2IhB9 NspbEh47fpozDxQm99jUn3gg8fqM0C6CMY0t4cMGMprXFOWYAE3xHIhrj2q5Cao3U60W oi6KM8G2bZjMKd0Qi+0yXbkckpZLO+hnD2Vus2kS1fZvn5wBoVYT1ElvFlLOtQyRwQS9 tbsg== X-Gm-Message-State: AOJu0Yw91SU0wj3QKGQLLE7vY+kbkC9cmFA3jq+wcidTxgf8850V2Cx7 myuv1GUMCFirINoesVbuHNiTG/WkAJOuY5QujWtOj+drUk1V/VUpoXZ8VCkMl6zIiAiw2BxmhdB P X-Google-Smtp-Source: AGHT+IEN5TTnujhRuRAVPUIkFcQNI6Fff+aI60X5qlE0VYGTenvRSHWYCQ0yR/YXudBYojBd7Zsv0g== X-Received: by 2002:adf:cd84:0:b0:33e:77b2:ff86 with SMTP id q4-20020adfcd84000000b0033e77b2ff86mr3100742wrj.69.1710695223049; Sun, 17 Mar 2024 10:07:03 -0700 (PDT) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id by1-20020a056000098100b0033e18421618sm4279321wrb.17.2024.03.17.10.07.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Mar 2024 10:07:02 -0700 (PDT) Message-ID: Date: Sun, 17 Mar 2024 17:07:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240314105105.362-1-Primeadvice@gmail.com> From: Mark Thompson In-Reply-To: <20240314105105.362-1-Primeadvice@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/amfenc: Update AMF encoder options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 14/03/2024 10:51, Araz Iusubov wrote: > The encoder options have been updated to the current version of the AMF. > > Signed-off-by: Araz Iusubov > --- > libavcodec/amfenc.c | 1 + > libavcodec/amfenc.h | 4 + > libavcodec/amfenc_av1.c | 154 +++++++++++++++++++++++++------------- > libavcodec/amfenc_h264.c | 155 +++++++++++++++++++++++++------------- > libavcodec/amfenc_hevc.c | 158 ++++++++++++++++++++++++++------------- > 5 files changed, 314 insertions(+), 158 deletions(-) This needs more explanation. What is different about the current version and why does it require these changes? The change is also mixing cosmetic changes and refactoring of some existing elements with addition of new options; ideally you would want to split this into multiple patches for each change. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".