From: Mark Thompson <sw@jkqxz.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/amfenc: Update AMF encoder options
Date: Sun, 17 Mar 2024 17:07:36 +0000
Message-ID: <a30e28c3-8cbc-498c-aed7-0e32e3365cf6@jkqxz.net> (raw)
In-Reply-To: <20240314105105.362-1-Primeadvice@gmail.com>
On 14/03/2024 10:51, Araz Iusubov wrote:
> The encoder options have been updated to the current version of the AMF.
>
> Signed-off-by: Araz Iusubov <Primeadvice@gmail.com>
> ---
> libavcodec/amfenc.c | 1 +
> libavcodec/amfenc.h | 4 +
> libavcodec/amfenc_av1.c | 154 +++++++++++++++++++++++++-------------
> libavcodec/amfenc_h264.c | 155 +++++++++++++++++++++++++-------------
> libavcodec/amfenc_hevc.c | 158 ++++++++++++++++++++++++++-------------
> 5 files changed, 314 insertions(+), 158 deletions(-)
This needs more explanation. What is different about the current version and why does it require these changes?
The change is also mixing cosmetic changes and refactoring of some existing elements with addition of new options; ideally you would want to split this into multiple patches for each change.
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-17 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 10:51 Araz Iusubov
2024-03-17 17:07 ` Mark Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30e28c3-8cbc-498c-aed7-0e32e3365cf6@jkqxz.net \
--to=sw@jkqxz.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git