Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/rtmppkt: add ff_amf_write_array for write array strings

[Marton Balint <cus@passwd.hu>]

On Thu, 24 Aug 2023, Steven Liu wrote:

> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
> libavformat/rtmppkt.c | 6 ++++++
> libavformat/rtmppkt.h | 8 ++++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
> index 4b97c0833f..cd0c68ec8a 100644
> --- a/libavformat/rtmppkt.c
> +++ b/libavformat/rtmppkt.c
> @@ -40,6 +40,12 @@ void ff_amf_write_number(uint8_t **dst, double val)
>     bytestream_put_be64(dst, av_double2int(val));
> }
>
> +void ff_amf_write_array(uint8_t **dst, uint32_t val)

ff_amf_write_array_start() would be a better name for the function, 
because it does not write the full array, only the beginning.

length would be a better name for the parameter.

Regards,
Marton

> +{
> +    bytestream_put_byte(dst, AMF_DATA_TYPE_ARRAY);
> +    bytestream_put_be32(dst, val);
> +}
> +
> void ff_amf_write_string(uint8_t **dst, const char *str)
> {
>     bytestream_put_byte(dst, AMF_DATA_TYPE_STRING);
> diff --git a/libavformat/rtmppkt.h b/libavformat/rtmppkt.h
> index a15d2a5773..44c3420436 100644
> --- a/libavformat/rtmppkt.h
> +++ b/libavformat/rtmppkt.h
> @@ -244,6 +244,14 @@ void ff_amf_write_null(uint8_t **dst);
>  */
> void ff_amf_write_object_start(uint8_t **dst);
>
> +/**
> + * Write marker and length for AMF array to buffer.
> + *
> + * @param dst pointer to the input buffer (will be modified)
> + * @param length value to write
> + */
> +void ff_amf_write_array(uint8_t **dst, uint32_t val);
> +
> /**
>  * Write string used as field name in AMF object to buffer.
>  *
> -- 
> 2.40.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".