From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BFAC441A36 for ; Wed, 20 Apr 2022 11:46:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E1EDA68B3A8; Wed, 20 Apr 2022 14:46:42 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8EA2A68B1DF for ; Wed, 20 Apr 2022 14:46:36 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 23KBkZUE027566-23KBkZUF027566 for ; Wed, 20 Apr 2022 14:46:35 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 66ABDA1513 for ; Wed, 20 Apr 2022 14:46:35 +0300 (EEST) Date: Wed, 20 Apr 2022 14:46:34 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220415080748.18517-5-nil-admirari@mailo.com> Message-ID: References: <20220415080748.18517-1-nil-admirari@mailo.com> <20220415080748.18517-5-nil-admirari@mailo.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v9 5/6] fftools: Enable long path support on Windows (fixes #8885) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 15 Apr 2022, Nil Admirari wrote: > --- > fftools/Makefile | 5 +++++ > fftools/fftools.manifest | 10 ++++++++++ > fftools/manifest.rc | 3 +++ > 3 files changed, 18 insertions(+) > create mode 100644 fftools/fftools.manifest > create mode 100644 fftools/manifest.rc I think the change here is fine, but the commit message absolutely needs to explain the full situation about what this does, how, etc. As far as I've understood Windows long path support, it'd be something like this: ---8<--- Newer versions of Windows (Windows 10 1607 and newer) can support path names longer than MAX_PATH (260 characters). To take advantage of that, an application needs to opt in, by including a small manifest as a resource. Additionally, the path length limitation is only lifted for file APIs that pass paths as wchar_t. Therefore, the preceding patches have refactored a few remaining cases to internally open files with wchar_t path name functions. On older versions of Windows, the newly added manifest has no effect. ---8<--- Does that sound like the correct explanation of the situation? // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".