From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v9 5/6] fftools: Enable long path support on Windows (fixes #8885)
Date: Wed, 20 Apr 2022 14:46:34 +0300 (EEST)
Message-ID: <a2f83d30-e8f5-927d-bcdc-24634884bf7@martin.st> (raw)
In-Reply-To: <20220415080748.18517-5-nil-admirari@mailo.com>
On Fri, 15 Apr 2022, Nil Admirari wrote:
> ---
> fftools/Makefile | 5 +++++
> fftools/fftools.manifest | 10 ++++++++++
> fftools/manifest.rc | 3 +++
> 3 files changed, 18 insertions(+)
> create mode 100644 fftools/fftools.manifest
> create mode 100644 fftools/manifest.rc
I think the change here is fine, but the commit message absolutely needs
to explain the full situation about what this does, how, etc.
As far as I've understood Windows long path support, it'd be something
like this:
---8<---
Newer versions of Windows (Windows 10 1607 and newer) can support path
names longer than MAX_PATH (260 characters). To take advantage of that, an
application needs to opt in, by including a small manifest as a resource.
Additionally, the path length limitation is only lifted for file APIs that
pass paths as wchar_t. Therefore, the preceding patches have refactored a
few remaining cases to internally open files with wchar_t path name
functions.
On older versions of Windows, the newly added manifest has no effect.
---8<---
Does that sound like the correct explanation of the situation?
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-20 11:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 8:07 [FFmpeg-devel] [PATCH v9 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi Nil Admirari
2022-04-15 8:07 ` [FFmpeg-devel] [PATCH v9 2/6] libavformat/avisynth.c: Remove MAX_PATH limit Nil Admirari
2022-04-20 11:32 ` Martin Storsjö
2022-04-23 21:11 ` nil-admirari
2022-04-15 8:07 ` [FFmpeg-devel] [PATCH v9 3/6] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW Nil Admirari
2022-04-20 11:33 ` Martin Storsjö
2022-04-15 8:07 ` [FFmpeg-devel] [PATCH v9 4/6] fftools/cmdutils.c: Remove MAX_PATH limit and replace fopen with av_fopen_utf8 Nil Admirari
2022-04-20 11:39 ` Martin Storsjö
2022-04-23 21:17 ` nil-admirari
2022-04-15 8:07 ` [FFmpeg-devel] [PATCH v9 5/6] fftools: Enable long path support on Windows (fixes #8885) Nil Admirari
2022-04-20 11:46 ` Martin Storsjö [this message]
2022-04-23 21:21 ` nil-admirari
2022-04-20 11:31 ` [FFmpeg-devel] [PATCH v9 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi Martin Storsjö
2022-04-23 21:06 ` nil-admirari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2f83d30-e8f5-927d-bcdc-24634884bf7@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git