From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E70C04475D for ; Thu, 24 Nov 2022 23:24:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6D7D268BA32; Fri, 25 Nov 2022 01:24:20 +0200 (EET) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A907368B049 for ; Fri, 25 Nov 2022 01:24:13 +0200 (EET) Received: by mail-oi1-f179.google.com with SMTP id t62so2821582oib.12 for ; Thu, 24 Nov 2022 15:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eu1cAgD9QCjMnBP41c5A7T2sS0TlvJcxtIJn0ez+bLA=; b=hCacTvU+P68Om+ci0VMkVFQBTIQu+9jGnno/qSoLc/KbYx/qiDroCWAbCTVzBHPReU 2YcayVzgCvJkcltX6ZubptzGJPP1wsChy6vYKSUwxJmJbvtWUUYs10w53YJ9vSEUwU5p H+3AOjNYUgp/dWysGEic7uLTbbTu8AdZb0E5PMl6MHsNCZ5NlWKVyy39ix+3I9QINoBe W0uVrPZ7qtA0vvd4UYUxSfcsU5EVZkEwbYBerUOQuYa0wlpPgeKaYtht9RQp1woenyys JLNj+EDQ9T1HS6pA4Vsp+QuF6zkLnaNi7qcbuZdFJI0Tb5iMdZevOgeMaePvlp2U7rax fWvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eu1cAgD9QCjMnBP41c5A7T2sS0TlvJcxtIJn0ez+bLA=; b=sBsTSOOWdkDrvsWGev/+KfWAi5fmR6lWrxOKOUm8rfNVdwdjeHdKkxYA8DyNmMFYnz c9hIOthgujES4zXdl5f9yhJyRyOn3zCcOzk1OJ5XAngLsk/4icKounHjt9cve8i01kqi GUhBtEEQO6j6/i5tmkfkcC9Pp8qVNS796EbbW7JJHP9tKI0SYZp1kI0DjPnlk4s+55nt seQS5U+QoGtqQsKRjEExZtOkUG1ZIX/Ky0DdaUETWFVOzvn0ecLfrTiINc1yLjtmu0r3 nZjqTkWloioqAdNMy1DT/t8RjPLth/j9EGXYsKfXI14GLTzRj3dPkaTYhaHNvAvBXErw B1eA== X-Gm-Message-State: ANoB5pkiXQk6VVe0rdfDjUisimJDUVICrSEFM2BNdSFsD8JR4mDrFQCM Xz+/mWwE9oUnpOShteunIDtpO2ihKpM= X-Google-Smtp-Source: AA0mqf4pq3JzVBAucXvMHFKR+/i7a48iSwX4iIXR33i5XMPE5iZ7Wk/w/6Nx3eBBIumKNg/JgjVFXQ== X-Received: by 2002:aca:6701:0:b0:35a:dea7:545a with SMTP id z1-20020aca6701000000b0035adea7545amr17014793oix.143.1669332251719; Thu, 24 Nov 2022 15:24:11 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id r12-20020a05687080cc00b00136a0143de8sm1154794oab.40.2022.11.24.15.24.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Nov 2022 15:24:11 -0800 (PST) Message-ID: Date: Thu, 24 Nov 2022 20:24:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221124230051.2874-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc: take into account component count when writing the SOF header size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/24/2022 8:12 PM, Carl Eugen Hoyos wrote: > Am Fr., 25. Nov. 2022 um 00:00 Uhr schrieb James Almer : >> >> Fixes ticket #10069 >> >> Signed-off-by: James Almer >> --- >> libavcodec/mjpegenc_common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/mjpegenc_common.c b/libavcodec/mjpegenc_common.c >> index 6dfc4469a5..049ae3d929 100644 >> --- a/libavcodec/mjpegenc_common.c >> +++ b/libavcodec/mjpegenc_common.c >> @@ -308,7 +308,7 @@ void ff_mjpeg_encode_picture_header(AVCodecContext *avctx, PutBitContext *pb, >> default: av_assert0(0); >> } >> >> - put_bits(pb, 16, 17); >> + put_bits(pb, 16, 8 + 3 * components); > > Could this also fix #2967? > > Carl Eugen Doesn't look like. The examples in that ticket have all three components, which was the hardcoded len value (17) before this patch. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".