Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
Date: Mon, 24 Mar 2025 17:27:31 -0300
Message-ID: <a2f12a0d-4b61-4433-b58e-4a4c4b1d5b65@gmail.com> (raw)
In-Reply-To: <20250324172242.1762-1-d.kozinski@samsung.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1930 bytes --]

On 3/24/2025 2:22 PM, Dawid Kozinski wrote:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> 
> 
> ---
> 
> 
>   libavcodec/libxevd.c | 12 ++++++++----
> 
> 
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> 
> 
> 
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> 
> 
> index 520fdab7d8..483700c81e 100644
> 
> 
> --- a/libavcodec/libxevd.c
> 
> 
> +++ b/libavcodec/libxevd.c
> 
> 
> @@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext *xectx, AVCodecContext *avctx)
> 
> 
>       }
> 
> 
>       switch(color_space) {
> 
> 
>       case XEVD_CS_YCBCR400_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): // XEVD_CS_YCBCR400_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_GRAY10;
> 
> 
>           break;
> 
> 
>       case XEVD_CS_YCBCR420_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): // XEVD_CS_YCBCR420_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
> 
> 
>           break;
> 
> 
>       case XEVD_CS_YCBCR422_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): // XEVD_CS_YCBCR422_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
> 
> 
>           break;
> 
> 
>       case XEVD_CS_YCBCR444_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): // XEVD_CS_YCBCR444_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
> 
> 
>           break;
> 
> 
>       default:
> 
> 
>           av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");

You mailer mangled the patch. You could attach the output of git 
format-patch instead if you can't fix the above.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-03-24 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250324172251eucas1p28dac6b240d775b289485ceb483444ecb@eucas1p2.samsung.com>
2025-03-24 17:22 ` Dawid Kozinski
2025-03-24 20:27   ` James Almer [this message]
     [not found] <CGME20250325063514eucas1p15a0d6c2b7047c2e61b1500e85fd09e33@eucas1p1.samsung.com>
2025-03-25  6:35 ` Dawid Kozinski
2025-03-25  6:45   ` Andreas Rheinhardt
2025-03-25  8:01     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2025-03-25 15:57     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
     [not found] <CGME20250325075648eucas1p191d4e82df18831d08b9e7f09dbca5a20@eucas1p1.samsung.com>
2025-03-25  7:56 ` Dawid Kozinski
2025-03-25  8:18   ` Andreas Rheinhardt
2025-03-27  6:45     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2f12a0d-4b61-4433-b58e-4a4c4b1d5b65@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git