From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2E846495FC for ; Fri, 15 Mar 2024 07:06:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E906968D109; Fri, 15 Mar 2024 09:06:47 +0200 (EET) Received: from fhigh6-smtp.messagingengine.com (fhigh6-smtp.messagingengine.com [103.168.172.157]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BFD8E68CDA0 for ; Fri, 15 Mar 2024 09:06:41 +0200 (EET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id AD0781140130; Fri, 15 Mar 2024 03:06:40 -0400 (EDT) Received: from imap49 ([10.202.2.99]) by compute3.internal (MEProxy); Fri, 15 Mar 2024 03:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1710486400; x=1710572800; bh=JHjLXSiPXKZfE/paGN2OBh8160Ol twMWgsRAgW1B+SA=; b=oh1ivGZqQN2Q9dYkdOnvNYtZOy6BjJod1N9ngXHFc+0z WVwW7UogSTwaSATORaAzWCMpCuId7AMLEf5c/4JGVxO7BZaAopNJljkD59+VpP5O KN5GN479IIvGRJTW9kpenkexdHysTthatUuLABzSfOvcynh5CbVriooXtcueTKMQ zdiZLFMhKg5BjXuQNdz0Dsiyxj+N1rgA9Z0MqP7s6IIHWQKDFEdELsrzF1WcFTc3 it+sXuNIQqWR4/rqkKsScCS0w0pCMvrdK5rsHiZi1yF2DmMZNpPanoVUvUiZjetl w+svjekXfPhirdikPSE8zKsS13eHbVi4xr92eTm0PQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrjeekgddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdflvggr nhdquegrphhtihhsthgvucfmvghmphhffdcuoehjsgesvhhiuggvohhlrghnrdhorhhgqe enucggtffrrghtthgvrhhnpedttdeufeejteelveetfefghfdtgefgleetleefheektdfh udeggeelleevkeeghfenucffohhmrghinhepjhgskhgvmhhpfhdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjsgesvhhiuggvohhl rghnrdhorhhg X-ME-Proxy: Feedback-ID: i06904239:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 3D74C15A0093; Fri, 15 Mar 2024 03:06:40 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-300-gdee1775a43-fm-20240315.001-gdee1775a MIME-Version: 1.0 Message-Id: In-Reply-To: References: Date: Fri, 15 Mar 2024 08:06:06 +0100 From: "Jean-Baptiste Kempf" To: "Andreas Rheinhardt" , ffmpeg-devel Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mips/aaccoder_mips: Remove MIPS-specific aaccoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 15 Mar 2024, at 02:20, Andreas Rheinhardt wrote: > ff_aac_coder_init_mips() modifies a static const structure of > function pointers. This will crash if the binary uses relro > and is a data race in any case. > > Furthermore it points to a maintainability issue: The > AACCoefficientsEncoder structures have been constified > in commit fd9212f2edfe9b107c3c08ba2df5fd2cba5ab9e3, > a Libav commit merged in 318778de9ebec276cb9dfc65509231ca56590d13. > Libav did not have the MIPS-specific AAC code and so this was > fine for them; yet FFmpeg had them, but this was not recognized. LGTM. -- Jean-Baptiste Kempf - President +33 672 704 734 https://jbkempf.com/ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".