From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 55919499A9 for ; Fri, 26 Apr 2024 23:57:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 68F9368D32B; Sat, 27 Apr 2024 02:57:14 +0300 (EEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07BA068CEB8 for ; Sat, 27 Apr 2024 02:57:08 +0300 (EEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1e36b7e7dd2so23965605ad.1 for ; Fri, 26 Apr 2024 16:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714175825; x=1714780625; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=0YfsZm/YGLzfiommOZSwGBpbgD3xg4XF2ORzP4K/gI4=; b=CbG+TeiMfdzdP5gTAFgeJCH5J5yfxo0JJUNbh3xzTF+fugJ2RMU02+F5eeI+fUbaA0 hWPM8HCqL81DJQ09ch54XuNaLwdIMY+bNdayIYR1EolJ2m24QxBGJ1fTlNaSj5cAa+B9 R4s0PDvQwg/maaNl3a2Mqg3/N664CCGFXBNnzU6/sGelj/K1vu701h5xKWMGhwCVhfgL XMRlI6WtYv/ncoDuzr0sahHsyjPf0Di/cijj/ge57fQz4y6hNCHpRdH7HErzSnsfQarm AWCQVi6a7f7nUJxr2IzOZ9B9sDAab7x7zRZ3MshDcLv48sPDULYXdMFJOa/LJfmfml2B qJPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714175825; x=1714780625; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0YfsZm/YGLzfiommOZSwGBpbgD3xg4XF2ORzP4K/gI4=; b=r91LqBtjVRjvxLs0bISdjnxUytpGInz2VKXDKuWO6QNbVKXxzdg0teg0EfdRTBOfUE ImVAK3qmKJKT4iP/JxFchwS//nSOR8M/19u3AZXvrnH3zwIcQn/2Yh/N0nuPOBdWGaMg 27o03cmYpkrFTqkn/pE3juYrwwOpY9O0G3eyIYyiKEL2TBXUP2zM+MgTru9TqlRBbnxP d5NnWFyAmadMYukbB6pvhWoOO2K1NAdbDGUBMcaTiZFf6LE4tc9atjISIZSe8bEHE7nq teheB/pZ0O5j8mr58dj5SPq9XB4DjuMAFTCFsaXvX7i4/VyTSxKlmSg4V60BrypC97BN xJFw== X-Gm-Message-State: AOJu0YyY+O5it4ZAnyhNeel50X6hj3b+ibagR7FighxS10nZ8q4CQwpu ThivnVbcwSbqbxI9mo+iKqWZg1CtpkSWgZnAVQ6c3d9IwcrBNnDj96kDCw== X-Google-Smtp-Source: AGHT+IFKvdkX1+KyL8ROh+nmsRJf+ZN1OUYJKR5cj/tqkreUipV0ZhIqicUjDHGwIBRr7tAfo5hYnQ== X-Received: by 2002:a17:902:ecc4:b0:1dc:3d5:bdcc with SMTP id a4-20020a170902ecc400b001dc03d5bdccmr1265196plh.42.1714175825119; Fri, 26 Apr 2024 16:57:05 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id u3-20020a17090341c300b001eb50eba52esm207267ple.214.2024.04.26.16.57.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 16:57:04 -0700 (PDT) Message-ID: Date: Fri, 26 Apr 2024 20:57:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240426235211.3718252-1-michael@niedermayer.cc> <20240426235211.3718252-5-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20240426235211.3718252-5-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/26/2024 8:52 PM, Michael Niedermayer wrote: > Fixes: memleak > Fixes: 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 97a24e6737e..5b8278f736e 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -8136,6 +8136,9 @@ static int mov_read_infe(MOVContext *c, AVIOContext *pb, MOVAtom atom, int idx) > avio_rb24(pb); // flags. > size -= 4; > > + if (c->heif_item[idx].name) > + return AVERROR_INVALIDDATA; I prefer to free the old one before the av_bprint_finalize() call instead of aborting. > + > if (version < 2) { > avpriv_report_missing_feature(c->fc, "infe version < 2"); > return 1; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".