From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 33FCA43E9F for ; Tue, 16 Aug 2022 18:49:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F3DD868B8F2; Tue, 16 Aug 2022 21:49:05 +0300 (EEST) Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D053168B710 for ; Tue, 16 Aug 2022 21:48:59 +0300 (EEST) Received: from postfix02.mail.de (postfix02.bt.mail.de [10.0.121.126]) by shout01.mail.de (Postfix) with ESMTP id 82CD2A0950 for ; Tue, 16 Aug 2022 20:48:59 +0200 (CEST) Received: from smtp01.mail.de (smtp01.bt.mail.de [10.0.121.211]) by postfix02.mail.de (Postfix) with ESMTP id 6964AA03C1 for ; Tue, 16 Aug 2022 20:48:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1660675739; bh=6q7kdlwiOI0CKwrq44q3haC43SCFUYlz1KGb4qtHVXg=; h=Message-ID:Date:Subject:To:From:From:To:CC:Subject:Reply-To; b=fUWjZFBYBiYhdYM5hMOURksK4th28EhiwA3JYK0423tMHIylBqgZ2oLsj734YBigl LolNUFjJLIS2HwwdTOMrl1b8PHRum+bC/ALxeaKkyXzpwqvBVUrAB9digZYSkorSp7 LHV3o5H8RmKvBI85/XLI9D2GXXKxG9QBIZxZlL0ParldEC8V1rmCzilSn0EzBihNIV lZUuA/MoTerF1MeBB4g8zkfdrQfkT5FfLQwnVZOmGFYbjrW2yAvYGg4eMzpvdCcL4d 0CreIt93/gwpBiM+BcoKCfWtxrnkQe2NAEjDffQADq8x6BljJ2HjS4LEJOhChGV2S7 7FPK3BlfMIgog== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtp01.mail.de (Postfix) with ESMTPSA id 22BAF100167 for ; Tue, 16 Aug 2022 20:48:58 +0200 (CEST) Message-ID: Date: Tue, 16 Aug 2022 20:48:57 +0200 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <3476fe9f-0433-99fa-0f0f-451f4062a7c8@mail.de> <166065902371.3205.13528205845420475535@lain.khirnov.net> From: Thilo Borgmann In-Reply-To: <166065902371.3205.13528205845420475535@lain.khirnov.net> X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 1415 X-purgate-ID: 154282::1660675739-000005DA-CBB11B49/0/0 Subject: Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am 16.08.22 um 16:10 schrieb Anton Khirnov: > Quoting Thilo Borgmann (2022-08-15 22:02:09) >> $subject >> >> -Thilo >> From fe2ff114cb004f897c7774753d9cf28298eba82d Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= >> Date: Mon, 15 Aug 2022 21:09:27 +0200 >> Subject: [PATCH v2 2/4] ffmpeg: Add display_matrix option >> >> This enables overriding the rotation as well as horizontal/vertical >> flip state of a specific video stream on the input side. >> >> Additionally, switch the singular test that was utilizing the rotation >> metadata to instead override the input display rotation, thus leading >> to the same result. >> --- > > I still don't see how it's better to squash multiple options into a > single option. > > It requires all this extra infrastructure and in the end it's less > user-friendly, because user-understandable things like rotation or flips > are now hidden under "display matrix". How many users would know what a > display matrix is? FWIW I think Gyan's request to do this all in one option that effect one thing (the display matrix) is valid. For the inexperienced user the use of individual filters would be the natural choice. Though i don't care much about how it's done, I can adopt to what you guys finally agree on. Having a patch for AVDict options is worth it anyways (even just for future use). -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".