Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

[Thilo Borgmann <thilo.borgmann@mail.de>]

Am 16.08.22 um 16:10 schrieb Anton Khirnov:
> Quoting Thilo Borgmann (2022-08-15 22:02:09)
>> $subject
>>
>> -Thilo
>>  From fe2ff114cb004f897c7774753d9cf28298eba82d Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= <jeebjp@gmail.com>
>> Date: Mon, 15 Aug 2022 21:09:27 +0200
>> Subject: [PATCH v2 2/4] ffmpeg: Add display_matrix option
>>
>> This enables overriding the rotation as well as horizontal/vertical
>> flip state of a specific video stream on the input side.
>>
>> Additionally, switch the singular test that was utilizing the rotation
>> metadata to instead override the input display rotation, thus leading
>> to the same result.
>> ---
> 
> I still don't see how it's better to squash multiple options into a
> single option.
> 
> It requires all this extra infrastructure and in the end it's less
> user-friendly, because user-understandable things like rotation or flips
> are now hidden under "display matrix". How many users would know what a
> display matrix is?

FWIW I think Gyan's request to do this all in one option that effect one thing (the display matrix) is valid.

For the inexperienced user the use of individual filters would be the natural choice.

Though i don't care much about how it's done, I can adopt to what you guys finally agree on. Having a patch for AVDict options is worth it anyways (even just for future use).

-Thilo

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".