From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 9D2794A13F
	for <ffmpegdev@gitmailbox.com>; Mon, 22 Apr 2024 10:17:12 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3BC7068D27C;
	Mon, 22 Apr 2024 13:17:09 +0300 (EEST)
Received: from btbn.de (btbn.de [144.76.60.213])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE05F68CD27
 for <ffmpeg-devel@ffmpeg.org>; Mon, 22 Apr 2024 13:17:02 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id
 CD38028A2F9BF
 for <ffmpeg-devel@ffmpeg.org>; Mon, 22 Apr 2024 12:17:01 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1713781021;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=DLz7GExcYgMyER5+SD7kkc+g7OZGof8xtBoFUvqy8ro=;
 b=L/JkhLSC8LN1Jlc6VD6bIPkJ5Msv+DKN+am4zPQ/21gigH7Z0b1bPwNKUQEO9H+NdPOVEw
 hBGKpWK4UqEY5SZPinBwVBRAKQwHWxXFyW8gTfUGrMT9qCGZkf2Pe5FwnPnGtSUlrISbDo
 MZkQJLZQFYzNcWglemcbmlwtY1bMbfI8ofr1aAT+0++8KA4w3VSlpD/b4Hld+D4tfqNO6c
 XmgEexnSg/aSZvdWL/4En5fJ1A7NVbvMe6XoXQ9kE1FnztggirL1BvqmBe4EHRgjeojHn4
 84TBuWDMCvtB1CXw6vJBg4s/TsxG5mOMCQNMLfTj6E1Y2FleYtNpjmD+RN7ZOA==
Message-ID: <a177ecc8-180a-4962-9e1d-87bb6d1471ee@rothenpieler.org>
Date: Mon, 22 Apr 2024 12:17:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20240422011159.4180004-1-michael@niedermayer.cc>
Content-Language: en-US
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <20240422011159.4180004-1-michael@niedermayer.cc>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret
 before checking it
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/a177ecc8-180a-4962-9e1d-87bb6d1471ee@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>



On 22.04.2024 03:11, Michael Niedermayer wrote:
> Fixes: CID1418336 Logically dead code
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   libavfilter/vf_thumbnail_cuda.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
> index 0459070800a..8efb54f0792 100644
> --- a/libavfilter/vf_thumbnail_cuda.c
> +++ b/libavfilter/vf_thumbnail_cuda.c
> @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>               hist[i] = 4 * hist[i];
>       }
>   
> -    CHECK_CU(cu->cuCtxPopCurrent(&dummy));
> +    ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy));
>       if (ret < 0)
>           return ret;
>   

LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".