From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C438742FA8 for ; Wed, 14 Dec 2022 02:19:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E233268B964; Wed, 14 Dec 2022 04:19:38 +0200 (EET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 712B868B72B for ; Wed, 14 Dec 2022 04:19:31 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670984377; x=1702520377; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=EH4+cCp3/wiplXM6b3iuEjejymRf7CVn/lfN+06tHyg=; b=hAIQabltnsrpotxD3ntsn+BK6V5ZUx5t775ERQLnXcjaQPRPTfiLJqlh 6giSbdHGM9DzOJDLnFfJTfzWvT/PAAJm2oAMcyz7eAehW34/XSa3Jqd3X 2XdHN2RMOLH7nbJamtREzoxRY/jsCpaovFk9lL2CkDOJQ1YWkZwDHnEN4 0EUtA163P8W/VIlaSn8FNp2gfqCpCHZl7tuxUF0SqIawWkJoYGtUSZI3x ZJLTvIW83L9iQ6y0VNYkudT3r3HkaU9Qjk7YwJnerjnFPk8D5zSBvTuPs qVTv9nOKabur5s4YETxhaI8rJwkGTdom4qWpZhLELP1uvP5AzpAbD3DmH Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="320155826" X-IronPort-AV: E=Sophos;i="5.96,243,1665471600"; d="scan'208";a="320155826" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2022 18:19:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="823102523" X-IronPort-AV: E=Sophos;i="5.96,243,1665471600"; d="scan'208";a="823102523" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 13 Dec 2022 18:19:15 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 13 Dec 2022 18:19:14 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 13 Dec 2022 18:19:13 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 13 Dec 2022 18:19:13 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 13 Dec 2022 18:19:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k7XwmDMg6UNGEeihYeNuszm0NHdoad+9nowRPnLPlIGl6dj7Li9XbVyw0x86azDgQxewejDd7QPv6J6dlqAvOfPHKgXF88iz4IONwebvVUldoKBjsJHev0yfm7bzqgaVYheewhlUszK9vFZqdrftbQ2PZbA0v0paaaci96rsxSzkWpbmSqZXI6pPPr6frgTsiNY53bSm+Y/sbHKjJQeP5xAOOFLcW+pF5ic7sIgN4K+jk6O+Clo91XGGjvTOcJMT4JmKr3t3g9DoARiuePS0w9UaM/PmCjNm3UAsn3ohzdBWZWWvpZ0718wSf02LWGhKV7WQiDmuhvD4z4S01OnC3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EH4+cCp3/wiplXM6b3iuEjejymRf7CVn/lfN+06tHyg=; b=fq0TuHY+iXelsuP0StkufsSuJzSvlt4+PM4wTQ0VRdPjlwDLTcItt/zOVGmC7V1ZroIRmaD3LUykDQyvAN1QwA5JcmJ6+3oPQdqz6oTaZ/Zu6NrTqmneqWFatk8GAb7bHJ9ESeHerD+7FxN0NREtYt0Nr0ni0cSpbQjcQxEbZtpW73ppAsQhLRWIdJtl3DxlXb1MtOrOxwp1Qc1rqdTCUcuPMzIsd94mgmiC/VyInx9b1K9rqfjPxJu4Y4cBv8vTnEVsrmer8PsDYdgqYWcU8vuI5iRi9TDO61Z2Q1/BN5lri6LGUKcxwRBKIFpldSo/u8J9K+pl+eGT5EyfJkmbsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by DM4PR11MB5327.namprd11.prod.outlook.com (2603:10b6:5:392::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 02:19:08 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::27dc:d5e0:94b2:6e9b]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::27dc:d5e0:94b2:6e9b%4]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 02:19:08 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH v2 01/13] lavc/hevc_ps: remove profile limitation of pps_range_extensions() Thread-Index: AQHZCHAxTPY0BGzNK0+xHS/C+CIdrK5ss+cA Date: Wed, 14 Dec 2022 02:19:07 +0000 Message-ID: References: <20221205060929.2511871-1-fei.w.wang@intel.com> In-Reply-To: <20221205060929.2511871-1-fei.w.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|DM4PR11MB5327:EE_ x-ms-office365-filtering-correlation-id: 4b6e10ac-618d-48f8-0ab3-08dadd7994a3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T/AHVRwjCCgF8hOWbE44bOI5tjwR9p9LK0j8MQEZdGbyIlzqpw71j7WHvTw419nRWTjitlrxOpuHwtdBWZpZ97cdVqd2FNJ7YAiam7dIhXqS6ELdRA0wVb9DP5umOmnCeEP3bKv0WGLfrJMAqDiO9FPBVg9CyCs1nzJh2a0klOsoNiS8D4QEHjwVFJ5DmEe8xW2+DW/+sbxYGM1pLbHLUw15NwZIHfBjyD+VENfDWP1S4FM+EsRj6QagkjRenQdw96g9nJt5cPCen8wdbPewiqSIxFD/xW0cOjFceH53hgfuv1o616A2q7yo3VyZE3BIwyq39OcKJWvkosRtjI+zjuywDKzRgv2ZBiIwlb0zjhF3klkhK9gen+zP1Ol9GcTxP30evK49DAD9pIHs7SVg3kPWz2hbF+ppQbibCzjxk6xO/QZdhRVTvaRlrU+zz4/C5j/r4is1CAsj2VT5MAJidXC78XvWGE/AbxDXYhfeMzeaaq4g08q5c6gjnErQsR6girQHeKOjMVED3UJppeQoR7RtKSimZzOHn0oGvVASlfBdqE4Zl5HLb40U9OYEqTIFYIT9oqNe9scMl8rodzkJd68G8/LttpEjBJyUvkMo/qCqqWc2Rz2mxu+kqBuGlTOr+0ryhNW2cJ6uMokuUkbIZ1Y6t5uBifPADmcvtErSoj4emaEmhUPpMUwkg5W52nDRJg3QaM7PKDUfvwMbme/L/B72mhkFY/bjycTeyMsv1zs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(366004)(396003)(39860400002)(451199015)(36756003)(966005)(6486002)(478600001)(71200400001)(38100700002)(122000001)(86362001)(8936002)(82960400001)(5660300002)(2616005)(38070700005)(186003)(64756008)(76116006)(66446008)(91956017)(66946007)(41300700001)(8676002)(6916009)(66556008)(66476007)(26005)(6506007)(316002)(2906002)(6512007)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bStudCs3Qy9odDQ5MWF4bitjdHlPT1BLRWV3NGY3U2huRWQ2R2FmMW1HNkdD?= =?utf-8?B?MEhicEZFUnVjZW1kak9jcDZYbVo0QkdreUhTQ003ZDdFd0RXOXZZOWUwR1Zn?= =?utf-8?B?eEhTbS9JSnh1WTFJWUFVdjdWby92UytzdlpvZkNoZjBjZURaaEFXOGFVUjhQ?= =?utf-8?B?eXBpS1BSdFBsdTJMcklNbTQ1WFdwSldlMUhoY3NaVDFVRlphRWxTMnZxWit6?= =?utf-8?B?ekpqdDZ1VUI5QTlVV1dldTVNRTRLWlZ4S1hueW1QYy8zajdjQmoxV1RFR0pt?= =?utf-8?B?cUN1Z0p3TXNZNG81T0EvdG9aRU5VSjQ3bktDRVltNFpER0tQQWp1SlROYm9s?= =?utf-8?B?dktmMXd6VW0zT1JobzFLRGhYcU0veUtEWWpNSGxvUGNGQ3ZOVW5CQjFCWVhD?= =?utf-8?B?SjVNck1PQUpoS0JwbmNlSlVmMWJxallBdEhJdllTUnZibTFpQi9zWjJ1U2Y2?= =?utf-8?B?Q082Y09od2lvOFdRM1hIQTdqeDlzWnhjOTZ3MXpuY05LTFh5MHlZQXplbWNH?= =?utf-8?B?ZGROSWFLY1R3dDhMRVpLRnRITVdEWTBiQ3lMWUNKWjVZQmgyKzcra0l2WGlW?= =?utf-8?B?T1EzWDdvMm9sNkJnQXlqbW9rSkpkRFErSnlpZnQxcnN3bmRxWkg5QjY3NCtN?= =?utf-8?B?TXppMjhKV2V5eU8xZHcreVhSbFNYdk1Va0M0ZE9nYThmcEtBY0pudVJ3SlhM?= =?utf-8?B?MHN4dmc3WFBxbVFqbm9FcTNES0xSallaNm5nZkdqdTFGaGtoTUVsOWYyd3N4?= =?utf-8?B?MEtocHdBYllKMVFENzBlTWRIM0xPTUhjS2VBWnlWZHl3T1JGQ0xhVWMzZmow?= =?utf-8?B?MUhMNk0vdXRMa21JVUJqN2lEKzI0L05PMUdLYUlBZDM4YlRIT1E0c3Ayb1ph?= =?utf-8?B?eDhpM0N5Yml5M2k3VzhnVjJyUzNnL3h1S212bzlZeWZpZTZzN0hrTDEyT09w?= =?utf-8?B?NTdHbHg0akRRSEN3SitLRDVtbllmZFBjTFpRenpnZHRuYnJ1czRoU3B3bHlu?= =?utf-8?B?RE9MdVFxT3ZPOThNRFN0blhnNnNKUTBNdFdOMTUvbXhUcGgwblRlWUpDSVlz?= =?utf-8?B?VnhNbUFGWHRuaWFXRXRlL3Fka0NrK1YzN1J4dHN5UlkvNVo2RmV4VUE5RVZD?= =?utf-8?B?Yzk0VWcxa1VUaUZLbG9xaEFRczVKVDdBOXhjVUo0SS8ybjdIemhTQ2xyM1RU?= =?utf-8?B?dHAxdmVDOGs5ZlVScEdFWXgyM3gySWJmS09NM0lUbmNzSnhZMnZESnFJMHZE?= =?utf-8?B?MFdjQWZHMy9hamFSYy9nTDBjSmhDY1RENWVYa3BOZGJ2d3FVbzNnOXoxNTlq?= =?utf-8?B?bEExL0V3WGZObXV6TTlBREw2YXBlTHhhMzd6b2N3c1Y2cU9nalF6VlB2NktX?= =?utf-8?B?bkdlUWhvb1JRRTdnaGV5SGNVUkdnaFFkbkJJRmpDMDg2VzhzN1RGamJPUnNa?= =?utf-8?B?NkRuRGdXcmhEdGx6K2F6L3NDbkVxTDh2WlJYZUd0WUlsajM1Nm9KVmo1N2NO?= =?utf-8?B?NnM2SnNJUFY2amExcjdXdVZzR2x6YnVxMGNIczZJVkhzbi94dDlnVnBvWStS?= =?utf-8?B?dENVQmtKMWluNGRseW9heDAzTHlvZTY3VmFoTU93OUQvSFUveDRPUUdURVVU?= =?utf-8?B?Zmg0UThFTHhWazVKM1B0Yi9YWUkrcEk1NzN2aXRFeEV4bFcwejhNTDlBb1l1?= =?utf-8?B?RFIvVDczZzhxZFgwdkNIWnRPeWVkbFoyNGRha1lDcVdINExEQ2hBcnV5citE?= =?utf-8?B?TWd3QnUrU3NRY1EvN2RSOHhEdkRHTmZTRU5BVVFtQzV6V3dJSmFOYit1aGZL?= =?utf-8?B?TkFmOEFFVG5IN2t1bkd3YXB0aDFSdXhiaHp1alBSdms0WlZJUllhWE9sZ1Zi?= =?utf-8?B?UUFCcUtnb25zL2owTklGYkF1UG9XYy9hdVIvbWpobEFqZzhOV0VYQllOaGhl?= =?utf-8?B?TWNCMEVBRDZlQmFiZzdVYTlsQm9EODRQZW44SG84NWJoVFVpdStUdXU0RFRu?= =?utf-8?B?MVprTSt5emhWT0pBS2p1bklxMFZ4SlA4VmxZb3ZsZG1GbkF4U2VhUDFtOFhE?= =?utf-8?B?NlZqcG9LVDFJMlQyaDNlZlZFYUpsQ3R0bmRTUmtUak1WTjMxTVQyZ2UyaFZK?= =?utf-8?B?cTZ5ZDVGWi9HcWU3eGdZby9yVjBtQ3JRNDRXUEU0Um1ZWkorc2ZvWGNpRkxq?= =?utf-8?B?OXc9PQ==?= Content-ID: <918B00FB00727B4C968C6DAC465EC8E6@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b6e10ac-618d-48f8-0ab3-08dadd7994a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2022 02:19:08.0528 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ihyquuF84/Fy5mUec/W+tUe36miNhiNPwYwPS3ht04VzT6BzblKFq5DWilRJkyKHPTk3Rn0no73yq6/xQVGZOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5327 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 01/13] lavc/hevc_ps: remove profile limitation of pps_range_extensions() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-12-05 at 14:09 +0800, Fei Wang wrote: > Follow spec 7.3.2.3.1. > > Signed-off-by: Fei Wang > --- > update: > 1. fix uninitialized variable which may cause segment fault. Ping for review this patchset. Confirmed with Qemu locally for Loongarch64 with: https://github.com/sunhaiyong1978/CLFS-for-LoongArch/releases/tag/7.0 The FATE test hevc-conformance-PS_A_VIDYO_3 pass without any error. Thanks Fei > > libavcodec/hevc_ps.c | 2 +- > tests/ref/fate/hevc-conformance-PS_A_VIDYO_3 | 50 ++++++++++------ > ---- > 2 files changed, 26 insertions(+), 26 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index 5fe62ec35b..537a3ff99b 100644 > --- a/libavcodec/hevc_ps.c > +++ b/libavcodec/hevc_ps.c > @@ -1658,7 +1658,7 @@ int ff_hevc_decode_nal_pps(GetBitContext *gb, > AVCodecContext *avctx, > if (get_bits1(gb)) { // pps_extension_present_flag > pps->pps_range_extensions_flag = get_bits1(gb); > skip_bits(gb, 7); // pps_extension_7bits > - if (sps->ptl.general_ptl.profile_idc == FF_PROFILE_HEVC_REXT > && pps->pps_range_extensions_flag) { > + if (pps->pps_range_extensions_flag) { > if ((ret = pps_range_extensions(gb, avctx, pps, sps)) < > 0) > goto err; > } > diff --git a/tests/ref/fate/hevc-conformance-PS_A_VIDYO_3 > b/tests/ref/fate/hevc-conformance-PS_A_VIDYO_3 > index 59b82b72bb..d1d86b2dc9 100644 > --- a/tests/ref/fate/hevc-conformance-PS_A_VIDYO_3 > +++ b/tests/ref/fate/hevc-conformance-PS_A_VIDYO_3 > @@ -3,28 +3,28 @@ > #codec_id 0: rawvideo > #dimensions 0: 416x240 > #sar 0: 0/1 > -0, 0, 0, 1, 149760, 0x88619f80 > -0, 1, 1, 1, 149760, 0x550bdaf0 > -0, 2, 2, 1, 149760, 0x4121f7a2 > -0, 3, 3, 1, 149760, 0x210b1d07 > -0, 4, 4, 1, 149760, 0x731b7758 > -0, 5, 5, 1, 149760, 0x17adb789 > -0, 6, 6, 1, 149760, 0x98b2f080 > -0, 7, 7, 1, 149760, 0xc0be1f2a > -0, 8, 8, 1, 149760, 0xc01e387a > -0, 9, 9, 1, 149760, 0xd932822b > -0, 10, 10, 1, 149760, 0x16c0a1df > -0, 11, 11, 1, 149760, 0x5aa6c005 > -0, 12, 12, 1, 149760, 0xd3aab602 > -0, 13, 13, 1, 149760, 0x4e6ecab1 > -0, 14, 14, 1, 149760, 0x8a86f1f2 > -0, 15, 15, 1, 149760, 0x2ed21e1b > -0, 16, 16, 1, 149760, 0x80892f24 > -0, 17, 17, 1, 149760, 0xb8a952ef > -0, 18, 18, 1, 149760, 0x557e57fb > -0, 19, 19, 1, 149760, 0x2b825b2c > -0, 20, 20, 1, 149760, 0x30b69b5e > -0, 21, 21, 1, 149760, 0x802ebf08 > -0, 22, 22, 1, 149760, 0x95aadc8e > -0, 23, 23, 1, 149760, 0x4d4c02b7 > -0, 24, 24, 1, 149760, 0x3fdd1762 > +0, 0, 0, 1, 149760, 0x5c4f70f4 > +0, 1, 1, 1, 149760, 0xf4628e59 > +0, 2, 2, 1, 149760, 0xa28e5bdc > +0, 3, 3, 1, 149760, 0xda0e53d7 > +0, 4, 4, 1, 149760, 0x42dd334a > +0, 5, 5, 1, 149760, 0x25ba9dfe > +0, 6, 6, 1, 149760, 0x8854d8ca > +0, 7, 7, 1, 149760, 0xc04505d4 > +0, 8, 8, 1, 149760, 0xd3fce146 > +0, 9, 9, 1, 149760, 0x8bfd88bd > +0, 10, 10, 1, 149760, 0x33d965b2 > +0, 11, 11, 1, 149760, 0x12746b7a > +0, 12, 12, 1, 149760, 0xb7642694 > +0, 13, 13, 1, 149760, 0x32b5035f > +0, 14, 14, 1, 149760, 0x7bea0af1 > +0, 15, 15, 1, 149760, 0x577d4fc8 > +0, 16, 16, 1, 149760, 0x023a9c66 > +0, 17, 17, 1, 149760, 0x9abe76c4 > +0, 18, 18, 1, 149760, 0x2b14dba5 > +0, 19, 19, 1, 149760, 0x7b8affcf > +0, 20, 20, 1, 149760, 0x21e4c323 > +0, 21, 21, 1, 149760, 0xf0b7d9cd > +0, 22, 22, 1, 149760, 0x4db0c5bc > +0, 23, 23, 1, 149760, 0xf455f752 > +0, 24, 24, 1, 149760, 0x569fec99 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".