From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A666149A28 for ; Mon, 27 May 2024 14:11:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D98D468D41F; Mon, 27 May 2024 17:11:26 +0300 (EEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3377A68D2A2 for ; Mon, 27 May 2024 17:11:20 +0300 (EEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6f8e98784b3so2432229b3a.1 for ; Mon, 27 May 2024 07:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716819077; x=1717423877; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=uYe/x5wc9yLUIwG1+f+CDZBKnf+TmVV93FXW7HdzoZU=; b=N0u0D8n3PMbrvSH6ntfmzhFU/U49SsdxYhZXv5HSJCsoFW0JTGidZDznWdmR/i9Ccu Q/JGcqnexapf65ptM3GruZqW5YQ6tcTjBSheXuE3aYuLvaTzx4izoJeGZbyp5s6ws2ZV 1618JiXmJlhe+8Gr+ksnNZFZuIPj5bD1wjwzwU8u5OtFepDlOW2g0ncUYodhLsxoEZPA srsJoEYeZ+kNJnY9K8orF5n8QSLplZByYwB+PDVvkSyB8ndDJrb3QPVzHBsI+eIVisgX e2TElcdDGP06r2hCIWQ5304tg20fKqwnqSZMpcsKAe96UTF44hAj3yGJrDD/zdc7Q5f8 ZEew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716819077; x=1717423877; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uYe/x5wc9yLUIwG1+f+CDZBKnf+TmVV93FXW7HdzoZU=; b=QknsWLF3Tzz5ThX+HCFKgvCuT6PtA0NCiQ5llxH5XaBXcRvKc3+000qd90OmujUxHj U/MfUWKveJx1xC890HaCEY73OfXR9hcevvMHEJx+GFxGXFjmiBy7GUyXVc1zrkOqr0ys WKPu0zlZSnNuMzP6FUzZFejK7vF0l0O1quw07H5RhJx3q6w+am6Cjqbkj1vwUKvdIpTw pMFT6G/Y5ZLk7aqJWlrgnIFcMXrKpnPpfhlOIW8JruDxVBSdVWY4y4wyyBcPWtQxn2/v IKaMmZFrP2xcdfpihC2Q7w+Bv4BW1cD/GmO/mmlYoGD7IdEB7v9Xw6XNQedOPaJfYEFU 2wnA== X-Gm-Message-State: AOJu0Yy/wJ3l91ZyWt9DzaBaJl56t8uNtreTi72g17lGTSrIVtMi9LeX JKT0DeahNc9cxvb+BncNLyVsyfGJJcyvIIaFyy6Mu8pyNe5lFG6A8MogvQ== X-Google-Smtp-Source: AGHT+IGdHwFNXVl4i9GH8wm7iEY/jUxYndTkHzyMpRLk6Rhz6MIPgIOE1jyZ9RDus45g79I7reaM6Q== X-Received: by 2002:a05:6a00:1d8d:b0:6ed:5f64:2fef with SMTP id d2e1a72fcca58-6f8f34ad015mr10722004b3a.17.1716819077051; Mon, 27 May 2024 07:11:17 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fcbf5388sm4919798b3a.136.2024.05.27.07.11.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 07:11:16 -0700 (PDT) Message-ID: Date: Mon, 27 May 2024 11:11:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240427003623.118199-1-michael@niedermayer.cc> <171679774316.28895.4366606367617414113@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <171679774316.28895.4366606367617414113@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/27/2024 5:15 AM, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-04-27 02:36:23) >> This allows detecting issues in side data related code, same as what >> framecrc does for before already for packet data itself. >> >> Signed-off-by: Michael Niedermayer >> --- > > I am against this patch. Checksumming side data is a fundamentally wrong > thing to do. framehash should be updated to also not print hashes, then. Problem is that it's versioned, so we would need to "deprecate" the current versions. There's also the issue of printing sizes, which for some structs (iamf, video_enc_params) it can vary depending on target, so my suggestion was adding an option to disable printing certain values like it. What do you think? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".