Re: [FFmpeg-devel] [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 version

From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 version
Date: Fri, 29 Dec 2023 13:43:36 +0100
Message-ID: <a0b11652463a81ce641a05e54205fd71df22bfaf.camel@haerdin.se> (raw)
In-Reply-To: <20231228233040.GB6420@pb2>

fre 2023-12-29 klockan 00:30 +0100 skrev Michael Niedermayer:
> On Thu, Dec 28, 2023 at 10:21:23PM +0100, Tomas Härdin wrote:
> > tor 2023-12-28 klockan 21:29 +0100 skrev Michael Niedermayer:
> > > On Thu, Dec 28, 2023 at 07:43:09PM +0100, Tomas Härdin wrote:
> > > > libcodec2 has reached 1.X so it's about time the bindings
> > > > receive
> > > > some
> > > > attention. This patchset also includes some much-needed tests.
> > > > Where do
> > > > I submit files for inclusion in FATE again? They are very small
> > > > as
> > > > is
> > > > to be expected from a codec that runs at 700-3200 bit/s
> > > > 
> > > > /Tomas
> > > 
> > > >  codec2utils.h |    6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > > a79a98f8ffc27ca6d79c9d373957fa0bdc985ef2  0001-lavc-
> > > > codec2utils-
> > > > Use-actual-libcodec2-version.patch
> > > > From 7205e741aaadc354b403010c97f9cd803eec612d Mon Sep 17
> > > > 00:00:00
> > > > 2001
> > > > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <git@haerdin.se>
> > > > Date: Wed, 27 Dec 2023 17:32:21 +0100
> > > > Subject: [PATCH 1/6] lavc/codec2utils: Use actual libcodec2
> > > > version
> > > 
> > > This breaks build here
> > > 
> > > CC      libavformat/codec2.o
> > > In file included from libavformat/codec2.c:24:0:
> > > ./libavcodec/codec2utils.h:26:10: fatal error: codec2/version.h:
> > > No
> > > such file or directory
> > >  #include <codec2/version.h>
> > >           ^~~~~~~~~~~~~~~~~~
> > 
> > What version of libcodec2 are you using? I don't think we can rely
> > on
> > versions that don't expose version information, which only comes
> > about
> > because I explicitly told them to please expose it in a header. I
> > don't
> > think we can even probe version at configure time otherwise.
> > 
> > libcodec2-dev on Debian bookworm works for me
> 
> i think theres no libcodec2* on the box and this header is used
> outside
> checks for libcodec2* ...

Right, the demuxers and muxer can be used without having the library
installed. An #if CONFIG_LIBCODEC2 with a fallback to a fake version
should work. Given that 1.2.0 is the latest release that seems a
reasonable version to signal, indicating "1.2.0 was the last time we
checked that we're compatible with libcodec2"..

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".