From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 62E6F40983 for ; Fri, 24 Dec 2021 13:43:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AD6C68B2D4; Fri, 24 Dec 2021 15:43:26 +0200 (EET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 226DF68B1A0 for ; Fri, 24 Dec 2021 15:43:19 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640353405; x=1671889405; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=vrMVlU7Z6tgZ4fN2UYicuhAimX+jz7Pp2Op3IwxjQiM=; b=MQC4kg0VmNGcVWtoTkkMChqFYPDgEiIqPx/Pb7DJYCqI7Thnno7G4gym /7rIrmE69Glq2kIroilD4xPmHD3QP8SCF6H/3YWBpk5ZzZBQT1awAAOfs pVg4V/qHdMSm4MCJNSZvNu09C2kAHIOyl6+3OxN0m8Zvt0RbKd71pP57g O89tcn30vhrOi74rL3n7kZV3ORSSdSZQCpaVYSbcmRMHIfUDFyFPzmdhJ L1B/ij2tUEabeq4aF89tVW9BmmK97cGBY3n/7HO4ahSNjs23L9tzTSYnS 90r3GoJqJkxb+9YnnoG96dLwWKSgp/VuLdD20AUHiW0mz3u4g0BOZaoV6 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="239761783" X-IronPort-AV: E=Sophos;i="5.88,232,1635231600"; d="scan'208";a="239761783" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2021 05:43:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,232,1635231600"; d="scan'208";a="509161598" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 24 Dec 2021 05:43:16 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 24 Dec 2021 05:43:15 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 24 Dec 2021 05:43:15 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 24 Dec 2021 05:43:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XiA4GXPcQGCmx6bH83Uywfo4xTClaqrQrQsvlpl1Q8Hla/6WURHCtNXcXa5wy0KVoSeEeiNsVFMXGaVomPex+6rV2R1ObQEnmQs3sn/fd4bI3umX0dFXafY2KkQQnrGt3cRj2I78Y1lcZlyDGdY/RC+FJF4qRyxL+/fCg+ugWr78wqPGDoYmw5koIS8wC5beaF7WKn6kBQWLZL8y0KeEzuwqq7AXLUGPa2if76/BlTtGoESJmIfntm1aGIVX6dIQwUnnV6ASuEHu3fPZEY5IOGORSXlpXUu/UdWb4ohZP/8KzCrMCwlf3hUYkSp4+qmA3zKyAHUq3mQq/Osv0lGetA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vrMVlU7Z6tgZ4fN2UYicuhAimX+jz7Pp2Op3IwxjQiM=; b=BdhFEEv0SeMJzeJzGTYQY20sF8JVwzBVBlpgOq7cFnJ6VfDkBNlpjzAVRqHbhVoGNG5THJ71+VmhoR/L3/NLA9yhrerWpNPL8VUhZS7m//Yha9GzG9xAZFJra8QjA5HnX9XNJi8/Wu049eICqOI3vMTZINYl0i2kablkLvgAvcSPoNYipyG498DmaPFxjUgaI5hyFz23MDRTU4p1JH4cITKU7sqJihft05AQHL7MzVwVTz0ZgQFqT5PMA7JDcmeyZAtGd5Atv0CPWHCLmpy3H/4Osioo+vtjuSsQmuIRfKc1YgTdBa+fSofz+4xi2LDoOB0iEwzb2i2+I6z5I9Qg/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN8PR11MB3633.namprd11.prod.outlook.com (2603:10b6:408:8a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec 2021 13:43:14 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16%3]) with mapi id 15.20.4801.023; Fri, 24 Dec 2021 13:43:14 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option Thread-Index: AQHX+J7KWrLgQbEG+kaG1dP1eerKmKxBVI+AgAAS7ACAAD+pgA== Date: Fri, 24 Dec 2021 13:43:13 +0000 Message-ID: References: <20210806021033.31954-1-haihao.xiang@intel.com> <6196106b1fba86f91e4587afb9cbfe3527f582a5.camel@intel.com> <20211224081715.GA29574@gmail.com> <8934708a136d272ca0df2d3160f11b121722a49a.camel@intel.com> <20211224095520.GA6726@gmail.com> In-Reply-To: <20211224095520.GA6726@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dbee2805-ec92-4e75-cb94-08d9c6e3555e x-ms-traffictypediagnostic: BN8PR11MB3633:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SihBLdEn8FfvKVSYHxrw4UadD5BGiAp/pj3pypMbD6oSo6U2Dnx6ZtrcA/3OZZxI3yiHg96PdpKiEu/jWAppJnEbF6IATGnbVXUiSaXQbChW8iKnlcWH1rRLO6N8fzvGMuXbC6x0gVFFQ1ZLZgwrHw7dX99vUUUx4ibfjPQac4aqyn66dMQHP/A1ucN0HV3acrqbEtDFFQ/1lqOUjK3WZEcfEMEk4/DfTYxB0buwicqsF9KwmrV2k77rkp1syWMMQSiAcf69humd7v15Vw5ZL/q6gKrsSDSol2fPqNIFwtorYGlyYhOBOfYao5sdE7Up6TGiI6b22/E1x7x7cZUhGYtXR/Vp1g95LsWEGjMDd875YCPejYw1tcyqCZsAE1ic76F44szVd5CEwM5JYQKmDE8+eEzvQBrlufutcih1ru550JM4ZUKa3IhtIoM1GPfG9MaUE65zJkUw+YKIPw+kClPAJBk0MgS4ys2xe/tYLl0Y+66N2baLUzRFb5Dmx7B64rvIitd/+poEqEeHahpxmjnNA6bYHBFMKeTM6OTq4o+fU8/7CXmG6InerLHWJ+gh7ryGyu62ZpMe3452tneLFPGhgkCyNrJ9OEOLTbMlaqM7I+nulWekXIWtGWFUaoHkkI5CV88aDybfdRXv1HOc0aEtE9TlJtZeHWa3WDLvEO4iZ+D72cbtAomNBm5XxGqUEeB85RoUnh0IbzdfLBCLF5O2uY646e7keTIwSrM+Jwc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(71200400001)(508600001)(6486002)(83380400001)(38100700002)(122000001)(82960400001)(38070700005)(186003)(36756003)(76116006)(86362001)(91956017)(6506007)(26005)(6916009)(8676002)(316002)(8936002)(2906002)(4001150100001)(66556008)(2616005)(66946007)(6512007)(66446008)(5660300002)(66476007)(64756008)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UVNacmpqWE5icjNacFlvYVYwRXhMLzJCdVZsY2hGZHVnbTBsRU1PbmEvT3p3?= =?utf-8?B?L1hpdE5WWlZPeFdyWXlJTGUvQzJlenV4amNHUFJ2M1lXbGJLMlJ0emcrMVl5?= =?utf-8?B?RThNNUtqRWJHRWNHcVZjeXliSmdmaHNVYzhBVGpFY1VsRlg0alV1TUpvUVhu?= =?utf-8?B?d3h4Y204SzJ5bEdXQ3pWaWxsaW1VZmR5L2tQb2lDM2VKdXcvb3hXUkV6c3BJ?= =?utf-8?B?SER0eW1WYm1qbHRZQ09HdExiTENZdzNGNWZKY2VuZVpDSDdoTUtGRWl0SVB2?= =?utf-8?B?WnBYcnpROHZZWGQwSjdOTnZYbExrQU0yUGxkN0E4UU5LdThUZ2VDU2NIV3cw?= =?utf-8?B?dm1vUmZOaDl5UnpOdXEwVGNyNkcvdnh2ZVNFREZRN1dJUGtzQ05vV3lNSThQ?= =?utf-8?B?M2NKaGNCQ3JKTkFpeVVRN3pZNXVZbEpWczdtM1lLZENYRnpkV1E4N2s1T003?= =?utf-8?B?VFdUSHhPc1FlOFBGM2R1SUFIR1VqUE1LUjgxa1pyc1RISFVNOTRUWGJaOWhU?= =?utf-8?B?dTlZU1ZRVit4OHk4TmlrcklTL1RxMWtJUEZ4d2RKZkQzTFZaNXB6NzJkVlNU?= =?utf-8?B?R0kwVHJLYnJTMmNLMTJ4VDNNNGJxU3lBTlo5M1VlWVRWT1F2UjZNRGU4MVF4?= =?utf-8?B?dUtudUlLbmJWaVpyazVSbWdRU0g4cSt6TVB2RHhxOEk4L2JRQ1R4T2poTHpl?= =?utf-8?B?NzlGeVVPNjQxUzM0eGV0U2c1Um9MaWZjem1aRUtNQXVzNGZuZUtNYTlBUUc4?= =?utf-8?B?VGJlMERKVkxTdDMxRklJb0NnL1g3ZFpWUStLZVcvMTBiM3BSQ1EzY0xKUWJK?= =?utf-8?B?cEluRllCdDZtNHFZc0NtN1BXWm92c2cyNmlpNVVGN3hsTFN0OHFkNWU4bThU?= =?utf-8?B?OTBNN0dCT1ZQN25Sa3NSWElqbFQyUDJybEJPK0E5dDVVYWMrOUpsTTJWczJi?= =?utf-8?B?UkdDT3dVL1IwMVZZYnBwaG5SOU9ZM25IR1laenZhVzFnQmNtRUJMR0Jqb2Ny?= =?utf-8?B?Z2xqUHVXOFJGbXFoY1RTWStGWHNRQnA3V05mLzFSS3dZV1FnN1gxMVUzOFBR?= =?utf-8?B?WWZqYWVnMm5jT3N6REFLQy9rZHhZbWllQnNoODJEU2MzUmtHR3h2V0lCeWZj?= =?utf-8?B?c21ZeFRudzJqNHdUbzhiM21EbnZTdU9wQXhDUklDVkNiaVVxL3BPZVNYUWY1?= =?utf-8?B?bjdsTGVEUVdwQ2k1L2pER1JCdEFVQlBtaklLN2pEWm8zUGNzZUNMMVR4d28z?= =?utf-8?B?SFBrOVJQUTZxTVNvbnlJS2s4MmR2YmVFdy9rVjdKelM3Q29jeEErcUFWS2x6?= =?utf-8?B?M3dRTXY1Slg4L0xzRG9IYXZnNG5UWTJ3VW12L3hCaWNST252SW1jdzVuTllu?= =?utf-8?B?d2RKcVg1WCtYNExmdDlWU2VpVDFBV0JaN040YWZlVXR1MHZHbUtwWXlmOU9H?= =?utf-8?B?d2VxVGdlS21HaFZZTzgwSXlnSTA3d0tRVnB0amdtMGZSSHoyR3pnYXN3NTFr?= =?utf-8?B?S2pFbjJEWTJuUFFPd29UUkF4V2xHcDgwVnNkdU4rTFFJTlRnTTFhY01Nc2tH?= =?utf-8?B?WDR6ZWNGTlg5M3NvSlRZUU95VVd3YjVSbGlrelFHS2JSUGZ5Z3NOdTVaMzZI?= =?utf-8?B?ek5ISzhGd0xCbUdtNklGTlZQRERmelpiSG1sdGlOR0ZRVUw1aUxRZ2J1d3RW?= =?utf-8?B?RldTcGhSc0ZiSTAwNVRrVGg4RGl2OUIxRGlBeWRka25FSTRkbXRJMDdVL1Ni?= =?utf-8?B?N3NHZ1p5eXA4bVhVallneEE1ZGp2akgvbzM4cHBrRDd4MyszelBhTWViRCtz?= =?utf-8?B?Z1RDMEN5RFZGUEF4SCtoZ0w3MUZkSktzSUU3V2ozK0ZyeGhJZVl2ZEFNMTZO?= =?utf-8?B?VHdRMG5UWGhya3laNmJrWDk2aEdtS1VSYnNNb1hrT25tUE1jNHdaempOMFho?= =?utf-8?B?ZGZkYUlIVXFKblBKK0FBWjdXejB5bXN2dURHS2NTeUUrTC9NZmUwVXIyY2Rt?= =?utf-8?B?TEhldUxsQ0gvNUpXK3J1cjYwSVc1QS9weTVmQ2JCRTVVOHVIVHdqNnE4TGI3?= =?utf-8?B?NVd4RWREK3BvSFl4ZXdoT21LYjMvdUFldlFRamhwUnE3SFdWWW5RcnA1Nk1C?= =?utf-8?B?NjIrd0g4L0VVYWQ2eVhCRzI1Wk1jTnQyMzBWMzdzNEhCTkJCUVByZkd2TVpo?= =?utf-8?Q?vWaeP47RrfaJK91v37pR31S6mwyzQ3Ih2S2Cj5y916MW?= Content-ID: <627C07009DD86649A6D992EB2A88E457@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbee2805-ec92-4e75-cb94-08d9c6e3555e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 13:43:14.0850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4Jj/pXmwhZ870dNbKFzM/t3XQoJkSQKkJETFf3fu7rA9eNaxC5pAhFShWGFxzbOo8TxBXtlZjb+pdWB4Drf39Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3633 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2021-12-24 at 17:55 +0800, lance.lmwang@gmail.com wrote: > On Fri, Dec 24, 2021 at 08:47:38AM +0000, Xiang, Haihao wrote: > > On Fri, 2021-12-24 at 16:17 +0800, lance.lmwang@gmail.com wrote: > > > On Fri, Dec 24, 2021 at 07:35:25AM +0000, Xiang, Haihao wrote: > > > > On Fri, 2021-08-06 at 10:10 +0800, Haihao Xiang wrote: > > > > > The SDK may insert picture timing SEI for hevc and the code to set mfx > > > > > parameter has been added in qsvenc, however the corresponding option > > > > > is > > > > > missing in the hevc option array > > > > > --- > > > > > libavcodec/qsvenc_hevc.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > > > > > index b7b2f5633e..1e31968673 100644 > > > > > --- a/libavcodec/qsvenc_hevc.c > > > > > +++ b/libavcodec/qsvenc_hevc.c > > > > > @@ -248,6 +248,7 @@ static const AVOption options[] = { > > > > > { "tile_rows", "Number of rows for tiled > > > > > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 > > > > > }, > > > > > 0, > > > > > UINT16_MAX, VE }, > > > > > { "recovery_point_sei", "Insert recovery point SEI > > > > > messages", OFFSET(qsv.recovery_point_sei), AV_OPT_TYPE_INT, > > > > > { > > > > > .i64 > > > > > = -1 }, -1, 1, VE }, > > > > > { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), > > > > > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE}, > > > > > + { "pic_timing_sei", "Insert picture timing SEI with > > > > > pic_struct_syntax > > > > > element", OFFSET(qsv.pic_timing_sei), AV_OPT_TYPE_INT, { .i64 = 1 }, > > > > > 0, 1, > > > > > VE > > > > > > It's better to use AV_OPT_TYPE_BOOL if the option is used for on/off or > > > enable/disable. > > > > > > > Thanks for your comment. I'll change it to AV_OPT_TYPE_BOOL, > > > > > I think you need to add description in the doc for the new options if > > > possible. > > > > Currently there isn't a doc for qsv decoder, we'll try to add it later. > > QSV encoder have one section in in doc/encoders.texi already although not all > of > options are included. > > $ grep "QSV encoders" doc/encoders.texi > @section QSV encoders > Thanks for pointing it out. These are global options, not specific options for each QSV encoder, we will add the description about specific options. BRs Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".