From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF2AE40DB9 for ; Tue, 10 May 2022 20:12:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E99668B38A; Tue, 10 May 2022 23:12:32 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F3AE68B233 for ; Tue, 10 May 2022 23:12:25 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 24AKCNWe023804-24AKCNWf023804; Tue, 10 May 2022 23:12:23 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 4E3B5A1407; Tue, 10 May 2022 23:12:23 +0300 (EEST) Date: Tue, 10 May 2022 23:12:22 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: softworkz In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter: use av_fopen_utf8() instead of plain fopen() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Soft Works , ffmpeg-devel@ffmpeg.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 9 May 2022, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > use av_fopen_utf8() instead of plain fopen() > > Unify file access operations by replacing usages of direct calls to > posix fopen() > > v2: Remove changes to fftools for now > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-26%2Fsoftworkz%2Fsubmit_replace_fopen-v2 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-26/softworkz/submit_replace_fopen-v2 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/26 > > Range-diff vs v1: > > 1: 5802c8526c < -: ---------- fftools: use av_fopen_utf8() instead of plain fopen() > 2: 3266640a93 = 1: e47287be64 avfilter: use av_fopen_utf8() instead of plain fopen() > > > libavfilter/af_firequalizer.c | 2 +- > libavfilter/vf_deshake.c | 2 +- > libavfilter/vf_signature.c | 4 ++-- > libavfilter/vf_ssim.c | 2 +- > libavfilter/vf_vmafmotion.c | 2 +- > 5 files changed, 6 insertions(+), 6 deletions(-) LGTM I think. For fully fixing the situation about this function, I believe we're going to need to rename it (as the proper solution won't be a public function), but as there's already some uses, it's probably fine to first take it into use consistently, and then rename all the occurrances later. But we should probably add a copy of file_open.o in libavfilter too (as you noted). This is indeed a preexisting problem, but the issue will become more visible if we use it in more places. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".