From: Tristan Matthews via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Tristan Matthews <httamt@protonmail.com>,
Tristan Matthews <tmatth@videolan.org>
Subject: Re: [FFmpeg-devel] [PATCH] speexdec: fix framesize for ultra-wideband
Date: Tue, 25 Mar 2025 11:39:01 +0000
Message-ID: <_1QNpuVFVjcbkKgaLPrRdpZ4La78MEuqcScjmuV0JZIWnoAXFrjdrNfORxtwsCMhxWMHSwC1ePB_BcsRyMMKwpU060E7ziDaAYvY9PHrHro=@protonmail.com> (raw)
In-Reply-To: <20250313185459.244524-1-tmatth@videolan.org>
On Thursday, March 13th, 2025 at 2:54 PM, Tristan Matthews <tmatth@videolan.org> wrote:
> This matches how the libspeex decoder is calculating frame size (except in clamp form).
>
> Fixes #11495
> ---
> libavcodec/speexdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.c
> index b335e2fbe8..0990338341 100644
> --- a/libavcodec/speexdec.c
> +++ b/libavcodec/speexdec.c
> @@ -1425,7 +1425,7 @@ static int parse_speex_extradata(AVCodecContext *avctx,
> if (s->frame_size < NB_FRAME_SIZE << (s->mode > 1) ||
>
> s->frame_size > INT32_MAX >> (s->mode > 1))
>
> return AVERROR_INVALIDDATA;
> - s->frame_size <<= (s->mode > 1);
>
> + s->frame_size = FFMIN(s->frame_size << (s->mode > 1), NB_FRAME_SIZE << s->mode);
>
> s->vbr = bytestream_get_le32(&buf);
>
> s->frames_per_packet = bytestream_get_le32(&buf);
>
> if (s->frames_per_packet <= 0 ||
>
> --
> 2.45.2
>
Bump.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-25 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 18:54 Tristan Matthews
2025-03-25 11:39 ` Tristan Matthews via ffmpeg-devel [this message]
2025-03-29 21:46 ` Michael Niedermayer
2025-03-30 0:34 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='_1QNpuVFVjcbkKgaLPrRdpZ4La78MEuqcScjmuV0JZIWnoAXFrjdrNfORxtwsCMhxWMHSwC1ePB_BcsRyMMKwpU060E7ziDaAYvY9PHrHro=@protonmail.com' \
--to=ffmpeg-devel@ffmpeg.org \
--cc=httamt@protonmail.com \
--cc=tmatth@videolan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git