From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5350B4AA2D for ; Wed, 7 Aug 2024 00:01:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E03768DAA6; Wed, 7 Aug 2024 03:01:48 +0300 (EEST) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 372D068DA5F for ; Wed, 7 Aug 2024 03:01:40 +0300 (EEST) Received: from 7ba90722f570c2b0104f5b8afe4fa274 ([1.152.190.187]) (authenticated (0 bits)) by mx.sdf.org (8.18.1/8.14.3) with ESMTPSA id 47701XYx002332 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Wed, 7 Aug 2024 00:01:37 GMT Date: Wed, 7 Aug 2024 10:01:27 +1000 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240806221853.959177-1-michael@niedermayer.cc> <20240806221853.959177-4-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: <20240806221853.959177-4-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 4/6] avformat/wtvdec: clear sectors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8802117714438490236==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8802117714438490236== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="u8F5S/CTvCHkDbdI" Content-Disposition: inline --u8F5S/CTvCHkDbdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 07, 2024 at 12:18:51AM +0200, Michael Niedermayer wrote: > The code can leave uninitialized holes in the array. > Fixes: use of uninitialized values > Fixes: 70883/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6698694= 567591936 >=20 > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/t= ree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/wtvdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c > index e153034aa19..1a6c4c33481 100644 > --- a/libavformat/wtvdec.c > +++ b/libavformat/wtvdec.c > @@ -185,7 +185,7 @@ static AVIOContext * wtvfile_open_sector(unsigned fir= st_sector, uint64_t length, > int nb_sectors1 =3D read_ints(s->pb, sectors1, WTV_SECTOR_SIZE /= 4); > int i; > =20 > - wf->sectors =3D av_malloc_array(nb_sectors1, 1 << WTV_SECTOR_BIT= S); > + wf->sectors =3D av_calloc(nb_sectors1, 1 << WTV_SECTOR_BITS); > if (!wf->sectors) { > av_free(wf); > return NULL; agree, please apply -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --u8F5S/CTvCHkDbdI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCZrK5UwAKCRBnYHnFrEDd a8zEAJ9LQuodmsQMNhYjfb56HNiRfHySoACghBULZKVlKU0FSJW5gYTCGT04ZE4= =Ld5y -----END PGP SIGNATURE----- --u8F5S/CTvCHkDbdI-- --===============8802117714438490236== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8802117714438490236==--