From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 192CE4C0EA for ; Mon, 22 Jul 2024 09:36:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 381CC68D68B; Mon, 22 Jul 2024 12:36:41 +0300 (EEST) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2BDAB68D5AF for ; Mon, 22 Jul 2024 12:36:34 +0300 (EEST) Received: from 9e5d27e4b9fe9ef6ae1fbb02e4373de4 ([1.145.230.9]) (authenticated (0 bits)) by mx.sdf.org (8.16.1/8.14.3) with ESMTPSA id 46M9aQNV011252 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Mon, 22 Jul 2024 09:36:30 GMT Date: Mon, 22 Jul 2024 19:36:20 +1000 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5414041674581627642==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5414041674581627642== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="asgY03GbpjpjWKqK" Content-Disposition: inline --asgY03GbpjpjWKqK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 20, 2024 at 10:19:18AM -0400, Aaron wrote: > On Fri, Jul 19, 2024 at 07:54:37PM -0400, Peter Ross wrote: >=20 > > can you post a sample file somewhere >=20 > Of course. Here are some you can try out: >=20 > gm_us.wve: (Stereo - 15 FPS) https://0x0.st/X97A.wve > gm_sp.wve: (Stereo - 15 FPS) https://0x0.st/X97m.wve > sims.wve: (Mono - 30 FPS) https://0x0.st/X97b.wve > simsne.wve: (Mono - 30 FPS) https://0x0.st/X97B.wve >=20 > The first two should decode no problem, and are attached for comparison > purposes. >=20 > Strangely, for all except gm_us.wve, the very last SCDl chunk has a number > of samples that isn't divisible by 28. > So you'll get a single decode error at the end for the rest of them, but > they will still play all the way through and sound good. >=20 > > these whitespace-only changes shouldn't go in the patch. > > "count2 < ( channels..." looks out of place. drop the space after the > parenthesis. > > ditto for these whitespace-only changes above. > > av_log trailing "\n" missing >=20 > Thank you. I have cleaned those up now. >=20 > > i suggest splitting this into two patches, one for mono adpcm ea, anoth= er > for the frame rate fix. >=20 > Done. i will apply these. in future please send patches to the mailing list as separate emails, e.g. using git-mail, described here: https://ffmpeg.org//developer.html#toc-Submitting-patches-1 cheers, -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --asgY03GbpjpjWKqK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCZp4oEAAKCRBnYHnFrEDd azx7AKCptJ/en4r/ah1HN5sUeXDIhasFtACfc6tabmLIHgi2VskskZ+iETQTY9g= =1Rjg -----END PGP SIGNATURE----- --asgY03GbpjpjWKqK-- --===============5414041674581627642== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5414041674581627642==--