From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTP id E42354B420
for <ffmpegdev@gitmailbox.com>; Sat, 6 Jul 2024 12:04:26 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 34A4168DB7D;
Sat, 6 Jul 2024 15:04:23 +0300 (EEST)
Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com
[209.85.208.52])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C33768DA8A
for <ffmpeg-devel@ffmpeg.org>; Sat, 6 Jul 2024 15:04:16 +0300 (EEST)
Received: by mail-ed1-f52.google.com with SMTP id
4fb4d7f45d1cf-58b3fee65d8so2862399a12.3
for <ffmpeg-devel@ffmpeg.org>; Sat, 06 Jul 2024 05:04:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1720267455; x=1720872255; darn=ffmpeg.org;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject
:date:message-id:reply-to;
bh=FsM692qmt3/1LxpISZb7V3EUhMD6uJVsNWVNYtfDA8c=;
b=DbYUEhhna2DjFjF0Uga7A2uP4VJARvXNscVyCOiKWLOE+VqIxZn7UndQB7QVkE4z8C
xL/oNEvxhZljxGmmJOJmaBajWdhfBra70wZ+Z8YJ5ogz1M7K+VuP2/aejOCy1rlV5Ybr
vQtADpUCMKoBJ+Oty3TixsXAIv9ARevFlVZaIMOtwByJjHh+NzmH7erPX9MzmpM89/rL
VuW+1DUq+sae+dTqHOjP7PblCnzzC+Vk8UCGHQIes+mIkEjklLASjbZ5nO60U22Gff50
yGKQd053tzEhDj/ta8ZFSDNCPMKeEbFo5bKZI2BPOAH4+sffuxanwnXlIGEn7mNd5yGG
bJQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1720267455; x=1720872255;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:to:from:date:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=FsM692qmt3/1LxpISZb7V3EUhMD6uJVsNWVNYtfDA8c=;
b=aO3tLsvChtZQ0F4OTBZLvJn5CR4g/rG/0X7VpwdB5YJdkQ6TCZOiss0Ezic/dX/Ra9
Qz/MxpB0U7FvZJgIPGGyNwUr0KGXZ82MADsCzR9XDmsHDgjVCoSvCoZoPiJL8D7F5hsb
3lz8HwLKUFgzJPdh4zHNgYJKKsmuSdDslmwvMRS9jIcWkbZc5wEw5AIGiMkQl6VGXwWW
3v/03QBURCVhHECdYKOsKaQUCLS0PTPRSycrXLPcA+kD9eraq3o2xLb7dSok18zQaaPX
dCb1PHUZ2AXXPj4kk5RDKXt5ZHR/GoB4WQzR8PhoP7tXWlgVF9uCU7jyAfYlZQ/3qJA1
0XuQ==
X-Gm-Message-State: AOJu0YzHz3ibIKQJ3LpkNMvZWALzvfHnG8v6nw2n8pF8ncxGREQQ1EUr
1NkOGzJhtcAWlz+baWU0/9p+Nzw/1kB1VHKovXEeAS9joi8Du6/MBVCCotkoJOA=
X-Google-Smtp-Source: AGHT+IHn2KzJT9doCy2b4O65vB3Uq4cnHGAMqcLUS5Tjub8kt8F89yDvKa7eORRYvKkEPQ4iu37nlQ==
X-Received: by 2002:a05:6402:5ca:b0:58e:4088:ed2 with SMTP id
4fb4d7f45d1cf-58e59853b63mr4817475a12.16.1720267455207;
Sat, 06 Jul 2024 05:04:15 -0700 (PDT)
Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it.
[84.220.189.10]) by smtp.gmail.com with ESMTPSA id
4fb4d7f45d1cf-58eff6d1da5sm2442083a12.0.2024.07.06.05.04.14
for <ffmpeg-devel@ffmpeg.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 06 Jul 2024 05:04:14 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
id 4BA3CBFCE8; Sat, 6 Jul 2024 14:04:13 +0200 (CEST)
Date: Sat, 6 Jul 2024 14:04:13 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <ZokyvcxzZV0fS9v+@mariano>
Mail-Followup-To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
References: <20240622012531.5523-1-jamrial@gmail.com>
<20240622033701.8987-1-jamrial@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20240622033701.8987-1-jamrial@gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH 8/8] fftools/ffprobe: only print
AVStereo3D.view when it's defined
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ZokyvcxzZV0fS9v+@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On date Saturday 2024-06-22 00:37:01 -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> fftools/ffprobe.c | 3 ++-
> tests/ref/fate/matroska-spherical-mono | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index d7ba980ff9..f9124ad5d7 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -2544,7 +2544,8 @@ static void print_pkt_side_data(WriterContext *w,
> const AVStereo3D *stereo = (AVStereo3D *)sd->data;
> print_str("type", av_stereo3d_type_name(stereo->type));
> print_int("inverted", !!(stereo->flags & AV_STEREO3D_FLAG_INVERT));
> - print_str("view", av_stereo3d_view_name(stereo->view));
> + if (stereo->type == AV_STEREO3D_VIEW)
> + print_str("view", av_stereo3d_view_name(stereo->view));
probably we should use print_str_opt to follow the other fields logic
[...]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".