Re: [FFmpeg-devel] [PATCH 8/8] fftools/ffprobe: only print AVStereo3D.view when it's defined

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 8/8] fftools/ffprobe: only print AVStereo3D.view when it's defined
Date: Sat, 6 Jul 2024 14:04:13 +0200
Message-ID: <ZokyvcxzZV0fS9v+@mariano> (raw)
In-Reply-To: <20240622033701.8987-1-jamrial@gmail.com>

On date Saturday 2024-06-22 00:37:01 -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  fftools/ffprobe.c                      | 3 ++-
>  tests/ref/fate/matroska-spherical-mono | 1 -
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index d7ba980ff9..f9124ad5d7 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -2544,7 +2544,8 @@ static void print_pkt_side_data(WriterContext *w,
>              const AVStereo3D *stereo = (AVStereo3D *)sd->data;
>              print_str("type", av_stereo3d_type_name(stereo->type));
>              print_int("inverted", !!(stereo->flags & AV_STEREO3D_FLAG_INVERT));

> -            print_str("view", av_stereo3d_view_name(stereo->view));
> +            if (stereo->type == AV_STEREO3D_VIEW)
> +                print_str("view", av_stereo3d_view_name(stereo->view));

probably we should use print_str_opt to follow the other fields logic

[...]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".