From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6134B4B2F5 for ; Thu, 4 Jul 2024 15:24:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4269668DA79; Thu, 4 Jul 2024 18:24:39 +0300 (EEST) Received: from alt2.a-painless.mh.aa.net.uk (alt2.a-painless.mh.aa.net.uk [81.187.30.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1ACE268DA5B for ; Thu, 4 Jul 2024 18:24:33 +0300 (EEST) Received: from 0.3.a.4.d.8.5.c.f.1.9.b.4.7.0.b.0.5.8.0.9.1.8.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:819:850:b074:b91f:c58d:4a30] helo=andrews-2024-laptop.sayers) by painless-a.thn.aa.net.uk with smtp (Exim 4.96) (envelope-from ) id 1sPOK0-008D1Y-0W for ffmpeg-devel@ffmpeg.org; Thu, 04 Jul 2024 16:24:32 +0100 Date: Thu, 4 Jul 2024 16:24:24 +0100 From: Andrew Sayers To: FFmpeg development discussions and patches Message-ID: References: <20240704143104.1821386-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240704143104.1821386-1-ffmpeg@haasn.xyz> Subject: Re: [FFmpeg-devel] [PATCH v2 1/8] swscale: document SWS_FULL_CHR_H_* flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Jul 04, 2024 at 04:30:57PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Based on my best understanding of what they do, given the source code. > --- > libswscale/swscale.h | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/libswscale/swscale.h b/libswscale/swscale.h > index 9d4612aaf3..e22931cab4 100644 > --- a/libswscale/swscale.h > +++ b/libswscale/swscale.h > @@ -82,11 +82,35 @@ const char *swscale_license(void); > #define SWS_PRINT_INFO 0x1000 > > //the following 3 flags are not completely implemented > -//internal chrominance subsampling info > + > +/** > + * Perform full chroma upsampling when converting to RGB as part of scaling. Nitpick: "as part of scaling" seems redundant - can it be removed? > + * > + * For example, when converting 50x50 yuv420p to 100x100 rgba, setting this flag > + * will scale the chroma plane from 25x25 to 100x100 (4:4:4), and then convert > + * the 100x100 yuv444p image to rgba in the final output step. > + * > + * Without this flag, the chroma plane is instead scaled to 50x100 (4:2:2), > + * with a single chroma sample being re-used for both horizontally adjacent RGBA > + * output pixels. Nitpick: this would be more readable as "for both of the...". Consider the following sentence: Without this flag, the chroma plane is instead scaled to 50x100 (4:2:2), with a single chroma sample being re-used for both horizontally and vertically adjacent RGBA output pixels. Using "both of the" would make it clear what "both" refers to before the reader starts doing branch-prediction in their head. Otherwise, LGTM (by which I mean it's clear, not that I know whether it's correct). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".