From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A385C4B229 for ; Mon, 1 Jul 2024 22:33:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2586D68D862; Tue, 2 Jul 2024 01:33:45 +0300 (EEST) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B5CE668D53E for ; Tue, 2 Jul 2024 01:33:38 +0300 (EEST) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a72585032f1so398475166b.3 for ; Mon, 01 Jul 2024 15:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719873217; x=1720478017; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=67Y1zwg4IyTKeGUctb649wYhWi3XPRr50fx3d0DRd+s=; b=dmve0nLI3f2TDtaRKco6dmfNEL3wfSyASe5vWNm89Jtg6OGuSo/wNo+Lra+4FQaMhn HklE5wz6V11GfYSh6Pyn3S9grL73IVzJjbwy/+QZ+koK30fJoeCMI+g3sZ7WYqVooeAn 5EJYemEglipEp96ET95dP1yLZ0JZ3i6fOhpQR+ePtsUvjGFz5sRgbEs2M9OTG3qt8+I3 LPYQgXjtQx/rHqw+gatIwjRexUA2FAslaS5qimLgbvp+AK0L9c9OoZ+0ybxe8VZqwezH wLbNM8afxKJ9gFAHKWZOYpM8ABRLZ6zvqoudiG6hPP1nTYseIsmO480NOzOo8mQISmig JhSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719873217; x=1720478017; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=67Y1zwg4IyTKeGUctb649wYhWi3XPRr50fx3d0DRd+s=; b=pZBPU5EGL4cYxm/myz/8na2BUlsGlDZtMfaRGCSw8+G+r6qcveg6Dng156fBlyFXlm Bl5KS+rlpyIMY5zzeHvLoh/83PJBuNzjUfCVyh/FPa1Je8bcK4MVXw0a9qOezgj0VKl2 i8max0jFfIreSrTg5CSTns91kPbC9Bwnejhh1R5IcUAu64U66EbJ8AMd2L5mNpGiGS0s ffkbLBu3p7Ve4NbOmAzXuBwd/JMhIpBtG10+V/9Wh2OQh4LI83bNXv/C7EzWoJndY+7u XHjn1pCQjLZmXBfo2RF2CbyW2eFohVjxXvbxd1r2Q7jO4xo6auWMtB3o8ar8Q0DQGdo9 RGsw== X-Gm-Message-State: AOJu0Yx2XXxR6JXI9iqChdQZjyjAIi92948tD3NLgBl3eWtx++5VMsvd StMqSUANJtzBwtZEn6KR4JwrPjGBlBXbI+egFQ0cGuL8UJvlKgp6X9qHSqw6UqI= X-Google-Smtp-Source: AGHT+IHKGNCf6aOgH8whnHo7mpr0YtFqj/FY35MMUm1PRi2jXUatqYpL29sy7z9n9rhzmV5lzfJUug== X-Received: by 2002:a17:907:988:b0:a6f:4fc8:2658 with SMTP id a640c23a62f3a-a751440b8eamr477081966b.14.1719873217059; Mon, 01 Jul 2024 15:33:37 -0700 (PDT) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab065213sm368527866b.132.2024.07.01.15.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 15:33:36 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id A5A28BFCE8; Tue, 2 Jul 2024 00:33:35 +0200 (CEST) Date: Tue, 2 Jul 2024 00:33:35 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Andrew Sayers References: <20240616170934.426015-1-ffmpeg-devel@pileofstuff.org> <20240616170934.426015-2-ffmpeg-devel@pileofstuff.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240616170934.426015-2-ffmpeg-devel@pileofstuff.org> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v3 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andrew Sayers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2024-06-16 18:08:29 +0100, Andrew Sayers wrote: > The old name could be misread as the opposite of "AV_OPT_FLAG_READONLY" - > some things can be set at runtime, others are read-only. Clarify that > this refers to options that can be set after the struct is initialized. > --- > libavutil/opt.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavutil/opt.h b/libavutil/opt.h > index 07e27a9208..e050d126ed 100644 > --- a/libavutil/opt.h > +++ b/libavutil/opt.h > @@ -53,6 +53,9 @@ > * question is allowed to access the field. This allows us to extend the > * semantics of those fields without breaking API compatibility. > * > + * Note: only options with the AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM flag can be > + * modified after the struct is initialized. > + * > * @section avoptions_scope Scope of AVOptions > * > * AVOptions is designed to support any set of multimedia configuration options > @@ -300,7 +303,12 @@ enum AVOptionType{ > #define AV_OPT_FLAG_BSF_PARAM (1 << 8) > > /** > - * A generic parameter which can be set by the user at runtime. > + * A generic parameter which can be set by the user after the struct is initialized. > + */ > +#define AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM (1 << 15) This needs to be dropped at the next bump. 1. define in libavutil/version.h #define FF_API_OPT_FLAG_RUNTIME_PARAM (LIBAVUTIL_VERSION_MAJOR < 60) 2. ifdef to automatically drop this at the next bump #if FF_API_OPT_FLAG_RUNTIME_PARAM /** * A generic parameter which can be set by the user after the struct is initialized. * @deprecated Renamed to AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM for clarity */ #define AV_OPT_FLAG_RUNTIME_PARAM (1 << 15) #endif 3. add a note to doc/APIchanges for the new symbol. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".