From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E8214B20D for ; Mon, 1 Jul 2024 21:19:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1FC0768D68B; Tue, 2 Jul 2024 00:19:02 +0300 (EEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9B19B68D68B for ; Tue, 2 Jul 2024 00:18:55 +0300 (EEST) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57ccd1111aeso1105148a12.0 for ; Mon, 01 Jul 2024 14:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719868735; x=1720473535; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=GE5pPcUF4Sc4oH7OU2iQa1/1yiejgZzmHIRw+VQa1YM=; b=etrND2df6MBjzr0X17sQhbhBgSj+7xK4mQCt2lVwaQN2ecpgUjt1472BXBH23MMJCJ FTwfjERwgyfpIoSwNygsS/3sgGqNr9a5cC1iIrRk8MZaA34LynUc/XKeDzZ4tfuDEL0r YrBxlda2aa/qjJa/bSm+8DJcO+WQfzTf63v8bKS/yKOrKHsvkeM2fXwk/LmbMZ9ciGDM nhwLAsX28Qn+IZnsYr0wncqzzqPz1MziiOikC1eIKN6xuVigkJNiJbNVJflzbZqn21T3 4FlsfqyPDJ3Zo9YnWzEY9PDTTIALUedpFfwHBcq+DKvfo6pyLOk/3Idga+4f2Ufd+E2k fKUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719868735; x=1720473535; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GE5pPcUF4Sc4oH7OU2iQa1/1yiejgZzmHIRw+VQa1YM=; b=WV2qXkD4Wn2mGn26a/7MD6EBEuGt0F+gkwKlxTI+IuxpgUItzLPVA0PUzd4cY3PS6F QHH/tAUTSaKqzMxrTXq0eCA9ovNnsJOdNtxnXH/f0CAANFk/sT8LK7MXH9f/taV/IO8g knScSdi8J+hu6kpCTVQ1PmbSBt6usuqg7WA330dCIJWNCGWQcaQwAbR7x7uG62ijZGwn 3rEJ+Be4B5k8P7R45dc14Nf2QuDmfMZvLSddONvPat3ev1O+mlJEXlbZA7rLTMX1535v 9KkU7Olh9HqLpCcbUTAOHQT3/7Ue5H+Q60CdlWhz4Tu56C0PB+4W5lxkZarW/jHQJkOa PRmg== X-Gm-Message-State: AOJu0Yx1SE/uVvspi321hHYRhXhd7OBorAq3EuJIHhZRBF+L/uvo4s3o oEpTQSqzmmZX6VwgpQUYWH1g46dIJqp1kf8va7JAg5TUrmL1fK24v4XCiSLyql0= X-Google-Smtp-Source: AGHT+IHGSJdpzTl+XJiKEPxc6qEnamMy0TNUFgXLJ6n+TsC/lFF3GTUo7hONXvhxDQ2pGMSutb2jDA== X-Received: by 2002:a17:906:fccc:b0:a72:548a:6f42 with SMTP id a640c23a62f3a-a751445451dmr442256466b.18.1719868734458; Mon, 01 Jul 2024 14:18:54 -0700 (PDT) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf651d5sm367792166b.90.2024.07.01.14.18.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 14:18:54 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 0BF5DBFCE8; Mon, 1 Jul 2024 23:18:52 +0200 (CEST) Date: Mon, 1 Jul 2024 23:18:52 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240622131533.1313814-1-ffmpeg-devel@pileofstuff.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] avfilter/af_afade: fix opt_type for nb_samples/ns X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Saturday 2024-06-22 15:20:52 +0200, Andreas Rheinhardt wrote: > Andrew Sayers: > > The actual value is an int64_t, and is accessed elsewhere as AV_OPT_TYPE_INT64. > > > > Accessing it as INT will likely cause bugs on some 32-bit architectures. > > Whether this works or not will depend upon endianness, not on whether > the architecture is 32-bit (as long as int is 32bits, which is mostly > true for 64-bit architectures). > > > --- > > libavfilter/af_afade.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavfilter/af_afade.c b/libavfilter/af_afade.c > > index 3a45873460..c79271ec92 100644 > > --- a/libavfilter/af_afade.c > > +++ b/libavfilter/af_afade.c > > @@ -452,8 +452,8 @@ const AVFilter ff_af_afade = { > > #if CONFIG_ACROSSFADE_FILTER > > > > static const AVOption acrossfade_options[] = { > > - { "nb_samples", "set number of samples for cross fade duration", OFFSET(nb_samples), AV_OPT_TYPE_INT, {.i64 = 44100}, 1, INT32_MAX/10, FLAGS }, > > - { "ns", "set number of samples for cross fade duration", OFFSET(nb_samples), AV_OPT_TYPE_INT, {.i64 = 44100}, 1, INT32_MAX/10, FLAGS }, > > + { "nb_samples", "set number of samples for cross fade duration", OFFSET(nb_samples), AV_OPT_TYPE_INT64, {.i64 = 44100}, 1, INT32_MAX/10, FLAGS }, > > + { "ns", "set number of samples for cross fade duration", OFFSET(nb_samples), AV_OPT_TYPE_INT64, {.i64 = 44100}, 1, INT32_MAX/10, FLAGS }, > > { "duration", "set cross fade duration", OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0 }, 0, 60000000, FLAGS }, > > { "d", "set cross fade duration", OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0 }, 0, 60000000, FLAGS }, > > { "overlap", "overlap 1st stream end with 2nd stream start", OFFSET(overlap), AV_OPT_TYPE_BOOL, {.i64 = 1 }, 0, 1, FLAGS }, > > LGTM. How did you find this? LGTM as well, will apply after dropping the second sentence in the commit log. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".