From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTP id 5F0064AB4F
for <ffmpegdev@gitmailbox.com>; Wed, 12 Jun 2024 19:52:55 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 49B0868D9DA;
Wed, 12 Jun 2024 22:52:54 +0300 (EEST)
Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com
[209.85.208.52])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA94868D941
for <ffmpeg-devel@ffmpeg.org>; Wed, 12 Jun 2024 22:52:47 +0300 (EEST)
Received: by mail-ed1-f52.google.com with SMTP id
4fb4d7f45d1cf-57a1fe63a96so150233a12.0
for <ffmpeg-devel@ffmpeg.org>; Wed, 12 Jun 2024 12:52:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1718221966; x=1718826766; darn=ffmpeg.org;
h=user-agent:in-reply-to:content-transfer-encoding
:content-disposition:mime-version:references:mail-followup-to
:message-id:subject:to:from:date:from:to:cc:subject:date:message-id
:reply-to; bh=QiQz1dm/izblV1VOWumjvNtpAG2yGcpBckOnLePF8as=;
b=Ygd7dQ+4Vo6/6+gooh2dTSnz1qQxkX1JUaT5LW4UNKt8PLDOTi7XFxdp5ifisQRUd1
0CbUmfKME5cnKUYevW1gO8NOvUOuvKEprCoWWN+2vHeUR7Xkwp0wpkPtxg7Ax2GRvY39
aIAC7a+mdZFz/ES+lF5tRaItzNjikspfsr765/uYDq3Q6NkYGRirq0QKaB2JAJ6TFR48
M9uRUEoU1ytfC73HmdcSekCk6DTaAiPE5PzttLGDajVXb0q5ArfgBmuUfmeC6qNa8XHd
OJ4NzxsjYJ1ZLWurYYhRgD+iTDxORM/w6U6bE+p8cN9ACRMV/e10B4lz3NsaM+juskeo
UJnQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1718221966; x=1718826766;
h=user-agent:in-reply-to:content-transfer-encoding
:content-disposition:mime-version:references:mail-followup-to
:message-id:subject:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=QiQz1dm/izblV1VOWumjvNtpAG2yGcpBckOnLePF8as=;
b=m7J/7szMTu0zNaf5XVqDNzDVWjDRnwRXVd08HukYZvKzpp4//mHh0XxP/MKvHLgTmY
4rjSi4+w04vTbYOzaCUK31p/KG062dUi9OcHqhFTgwP17K2X/4j0K67mmiADsPG8bH3w
OVtiMfzQhnfO693XOmFh2ihIe7glNE60lz1d2+TUUSUOY8cTUGkEhEN2oDNfHth4E4Ma
FNBWpqgj5XQVDegmirwh83YOKSfvFcMBP7lHUXSJF51mOLCncQM7zWO98yXPcuA4aoMS
l6qFmUfCl9e32EOMEVUsqMcDjnwCiS0iycuJMfw39U51n1lWC3uC6r+EJNUwLZx2DNPN
TkPw==
X-Gm-Message-State: AOJu0YyyRYpOar5axbjEx+FmcPRLaG1BIwT8R6vvFbsmaLY0M/9PNVdB
26Tnlacnpg9RC4sUQfhU/XX9ODKRYY6fsOdSVEJ0xOS3yTuwpwgjUCt5DQ==
X-Google-Smtp-Source: AGHT+IEy7CrgOb7CYoBmBuBoXEyDgW13uoLjj9GtZWK0356k0avEmTVVHCiZav/1bUZ3qbIRIRaE3Q==
X-Received: by 2002:a50:96c4:0:b0:57c:aac7:105c with SMTP id
4fb4d7f45d1cf-57caac7109bmr1903770a12.0.1718221966217;
Wed, 12 Jun 2024 12:52:46 -0700 (PDT)
Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it.
[84.220.189.10]) by smtp.gmail.com with ESMTPSA id
4fb4d7f45d1cf-57c828dd0dfsm5792242a12.72.2024.06.12.12.52.45
for <ffmpeg-devel@ffmpeg.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 12 Jun 2024 12:52:45 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
id 8C7C6BFCE8; Wed, 12 Jun 2024 21:52:43 +0200 (CEST)
Date: Wed, 12 Jun 2024 21:52:43 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <Zmn8i9PWFNVcOEeD@mariano>
Mail-Followup-To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
References: <20240606115100.44233-1-hiccupzhu@gmail.com>
<tencent_DF41B3F2337835C2E917AEA9E5487306A805@qq.com>
<CACW1+SZ99CuwjL+nNkqOyESa5gUZA2Y6TQCrxvoMNpq6in2c1A@mail.gmail.com>
<tencent_BC9A4B40D69AA39F5BABFC4EEC70452D3008@qq.com>
<CACW1+SZhSa==X144WtzT2FSzzd-sAEcEA8uGxraZ7w6FAKfxOA@mail.gmail.com>
<2E76C656-4093-4901-B314-C61BAE6CDA15@remlab.net>
<20240607095351.GP2821752@pb2>
<05E9959A-9743-4C57-AAEB-186EACE9F161@remlab.net>
<CACW1+SZGD=yE-d3u4ToWDCHZLU8S3+nc_pguBvLDUWWYb3wAkQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="xyK7bRC8V1xWZowo"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACW1+SZGD=yE-d3u4ToWDCHZLU8S3+nc_pguBvLDUWWYb3wAkQ@mail.gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/Zmn8i9PWFNVcOEeD@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--xyK7bRC8V1xWZowo
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
On date Tuesday 2024-06-11 21:13:48 +0800, Shiqi Zhu wrote:
> On Fri, 7 Jun 2024 at 19:55, Rémi Denis-Courmont <remi@remlab.net> wrote:
> > Le 7 juin 2024 12:53:51 GMT+03:00, Michael Niedermayer <michael@niedermayer.cc> a écrit :
> > >We can require anything from an API that we are able to change and extend
> > >Of course we can decide not to allow such requirment even if optional
> > >but we surely _could_ add such a feature if we choose to do so
> >
> > Sure. You can also require infinite memory or an oracle be provided. That's just not going to happen though. And having libraries depend on the main thread is a well-documented malpractice.
> >
> > I don't think we should add maintenance burden with code that can't be used safely.
>
> Thank you all for your attention to this patch; I greatly appreciate it.
>
> I'd like to provide a brief recap of the issue we've been discussing,
> with the following points:
>
> 1. Addition of sink type in the filter:
> This enhancement is primarily based on the existing avfilter mechanism
> and serves as a strengthening module. Using SDL as the sink doesn't
> seem to be a good fit, as I'll attempt to rectify in the following
> patch.
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240611130310.1131755-1-hiccupzhu@gmail.com/
>
> 2. Utilizing SDL as an implementation for the sink:
> Before submitting the patch, I hadn't considered many aspects. During
> the intense discussions, I retested the patch on different operating
> systems, with the following results, hoping it may assist those
> interested in this issue:
>
> Command: ./ffmpeg -lavfi
> "testsrc2=size=300x200:rate=25:duration=500,format=yuv420p,sdlvsink"
> -f null /dev/null
In addition to this, I wonder if adding a vsink for each different
output device is the correct way.
We have a movie source which can be used to read from
libavformat/libavdevice, probablhy we should have a movie sink to be
used to write to libavformat/libavdevice, meaning that a single sink
would enable access to all the supported libavformat/libavdevice
outputs.
I started having a look in that direction a looot of time ago. This
was never finalized because I was not sure about ways to pass options
to encoders and muxers, and about dealing with a variable number of
outputs, I'm attaching this very old proof-of-concept patch for
reference.
This approach would be possibly much more complex, but should provide
a single bridge in place of having a different sink for every output
device or muxer.
--xyK7bRC8V1xWZowo
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0001-lavfi-add-moviesink-and-amoviesink-sinks.patch"
>From dc88e3f19ad0e481e0adc5e192ad3e2b4b249f55 Mon Sep 17 00:00:00 2001
From: Stefano Sabatini <stefasab@gmail.com>
Date: Wed, 11 Apr 2012 15:10:14 +0200
Subject: [PATCH] lavfi: add moviesink and amoviesink sinks
---
configure | 2 +
libavfilter/Makefile | 4 +
libavfilter/allfilters.c | 2 +
libavfilter/sink_moviesink.c | 365 +++++++++++++++++++++++++++++++++++
4 files changed, 373 insertions(+)
create mode 100644 libavfilter/sink_moviesink.c
diff --git a/configure b/configure
index 81c7cc18a2..5e08fbbf6c 100755
--- a/configure
+++ b/configure
@@ -1674,6 +1674,7 @@ udp_protocol_deps="network"
# filters
aconvert_filter_deps="swresample"
amovie_filter_deps="avcodec avformat"
+amoviesink_filter_deps="avcodec avformat"
aresample_filter_deps="swresample"
ass_filter_deps="libass"
asyncts_filter_deps="avresample"
@@ -1690,6 +1691,7 @@ frei0r_src_filter_deps="frei0r dlopen"
frei0r_src_filter_extralibs='$ldl'
hqdn3d_filter_deps="gpl"
movie_filter_deps="avcodec avformat"
+moviesink_filter_deps="avcodec avformat"
mp_filter_deps="gpl avcodec swscale postproc"
mptestsrc_filter_deps="gpl"
negate_filter_deps="lut_filter"
diff --git a/libavfilter/Makefile b/libavfilter/Makefile
index 29345fc15e..a2bd404304 100644
--- a/libavfilter/Makefile
+++ b/libavfilter/Makefile
@@ -7,8 +7,10 @@ FFLIBS-$(CONFIG_RESAMPLE_FILTER) += avresample
FFLIBS-$(CONFIG_ACONVERT_FILTER) += swresample
FFLIBS-$(CONFIG_AMOVIE_FILTER) += avformat avcodec
+FFLIBS-$(CONFIG_AMOVIESINK_FILTER) += avformat avcodec
FFLIBS-$(CONFIG_ARESAMPLE_FILTER) += swresample
FFLIBS-$(CONFIG_MOVIE_FILTER) += avformat avcodec
+FFLIBS-$(CONFIG_MOVIESINK_FILTER) += avformat avcodec
FFLIBS-$(CONFIG_PAN_FILTER) += swresample
FFLIBS-$(CONFIG_REMOVELOGO_FILTER) += avformat avcodec
FFLIBS-$(CONFIG_MP_FILTER) += avcodec postproc
@@ -65,6 +67,7 @@ OBJS-$(CONFIG_AMOVIE_FILTER) += src_movie.o
OBJS-$(CONFIG_ANULLSRC_FILTER) += asrc_anullsrc.o
OBJS-$(CONFIG_ABUFFERSINK_FILTER) += sink_buffer.o
+OBJS-$(CONFIG_AMOVIESINK_FILTER) += sink_moviesink.o
OBJS-$(CONFIG_ANULLSINK_FILTER) += asink_anullsink.o
OBJS-$(CONFIG_ASS_FILTER) += vf_ass.o
@@ -133,6 +136,7 @@ OBJS-$(CONFIG_RGBTESTSRC_FILTER) += vsrc_testsrc.o
OBJS-$(CONFIG_TESTSRC_FILTER) += vsrc_testsrc.o
OBJS-$(CONFIG_BUFFERSINK_FILTER) += sink_buffer.o
+OBJS-$(CONFIG_MOVIESINK_FILTER) += sink_moviesink.o
OBJS-$(CONFIG_NULLSINK_FILTER) += vsink_nullsink.o
OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/mp_image.o
diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c
index b9d44f2fdf..a7cc9ad3de 100644
--- a/libavfilter/allfilters.c
+++ b/libavfilter/allfilters.c
@@ -56,6 +56,7 @@ void avfilter_register_all(void)
REGISTER_FILTER (ABUFFERSINK, abuffersink, asink);
REGISTER_FILTER (ANULLSINK, anullsink, asink);
+ REGISTER_FILTER (AMOVIESINK, amoviesink, asink);
REGISTER_FILTER (ASS, ass, vf);
REGISTER_FILTER (BBOX, bbox, vf);
@@ -123,6 +124,7 @@ void avfilter_register_all(void)
REGISTER_FILTER (TESTSRC, testsrc, vsrc);
REGISTER_FILTER (BUFFERSINK, buffersink, vsink);
+ REGISTER_FILTER (MOVIESINK, moviesink, vsink);
REGISTER_FILTER (NULLSINK, nullsink, vsink);
/* those filters are part of public or internal API => registered
diff --git a/libavfilter/sink_moviesink.c b/libavfilter/sink_moviesink.c
new file mode 100644
index 0000000000..27c8cca078
--- /dev/null
+++ b/libavfilter/sink_moviesink.c
@@ -0,0 +1,365 @@
+/*
+ * Copyright (c) 2012 Stefano Sabatini
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+/**
+ * @file
+ * Movie video sink filter
+ */
+
+#include "libavutil/avstring.h"
+#include "libavutil/opt.h"
+#include "libavformat/avformat.h"
+#include "avcodec.h"
+#include "avfilter.h"
+
+typedef struct {
+ const AVClass *class;
+ char *codec_name;
+ char *file_name;
+ char *format_name;
+
+ AVOutputFormat *oformat;
+ AVFormatContext *oformat_ctx;
+ AVCodec *codec;
+
+ int w, h;
+ AVFilterBufferRef *bufref;
+} MovieSinkContext;
+
+#define OFFSET(x) offsetof(MovieSinkContext, x)
+
+static const AVOption moviesink_options[] = {
+{"codec_name", "set codec name", OFFSET(codec_name), AV_OPT_TYPE_STRING, {.str = 0}, CHAR_MIN, CHAR_MAX },
+{"c", "set codec name" , OFFSET(codec_name), AV_OPT_TYPE_STRING, {.str = 0}, CHAR_MIN, CHAR_MAX },
+{"format_name", "set format name", OFFSET(format_name), AV_OPT_TYPE_STRING, {.str = 0}, CHAR_MIN, CHAR_MAX },
+{"f", "set format name", OFFSET(format_name), AV_OPT_TYPE_STRING, {.str = 0}, CHAR_MIN, CHAR_MAX },
+{NULL},
+};
+
+static const char *moviesink_get_name(void *ctx)
+{
+ return "moviesink";
+}
+
+static const AVClass moviesink_class = {
+ "MovieSinkContext",
+ moviesink_get_name,
+ moviesink_options
+};
+
+static av_cold int moviesink_common_init(AVFilterContext *ctx, const char *args, void *opaque,
+ enum AVMediaType type)
+{
+ MovieSinkContext *movie = ctx->priv;
+ AVOutputFormat *oformat = NULL;
+ AVStream *st;
+ enum CodecID codec_id;
+ int ret;
+
+ movie->class = &moviesink_class;
+ av_opt_set_defaults(movie);
+
+ if (args)
+ movie->file_name = av_get_token(&args, ":");
+ if (!movie->file_name || !*movie->file_name) {
+ av_log(ctx, AV_LOG_ERROR, "No filename provided!\n");
+ return AVERROR(EINVAL);
+ }
+
+ if (*args++ == ':' && (ret = av_set_options_string(movie, args, "=", ":")) < 0) {
+ av_log(ctx, AV_LOG_ERROR, "Error parsing options string: '%s'\n", args);
+ return ret;
+ }
+
+ av_register_all();
+ movie->oformat_ctx = avformat_alloc_context();
+ av_strlcpy(movie->oformat_ctx->filename, movie->file_name,
+ sizeof(movie->oformat_ctx->filename));
+
+ if (!(oformat = av_guess_format(movie->format_name, movie->file_name, NULL))) {
+ av_log(ctx, AV_LOG_ERROR,
+ "Unable to find a suitable output format for '%s'\n", movie->file_name);
+ return AVERROR(EINVAL);
+ }
+ movie->oformat_ctx->oformat = movie->oformat = oformat;
+
+ /* add a stream */
+ st = avformat_new_stream(movie->oformat_ctx, NULL);
+ if (!st) {
+ av_log(ctx, AV_LOG_ERROR, "Could not allocate stream\n");
+ return AVERROR(ENOMEM);
+ }
+
+ avcodec_get_context_defaults3(st->codec, NULL);
+
+ if (movie->codec_name) {
+ movie->codec = avcodec_find_decoder_by_name(movie->codec_name);
+ } else {
+ codec_id = av_guess_codec(movie->oformat_ctx->oformat, NULL,
+ movie->oformat_ctx->filename, NULL, type);
+ movie->codec = avcodec_find_encoder(codec_id);
+ }
+
+ if (!movie->codec) {
+ av_log(ctx, AV_LOG_ERROR, "Failed to find any codec\n");
+ return AVERROR(EINVAL);
+ }
+
+ return 0;
+}
+
+static av_cold void moviesink_common_uninit(AVFilterContext *ctx)
+{
+ MovieSinkContext *movie = ctx->priv;
+
+ av_freep(&movie->codec_name);
+ av_freep(&movie->file_name);
+ av_freep(&movie->format_name);
+
+ if (movie->oformat_ctx)
+ avformat_close_input(&movie->oformat_ctx);
+
+ avfilter_unref_bufferp(&movie->bufref);
+}
+
+static int make_filter_formats(AVFilterFormats **ffmts, const int *fmts)
+{
+ int i, len;
+ const int *p = fmts;
+ for (len = 0; *p != -1; p++, len++)
+ ;
+
+ if (!(*ffmts = av_mallocz(sizeof(AVFilterFormats))))
+ return AVERROR(ENOMEM);
+ if ((!((*ffmts)->formats = av_malloc(sizeof((*ffmts)->formats) * len)))) {
+ av_free(*ffmts);
+ return AVERROR(ENOMEM);
+ }
+
+ (*ffmts)->format_count = len;
+ p = fmts;
+ for (i = 0; i < len; i++, p++)
+ (*ffmts)->formats[i] = *p;
+
+ return 0;
+}
+
+static int moviesink_common_config_props(AVFilterLink *inlink, enum AVMediaType type)
+{
+ AVFilterContext *ctx = inlink->dst;
+ MovieSinkContext *movie = ctx->priv;
+ AVCodecContext *encctx;
+ AVStream *st = movie->oformat_ctx->streams[0];
+ int ret;
+
+ switch (type) {
+ case AVMEDIA_TYPE_VIDEO:
+ st->codec->pix_fmt = inlink->format;
+ st->codec->width = inlink->w;
+ st->codec->height = inlink->h;
+ st->codec->time_base = inlink->time_base;
+ break;
+ case AVMEDIA_TYPE_AUDIO:
+ st->codec->sample_fmt = inlink->format;
+ st->codec->sample_rate = inlink->sample_rate;
+ st->codec->time_base = inlink->time_base;
+ st->codec->channel_layout = inlink->channel_layout;
+ st->codec->channels =
+ av_get_channel_layout_nb_channels(inlink->channel_layout);
+ break;
+ }
+ encctx = avcodec_alloc_context3(movie->codec);
+ if (!encctx) {
+ av_log(ctx, AV_LOG_ERROR, "Error while allocating the codec context\n");
+ return AVERROR(ENOMEM);
+ }
+
+ if ((ret = avcodec_open2(st->codec, movie->codec, NULL)) < 0) {
+ av_log(ctx, AV_LOG_ERROR, "Error while opening the codec\n");
+ return ret;
+ }
+
+ av_dump_format(movie->oformat_ctx, 0, movie->file_name, 1);
+
+ /* open the output file, if needed */
+ if (!(movie->oformat->flags & AVFMT_NOFILE)) {
+ if ((ret = avio_open(&movie->oformat_ctx->pb,
+ movie->file_name, AVIO_FLAG_WRITE)) < 0) {
+ av_log(ctx, AV_LOG_ERROR, "Could not open '%s'\n", movie->file_name);
+ return ret;
+ }
+ }
+
+ if ((ret = avformat_write_header(movie->oformat_ctx, NULL)) < 0) {
+ av_log(ctx, AV_LOG_ERROR, "Could not write header for '%s'\n", movie->file_name);
+ return ret;
+ }
+
+ return 0;
+}
+
+#if CONFIG_MOVIESINK_FILTER
+
+static av_cold int moviesink_init(AVFilterContext *ctx, const char *args, void *opaque)
+{
+ return moviesink_common_init(ctx, args, opaque, AVMEDIA_TYPE_VIDEO);
+}
+
+static int moviesink_query_formats(AVFilterContext *ctx)
+{
+ MovieSinkContext *movie = ctx->priv;
+ AVFilterFormats *ffmts;
+ int ret;
+
+ if ((ret = make_filter_formats(&ffmts, movie->codec->pix_fmts)))
+ return ret;
+
+ avfilter_set_common_pixel_formats(ctx, ffmts);
+ return 0;
+}
+
+static int moviesink_config_props(AVFilterLink *inlink)
+{
+ return moviesink_common_config_props(inlink, AVMEDIA_TYPE_VIDEO);
+}
+
+static void moviesink_start_frame(AVFilterLink *inlink, AVFilterBufferRef *bufref) { }
+
+static void moviesink_end_frame(AVFilterLink *inlink)
+{
+ MovieSinkContext *movie = inlink->dst->priv;
+ AVFilterBufferRef *picref = inlink->cur_buf;
+ AVFrame frame;
+ int ret, got_packet;
+ AVPacket packet;
+
+ ret = avfilter_fill_frame_from_video_buffer_ref(&frame, picref);
+ if (ret < 0) {
+ av_log(inlink->dst, AV_LOG_ERROR, "Cannot convert picref to frame\n");
+ return;
+ }
+
+ av_init_packet(&packet);
+ packet.data = NULL;
+ packet.size = 0;
+ got_packet = 0;
+ ret = avcodec_encode_video2(movie->oformat_ctx->streams[0]->codec,
+ &packet, &frame, &got_packet);
+ if (ret < 0) {
+ av_log(inlink->dst, AV_LOG_ERROR, "Video encoding failed\n");
+ return;
+ }
+ packet.stream_index = 0;
+
+ av_interleaved_write_frame(movie->oformat_ctx, &packet);
+}
+
+AVFilter avfilter_vsink_moviesink = {
+ .name = "moviesink",
+ .description = NULL_IF_CONFIG_SMALL("Output the video to a media file."),
+ .priv_size = sizeof(MovieSinkContext),
+ .query_formats = moviesink_query_formats,
+ .init = moviesink_init,
+ .uninit = moviesink_common_uninit,
+
+ .inputs = (const AVFilterPad[]) {
+ { .name = "default",
+ .type = AVMEDIA_TYPE_VIDEO,
+ .start_frame = moviesink_start_frame,
+ .end_frame = moviesink_end_frame,
+ .config_props = moviesink_config_props, },
+ { .name = NULL }
+ },
+ .outputs = (const AVFilterPad[]) {
+ { .name = NULL }
+ },
+};
+
+#endif /* CONFIG_MOVIESINK_FILTER */
+
+#ifdef CONFIG_AMOVIESINK_FILTER
+
+static av_cold int amoviesink_init(AVFilterContext *ctx, const char *args, void *opaque)
+{
+ return moviesink_common_init(ctx, args, opaque, AVMEDIA_TYPE_AUDIO);
+}
+
+static int amoviesink_query_formats(AVFilterContext *ctx)
+{
+ MovieSinkContext *movie = ctx->priv;
+ AVFilterFormats *ffmts;
+ int ret;
+
+ if ((ret = make_filter_formats(&ffmts, movie->codec->sample_fmts)))
+ return ret;
+
+ avfilter_set_common_sample_formats(ctx, ffmts);
+ return 0;
+}
+
+static int amoviesink_config_props(AVFilterLink *inlink)
+{
+ return moviesink_common_config_props(inlink, AVMEDIA_TYPE_AUDIO);
+}
+
+static void amoviesink_filter_samples(AVFilterLink *inlink, AVFilterBufferRef *insamples)
+{
+ MovieSinkContext *movie = inlink->dst->priv;
+ AVFrame frame;
+ AVPacket packet;
+ int ret, got_packet;
+
+ av_init_packet(&packet);
+ packet.data = NULL;
+ packet.size = 0;
+ got_packet = 0;
+ ret = avcodec_encode_audio2(movie->oformat_ctx->streams[0]->codec,
+ &packet, &frame, &got_packet);
+ if (ret < 0) {
+ av_log(inlink->dst, AV_LOG_ERROR, "Audio encoding failed\n");
+ return;
+ }
+ packet.stream_index = 0;
+
+ av_interleaved_write_frame(movie->oformat_ctx, &packet);
+}
+
+AVFilter avfilter_asink_amoviesink = {
+ .name = "amoviesink",
+ .description = NULL_IF_CONFIG_SMALL("Output audio to a movie file."),
+ .priv_size = sizeof(MovieSinkContext),
+ .init = amoviesink_init,
+ .uninit = moviesink_common_uninit,
+ .query_formats = amoviesink_query_formats,
+
+ .inputs = (const AVFilterPad[]) {
+ { .name = "default",
+ .type = AVMEDIA_TYPE_AUDIO,
+ .config_props = amoviesink_config_props,
+ .filter_samples = amoviesink_filter_samples,
+ },
+ { .name = NULL }
+ },
+ .outputs = (const AVFilterPad[]) {
+ { .name = NULL }
+ },
+};
+
+#endif /* CONFIG_AMOVIESINK_FILTER */
--
2.34.1
--xyK7bRC8V1xWZowo
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--xyK7bRC8V1xWZowo--