From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DF1294A2A0 for ; Sun, 2 Jun 2024 10:04:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A7CD968D61E; Sun, 2 Jun 2024 13:04:13 +0300 (EEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2E4B368D5D3 for ; Sun, 2 Jun 2024 13:04:07 +0300 (EEST) X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from metallschleimette ([91.62.13.127]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mv2xU-1sVNRe227M-00udbw for ; Sun, 02 Jun 2024 12:04:06 +0200 Date: Sun, 2 Jun 2024 12:04:05 +0200 To: FFmpeg development discussions and patches Message-ID: References: <20240529145955.32189-1-remi@remlab.net> <2666279.WWoxFUQ57l@basile.remlab.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2666279.WWoxFUQ57l@basile.remlab.net> X-Provags-ID: V03:K1:ko0298N0O1WlAi+RHZ0fLyjJHPqZ/dNoVEGigcD9Fafz2bqe7O5 X6pxos2Pu2Hhl39bbNwkWVHdfo/GOf6DFPzG4OVEnyrhFBFeGyk+lW2xvqnMf8T+O/1BKzz Gv03sCwUMT0zBRasZVBnNyed3DI9PGRCGqfBo6axOATzTxRjOoXjb3rrlPkorny2Itw2Bqc tP0wP7u+fRDTDmIM2CBSg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:gFIYmWtDw+U=;troNK3Rv6v5qj9q/74t/Yj+8qVJ RbbSpX+vhMBKcMRQpO2p4yzMAt6kHdlmRaQE3vFbo6i7MH5bTIelTojRiDpOPIELYy6wgaNek SFVC8iKog6wAJO49g5YiCgEIlNk3OBMWho0+QQRTNd/8LWZM3Dqm3DZmWDjU/opg2rWZrPcFu jAZO6ivfHsWAxIY5sZomE7TvKSSU7SjFH8Abkf+pvsJPPB74RE0RxtIStrA2t3bXQGGgh5PTN 96nq0tQbclD5LuLrvz5CKFUKVlaOeQ31TKOe+MIR0s3vLKu1nBQ8DQTxzPy7l2HwgC68fGJIy Vy/JzBmZdqKM7meeOT3FZGkeIyMIBtHrD/3EeaTTZvEO8dN5G9JRVEfr3j+wm2wTp7SgYezqF pO3NCYreVaSj3AVWBGrIfpP9Lv3J6sv5oPvWZwa7EOPiPuTRQibWr+vI65QWLvtG6ST7I0100 vGTfMEkGMFsHuuGB2hbKe33I7UVXQySM7yU7+WNfn8cLMtSLxb1+xaez1eJOHssJgSkmuMRak NExuu9nnFXtX03ZTdCgx2HTA7GgLEcYbE54soXSwjLE0NaIv9ekVWKpVfdLEJjV04niHkYHtj DeNTKN9FjUXpmkTCHqyftbnuep93j+SkkYkxsFSGGDUzT7b/DKCqpH3QJ0vhx5PBEcnHAa/IG 3FF80BAvcIs0rjK7IFCp/+/+SRF4KCWMMmwxlI1+qV8k17DSganxqihfJCUj4JUGEY/FnmRhN RKNDCmbKXh4pV7N6ry8ti5Et/cMINkY8udT+bc9u/JiD5aIFb3JFSXOdQp0hmfo+Oz+hBxne2 OvnW8QaZPQceG0Nxek4xejWptzHXto2yyC2mNctDyFiwg= Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Strasser via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Alexander Strasser Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2024-05-29 18:51 +0300, R=E9mi Denis-Courmont wrote: > Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a = =E9crit > : > > > +static double ff_scalarproduct_double_c(const double *v1, > > > Don't use an ff_ prefix for a static function. > > I can see over 300 such identifiers in the code base (many but not all in= line), > and I don't see why that would be a problem. I agree that it's not a problem regarding on the functional side, OTOH regarding coding conventions we try to consistently follow it's misleading as the ff_ prefix indicates a bigger scope of sharing. Maybe I'm missing something, but it looks to me that more than half of those over 300 instances are correct (the inline ones in the headers). I think Andreas remark is correct and it would be better to not use ff_ prefix wrongly when adding new code. Best regards, Alexander [...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".