From: Alexander Strasser via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Alexander Strasser <eclipse7@gmx.net>
Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product
Date: Sun, 2 Jun 2024 12:04:05 +0200
Message-ID: <ZlxDlRRf_Ve1NLnK@metallschleimette> (raw)
In-Reply-To: <2666279.WWoxFUQ57l@basile.remlab.net>
On 2024-05-29 18:51 +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a écrit
> :
> > > +static double ff_scalarproduct_double_c(const double *v1,
>
> > Don't use an ff_ prefix for a static function.
>
> I can see over 300 such identifiers in the code base (many but not all inline),
> and I don't see why that would be a problem.
I agree that it's not a problem regarding on the functional side,
OTOH regarding coding conventions we try to consistently follow it's
misleading as the ff_ prefix indicates a bigger scope of sharing.
Maybe I'm missing something, but it looks to me that more than half of
those over 300 instances are correct (the inline ones in the headers).
I think Andreas remark is correct and it would be better to not use ff_
prefix wrongly when adding new code.
Best regards,
Alexander
[...]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-02 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 14:59 Rémi Denis-Courmont
2024-05-29 14:59 ` [FFmpeg-devel] [PATCH 2/4] lavf: get rid of bespoke double scalar products Rémi Denis-Courmont
2024-05-29 15:46 ` Andreas Rheinhardt
2024-05-29 15:52 ` Rémi Denis-Courmont
2024-05-29 14:59 ` [FFmpeg-devel] [PATCH 3/4] checkasm/float_dsp: add double-precision scalar product Rémi Denis-Courmont
2024-05-29 14:59 ` [FFmpeg-devel] [PATCH 4/4] lavc/float_dsp: R-V V scalarproduct_double Rémi Denis-Courmont
2024-05-29 15:42 ` Andreas Rheinhardt
2024-05-29 15:44 ` [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product Andreas Rheinhardt
2024-05-29 15:51 ` Rémi Denis-Courmont
2024-05-29 16:04 ` James Almer
2024-06-02 10:04 ` Alexander Strasser via ffmpeg-devel [this message]
2024-06-02 10:30 ` Rémi Denis-Courmont
2024-06-02 10:34 ` Rémi Denis-Courmont
2024-06-02 10:43 ` Alexander Strasser via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlxDlRRf_Ve1NLnK@metallschleimette \
--to=ffmpeg-devel@ffmpeg.org \
--cc=eclipse7@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git