From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 53B8A4AF72 for ; Sat, 25 May 2024 09:57:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0DA0B68D4FB; Sat, 25 May 2024 12:57:37 +0300 (EEST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0F0A868D189 for ; Sat, 25 May 2024 12:57:31 +0300 (EEST) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-57822392a0dso6643472a12.0 for ; Sat, 25 May 2024 02:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716631049; x=1717235849; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ORp7unKzVQyBjB/56kYT4odlulKNNqb9V9I31/73CHs=; b=IHDOiw1Ba7ekcSKQBM7pF0sWWOyIYUgwSdxTZF6KNxMz5ZgCw3OtQIP+1OEXrojDQE VoYJX+zoGZS3WoUM6K3lP8rekfJT8p/JAivBp8jB8p/4aYDdwO4xjYjLwIewNirCGsm7 55Cr8hCGIS/PxEqSm2EBJlghWt/73qIiryu0YtcCGrQbu0BcadzF8DnuINDx1//thbB8 3CXZpVzHNYv9/x216+wP7R8Yb1pafK8jcgkbF5YU16GIjHtCh5k/o+fAjkDuC0fPk746 c3JOG9/Y9dAmKQuarwy9kt/safiyfoQ4f30y7z2NYaa4B3wYomLz5m/t5C4QL3wJPFDe dCiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716631049; x=1717235849; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ORp7unKzVQyBjB/56kYT4odlulKNNqb9V9I31/73CHs=; b=KgtBcVM2QWt/uhi/Mj8DgxrFzPGDjHatBWFDH32+HwtLgXSPsiW5+UyE7A2eCSqnxI adAlsvhNdASzDl53sUrgjTpcTh+kOG5B0U42rrGZ/09cjLyTE+BnvoXReFjBY2FHLzE4 +7RiPbhokbSE0YaV8zLkfHYtJieRybPi8BM345L51vTPNxjPk6NxAoa1WTA1WiOFHenG Ymj2QNmkXfjtNzv5Sktgx6/5/CYi65KNYqWlcAlwWu2W3kWncfSoscbos+KGqn4lIMou dmXtgpOEg+PXkWO5W7UdPjOW/kmduGDg4llCsQdGeWS53P5rGXY3CjHTrqNzMzQBOGId cMPQ== X-Gm-Message-State: AOJu0Yxt0/0haMBG1boGsEEpxwWHF6UZcwaaeImavvAyYm8eVQaAnL7M EdhccGykfpPcEH+UXol9eYBsQmN9X+IybPTMT1YaRD/gFKSQXPkzHds+SA== X-Google-Smtp-Source: AGHT+IE78U73YrjWasCen6Ps6CrNUcnU71V0or6U3ePMFr/jRzCXynSsJRQ+ydwg9YMk/6JAdjARMA== X-Received: by 2002:a17:906:5a83:b0:a5a:1579:9033 with SMTP id a640c23a62f3a-a62641aa499mr264196566b.1.1716631049189; Sat, 25 May 2024 02:57:29 -0700 (PDT) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc8b874sm234691566b.163.2024.05.25.02.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 02:57:28 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id CB1BFBFCE8; Sat, 25 May 2024 11:57:27 +0200 (CEST) Date: Sat, 25 May 2024 11:57:27 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Andrew Sayers References: <20240523200116.740461-1-ffmpeg-devel@pileofstuff.org> <20240523200116.740461-3-ffmpeg-devel@pileofstuff.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240523200116.740461-3-ffmpeg-devel@pileofstuff.org> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v5 2/4] lavu: Clarify relationship between AVClass, AVOption and context X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andrew Sayers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Thursday 2024-05-23 21:00:41 +0100, Andrew Sayers wrote: > --- > libavutil/log.h | 16 +++++++++++++--- > libavutil/opt.h | 17 ++++++++++++++--- > 2 files changed, 27 insertions(+), 6 deletions(-) > > diff --git a/libavutil/log.h b/libavutil/log.h > index ab7ceabe22..d599ab506e 100644 > --- a/libavutil/log.h > +++ b/libavutil/log.h > @@ -59,9 +59,19 @@ typedef enum { > struct AVOptionRanges; > > /** > - * Describe the class of an AVClass context structure. That is an > - * arbitrary struct of which the first field is a pointer to an > - * AVClass struct (e.g. AVCodecContext, AVFormatContext etc.). > + * Generic Logging and introspection facilities Looks mostly good to me but now I wonder if we are really confusing introspection with AVOptions (AVOptions adopt introspection but it's mostly about AVOptions themselves). So maybe we should replace "introspection" with something more concrete, such as: Generic logging and options facilities > + * > + * Logging and introspection functions expect to be passed structs > + * whose first member is a pointer-to-@ref AVClass. > + * > + * Structs that only use the logging facilities are often referred to as > + * "AVClass context structures", while those that use introspection facilities > + * are called "AVOptions-enabled structs". > + * > + * @see > + * * @ref lavu_log > + * * @ref avoptions > + * * @ref Context > */ > typedef struct AVClass { > /** > diff --git a/libavutil/opt.h b/libavutil/opt.h > index 07e27a9208..b14c120e36 100644 > --- a/libavutil/opt.h > +++ b/libavutil/opt.h > @@ -39,9 +39,16 @@ > * @defgroup avoptions AVOptions > * @ingroup lavu_data > * @{ > - * AVOptions provide a generic system to declare options on arbitrary structs > - * ("objects"). An option can have a help text, a type and a range of possible > - * values. Options may then be enumerated, read and written to. > + * > + * Generic introspection facilities for AVClass context structures ditto, more concrete with: Generic options facilities ... [...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".