From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 601C44ADFF for ; Tue, 21 May 2024 16:32:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 16F4D68D2DC; Tue, 21 May 2024 19:32:18 +0300 (EEST) Received: from alt2.a-painless.mh.aa.net.uk (alt2.a-painless.mh.aa.net.uk [81.187.30.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 948E968C6F3 for ; Tue, 21 May 2024 19:32:11 +0300 (EEST) Received: from e.f.4.9.7.5.8.8.9.d.b.2.a.5.1.1.0.5.8.0.9.1.8.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:819:850:115a:2bd9:8857:94fe] helo=andrews-2024-laptop.sayers) by painless-a.thn.aa.net.uk with smtp (Exim 4.96) (envelope-from ) id 1s9SPK-00FV79-2Z for ffmpeg-devel@ffmpeg.org; Tue, 21 May 2024 17:32:11 +0100 Date: Tue, 21 May 2024 17:32:03 +0100 From: Andrew Sayers To: FFmpeg development discussions and patches Message-ID: References: <20240520145222.291-1-tong1.wu@intel.com> <20240520145222.291-11-tong1.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240520145222.291-11-tong1.wu@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v9 11/13] avutil/hwcontext_d3d12va: add Flags for resource creation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: (Only reviewing documentation, not code) On Mon, May 20, 2024 at 10:52:20PM +0800, tong1.wu-at-intel.com@ffmpeg.org wrote: > From: Tong Wu > > Flags field is added to support diffferent resource creation. > > Signed-off-by: Tong Wu > --- > doc/APIchanges | 3 +++ > libavutil/hwcontext_d3d12va.c | 2 +- > libavutil/hwcontext_d3d12va.h | 8 ++++++++ > libavutil/version.h | 2 +- > 4 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 269fd36559..808ba02f2d 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2024-03-07 > > API changes, most recent first: > > +2024-01-xx - xxxxxxxxxx - lavu 59.20.100 - hwcontext_d3d12va.h > + Add AVD3D12VAFramesContext.flags > + > 2024-05-xx - xxxxxxxxxx - lavu 59.19.100 - hwcontext_qsv.h > Add AVQSVFramesContext.info > > diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c > index cfc016315d..6507cf69c1 100644 > --- a/libavutil/hwcontext_d3d12va.c > +++ b/libavutil/hwcontext_d3d12va.c > @@ -247,7 +247,7 @@ static AVBufferRef *d3d12va_pool_alloc(void *opaque, size_t size) > .Format = hwctx->format, > .SampleDesc = {.Count = 1, .Quality = 0 }, > .Layout = D3D12_TEXTURE_LAYOUT_UNKNOWN, > - .Flags = D3D12_RESOURCE_FLAG_NONE, > + .Flags = hwctx->flags, > }; > > frame = av_mallocz(sizeof(AVD3D12VAFrame)); > diff --git a/libavutil/hwcontext_d3d12va.h b/libavutil/hwcontext_d3d12va.h > index ff06e6f2ef..608dbac97f 100644 > --- a/libavutil/hwcontext_d3d12va.h > +++ b/libavutil/hwcontext_d3d12va.h > @@ -129,6 +129,14 @@ typedef struct AVD3D12VAFramesContext { > * If unset, will be automatically set. > */ > DXGI_FORMAT format; > + > + /** > + * This field is used to specify options for working with resources. > + * If unset, this will be D3D12_RESOURCE_FLAG_NONE. > + * > + * @see: https://learn.microsoft.com/en-us/windows/win32/api/d3d12/ne-d3d12-d3d12_resource_flags. > + */ > + D3D12_RESOURCE_FLAGS flags; Some nitpicks: * "This field is used to specify" is redundant, you can save the reader a few seconds by starting the sentence with just "Options..." * "@see" starts a paragraph, so the rendered documentation will look better without the ":" * the full stop after the URL makes it harder to copy/paste the text - remove the full stop or use a [markdown link](...) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".