From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 093F4496A1 for ; Sat, 18 May 2024 08:33:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 67DFB68D16C; Sat, 18 May 2024 11:33:37 +0300 (EEST) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5601B68D01E for ; Sat, 18 May 2024 11:33:29 +0300 (EEST) Received: from fa7e0802a724d30006d4dce511c573ba ([1.136.195.126]) (authenticated (0 bits)) by mx.sdf.org (8.16.1/8.14.3) with ESMTPSA id 44I8XJZA025544 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Sat, 18 May 2024 08:33:23 GMT Date: Sat, 18 May 2024 18:33:12 +1000 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240518035743.766552-1-michael@niedermayer.cc> <20240518035743.766552-9-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: <20240518035743.766552-9-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 9/9] avcodec/vp3: Replace check by assert X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0353890592715907803==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0353890592715907803== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C5LMMbfyYI2hHhYd" Content-Disposition: inline --C5LMMbfyYI2hHhYd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 18, 2024 at 05:57:43AM +0200, Michael Niedermayer wrote: > Fixes: CID1452425 Logically dead code >=20 > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp3.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c > index 09527607767..d03a1c9dbc1 100644 > --- a/libavcodec/vp3.c > +++ b/libavcodec/vp3.c > @@ -2001,8 +2001,7 @@ static int vp4_mc_loop_filter(Vp3DecodeContext *s, = int plane, int motion_x, int > x_offset =3D (-(x + 2) & 7) + 2; > y_offset =3D (-(y + 2) & 7) + 2; > =20 > - if (x_offset > 8 + x_subpel && y_offset > 8 + y_subpel) > - return 0; > + av_assert1(!(x_offset > 8 + x_subpel && y_offset > 8 + y_subpel)= ); > =20 ok -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --C5LMMbfyYI2hHhYd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCZkhnwQAKCRBnYHnFrEDd azSPAJ0SI6lR0br6RqEyxorb1ZUVKZAkDwCeMzgLz/Bww04y5VLE0CURvEVMIPc= =Vfcg -----END PGP SIGNATURE----- --C5LMMbfyYI2hHhYd-- --===============0353890592715907803== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0353890592715907803==--