From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 177A2487AD
	for <ffmpegdev@gitmailbox.com>; Fri, 17 May 2024 09:43:10 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7BCA268D362;
	Fri, 17 May 2024 12:43:07 +0300 (EEST)
Received: from alt2.a-painless.mh.aa.net.uk (alt2.a-painless.mh.aa.net.uk
 [81.187.30.51])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F313B68AA84
 for <ffmpeg-devel@ffmpeg.org>; Fri, 17 May 2024 12:43:00 +0300 (EEST)
Received: from
 b.0.3.5.0.a.d.d.3.b.4.c.d.b.8.c.0.5.8.0.9.1.8.0.0.b.8.0.1.0.0.2.ip6.arpa
 ([2001:8b0:819:850:c8bd:c4b3:dda0:530b] helo=andrews-2024-laptop.sayers)
 by painless-a.thn.aa.net.uk with smtp (Exim 4.96)
 (envelope-from <ffmpeg-devel@pileofstuff.org>) id 1s7u79-006koT-1P
 for ffmpeg-devel@ffmpeg.org; Fri, 17 May 2024 10:42:59 +0100
Date: Fri, 17 May 2024 10:42:58 +0100
From: Andrew Sayers <ffmpeg-devel@pileofstuff.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <ZkcmohUlfXwf3wzc@andrews-2024-laptop.sayers>
References: <DU0PR03MB956764A45A25B9AAA59C0FBDECEE2@DU0PR03MB9567.eurprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <DU0PR03MB956764A45A25B9AAA59C0FBDECEE2@DU0PR03MB9567.eurprd03.prod.outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH 1/6] lavf/tls_mbedtls: handle more error
 codes for human-readable message
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ZkcmohUlfXwf3wzc@andrews-2024-laptop.sayers/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Fri, May 17, 2024 at 10:34:26AM +0200, Sfan5 wrote:
> Signed-off-by: sfan5 <sfan5@live.de>
> ---
>  libavformat/tls_mbedtls.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c
> index 1a182e735e..fd6ba0b1f5 100644
> --- a/libavformat/tls_mbedtls.c
> +++ b/libavformat/tls_mbedtls.c
> @@ -138,6 +138,9 @@ static void handle_handshake_error(URLContext *h, int
> ret)
>      case MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE:
>          av_log(h, AV_LOG_ERROR, "TLS handshake failed.\n");
>          break;
> +    case MBEDTLS_ERR_SSL_BAD_PROTOCOL_VERSION:
> +        av_log(h, AV_LOG_ERROR, "TLS protocol version mismatches.\n");

"... mismatch" or "... does not match" would be more readable than "mismatches".

The word "matches" can mean either "does match" or "plural of match".
It's technically valid to use "mismatches" to mean "does not match",
but in practice the word is only ever used to mean "plural of mismatch".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".