From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 23EA1490C2 for ; Thu, 2 May 2024 10:03:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3072868D6A2; Thu, 2 May 2024 13:03:38 +0300 (EEST) Received: from alt2.a-painless.mh.aa.net.uk (alt2.a-painless.mh.aa.net.uk [81.187.30.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1E6D168D6A2 for ; Thu, 2 May 2024 13:03:31 +0300 (EEST) Received: from 3.4.3.5.7.1.0.f.c.9.9.9.9.3.2.a.0.5.8.0.9.1.8.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:819:850:a239:999c:f017:5343] helo=andrews-2024-laptop.sayers) by painless-a.thn.aa.net.uk with smtp (Exim 4.96) (envelope-from ) id 1s2THm-00DNmN-1t for ffmpeg-devel@ffmpeg.org; Thu, 02 May 2024 11:03:30 +0100 Date: Thu, 2 May 2024 11:03:23 +0100 From: Andrew Sayers To: FFmpeg development discussions and patches Message-ID: References: <20240422155836.385333-1-ffmpeg-devel@pileofstuff.org> <20240422155836.385333-2-ffmpeg-devel@pileofstuff.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v3 1/3] doc: Explain what "context" means X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Apr 29, 2024 at 10:10:35AM +0100, Andrew Sayers wrote: > > I've also gone through the code looking for edge cases we haven't covered. > Here are some questions trying to prompt an "oh yeah I forgot to mention > that"-type answer. Anything where the answer is more like "that should > probably be rewritten to be clearer", let me know and I'll avoid confusing > newbies with it. > > av_ambient_viewing_environment_create_side_data() takes an AVFrame as its > first argument, and returns a new AVAmbientViewingEnvironment. What is the > context object for that function - AVFrame or AVAmbientViewingEnvironment? > > av_register_bitstream_filter() (deprecated 4.0, removed 5.0) took an > `AVBitStreamFilter *` as its first argument, but I don't think you'd say > the argument provided "context" for the function. So would I be right in > saying `AVBitStreamFilter *` is not a context, despite looking like one? > > av_buffersink_*() all take a `const AVFilterContext *` argument. > What does the difference between av_buffersink prefix and AVFilter type mean? > > av_channel_description_bprint() takes a `struct AVBPrint *` as its first > argument, then `enum AVChannel`. Is the context AVBPrint, AVChannel, > or both? Does it make sense for a function to have two contexts? > > Related to the previous question, does `av_cmp_q()` count as a function > with two contexts? Or no contexts? > > Finally, a general question - functions of the form "avfoo" seem like they > are more consistent than "av_foo". Does the underscore mean anything? One extra question I hadn't thought to ask before - when, if at all, would an ordinary user be expected to access the contents of AVClass directly? Or AVOption for that matter? For example, it's not clear to me how people are supposed to use AVClass.category - is this an important use case we haven't covered? Either way, happy to propose an AVClass patch to make it clearer. It's my turn to be off for a few days, so will pick up any responses next week. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".