From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F2D114A161 for ; Mon, 22 Apr 2024 13:55:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AAFB668D2A4; Mon, 22 Apr 2024 16:55:13 +0300 (EEST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9250A68C8CD for ; Mon, 22 Apr 2024 16:55:06 +0300 (EEST) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a5557e3ebcaso733144166b.1 for ; Mon, 22 Apr 2024 06:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713794105; x=1714398905; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=xa8HhrlFA6xuCVrnPjUNSkyW1y5pv/Ez+N+ZbvF2D20=; b=ZYmZtb8lddS3nEtv/CbIZ/pXrV3t5VUVRGw3BHsBEybTpm2X/uFupmdfyE/fmVMjRL LnFwH1Fgx0SqCJWtPCjQlq5tEtGAGXokwcJSfxvMfNnAxkjeiiHojtc/sK1vvf+nQXGW YPFEnofHo95MDXHCqzq1PzP8+0dfA7ukj8LM4vlhKKNtV/X5BN/vt/Xc2/ZYcIWPOZUT c/vNEPZjpakd7/bvuwoLDis/+Rjh4EZkcOIBeod4jh5+iWGmr915Qz/IvE3fjTcCWyoj ySiyQRNrYSBpCtOLxwPO3P66aQuQfibjWZjwhZwBfNJXBVoqq9f3J+1pcEf/vUoTYAec T7fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713794105; x=1714398905; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xa8HhrlFA6xuCVrnPjUNSkyW1y5pv/Ez+N+ZbvF2D20=; b=lxQZQCkgDb1zrVPGR2iZyWtB8wf3zZaBt9h7DuTOiDlTEs/XDlZ2rAVtvdrFTjry/a 6vwACerRlZ2vn/xYGM+eAHFaPdoBrKF2YIGwlrWFVCh0rmYdLxApFCof637xHB2iREmd kyKZ4C3iyJ0eHXja//CeFgbpU7v5gfImlpYuox6aXceO6l41UCb+dlVQjOIz0mGUFzZf g8mT/uKziLM9YcHP4L1yP0Dhl6Zge499FkRaUXaOObASR85vJN71HI3GA8hccZ0LkWj7 s2CnClDb7Y+muz9qF27IseJdfz2+ZErWJsspQ+H6ZAHI5LSOdY6tnvYQ6yHnZqbh9TxE ZJyQ== X-Gm-Message-State: AOJu0YziGb6R3E/6y1BrZHm+cyH/+sIQDScqN0YcJHmk4s2ZY1+F7MNh d8/FPJqtFVfsCI4HEBclzWE/m/5rAJQss73cgMKOJgpkTOlSabiaeDZWsg== X-Google-Smtp-Source: AGHT+IGrK/i/JAhfAHovl64bxPBM6qZd0nIAvX7wCmJs23GlzwlMlQH7aPsWjn3GQFHZLeKWvXQUhg== X-Received: by 2002:a17:906:66d7:b0:a51:8672:66e4 with SMTP id k23-20020a17090666d700b00a51867266e4mr10504537ejp.22.1713794104508; Mon, 22 Apr 2024 06:55:04 -0700 (PDT) Received: from mariano (host-87-17-49-61.retail.telecomitalia.it. [87.17.49.61]) by smtp.gmail.com with ESMTPSA id f24-20020a170906c09800b00a522f867697sm5752513ejz.132.2024.04.22.06.55.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 06:55:04 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id E3C51BFCE8; Mon, 22 Apr 2024 15:55:02 +0200 (CEST) Date: Mon, 22 Apr 2024 15:55:02 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240420114835.35645-1-stefasab@gmail.com> <20240420114835.35645-3-stefasab@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Saturday 2024-04-20 18:47:58 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: [...] > >> 1. This does not match mkvextract behaviour. mkvextract does not force a > >> 1ms timebase. > > > > From your past comment: > >> The accuracy of the timestamps output by mkvextract is determined by the > >> TimestampScale of the file in question; it is most often 1ms when the > >> file has video. > > > > "most often" != "force" [...] > (I am not certain wrt MKVToolNix handling of fractional millisecond; old > versions of mkvextract may really have simply rounded/truncated to > milliseconds.) It doesn't, at least with version: $ mkvextract --version mkvextract v65.0.0 ('Too Much') 64-bit So far, mkvextract seems to output DTSs as in the original implementation - therefore no need to change implementation, but for the "timecode" => "timestamp" issue. $ ./ffprobe -hide_banner slow.mkv -of csv=nk=1:p=0 -select_streams v:0 -show_entries packet=pts | head -n 20 [...] 0 1201 1235 1268 1368 1301 1335 1401 1435 1535 1468 1502 1602 1568 1735 1668 1635 1702 1768 1869 $ ./ffprobe -hide_banner slow.mkv -of csv=nk=1:p=0 -select_streams v:0 -show_entries packet=dts | head -n 20 N/A N/A 0 1201 1235 1268 1301 1335 1368 1401 1435 1468 1502 1535 1568 1602 1635 1668 1702 1735 $ mkvextract slow.mkv timestamps_v2 0:slow.mkv.out Progress: 100% $ head -n 21 slow.mkv.out # timestamp format v2 0 1201 1235 1268 1301 1335 1368 1401 1435 1468 1502 1535 1568 1602 1635 1668 1702 1735 1768 1802 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".