From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 04AB3488A8 for ; Sun, 21 Apr 2024 07:47:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9065968D197; Sun, 21 Apr 2024 10:47:41 +0300 (EEST) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 95F3868CC70 for ; Sun, 21 Apr 2024 10:47:35 +0300 (EEST) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-34a4772d5easo2444557f8f.0 for ; Sun, 21 Apr 2024 00:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713685655; x=1714290455; darn=ffmpeg.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ypiTlHhUZBuWb1f1E4bDaBnMh8fp4PizXRhDIcR4p8c=; b=GJcpd0Sms/jplQQ9zjHUXMlsRrmhL+kgENnr9hzAaD0Z+97Md0XPTbsIQXVS2OAyPj 9VN1yDBi3vTt8H6YLxsNZWQtWkg4oQRmvRvF6oN5L4vYojrgz5h4z+RMpvzv3luLC3WM PgtzpbnVc3rV5WC2tiUQjJmqjEhC3tuXGxwKg6UyxwgekTr/EdnhBLWq1KD5X1haYc61 T5kWuk33QAuL/Tj3364lnDtnptHmsCEPVTyE5eIu5FdZDJFLBwyJVrikWh48xmENdoZu GyeI403obmbMhA9sb1sBwoxIieEfLi+Mi/mV+21GXf1zXFFIs8UdmTQ3Y/27mcVKcPrz ZswQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713685655; x=1714290455; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ypiTlHhUZBuWb1f1E4bDaBnMh8fp4PizXRhDIcR4p8c=; b=TDd6IoRhd4l+KwVvwigQn0FzPnrwzgYJgHiJkBvZtFJUXhxXZDq3evDSoPR9VcZ/5I kx+HpaWPyzteTziB2f73FX7t3l7sPSfw1w2/uakx8tDGyQyUghCsS0RffsWSqlRDmZ+X 1hFzSMiuKz0Fh8fFG0P+082K4q2gyEQGJyB5ptmwwObUo/N/h9rSkl6XxUJ561jLXXj6 Ejsy5eSPSsfOILoP8pBxsZwpPjGoLEB3jf29ysTzSkODWQUvAr2NcRvGAgkO28loKZNv p/Hl53eaomTjT546ErNT7xAAOEyMgBjPBRtVxbMsVs8sOdPiXqbGj8FEP7A051J0GZ2E aJEQ== X-Gm-Message-State: AOJu0Yz13nocShBMnNChKq3tBx3eQcDXMq1hvwjkRBAcXCWZqVh7k4oo Pyzxp13tJi5knfP223BuC2iCs6vKCNwtj55jEVxUyu4jCwB1IMrbAJ2uuQ== X-Google-Smtp-Source: AGHT+IEgMr4TVjzzVkgzWOA9/NAX1/95hicUt0Q7r21RooMvoRHlPvDmycBBTPfaEg32CznMh2lZ2A== X-Received: by 2002:a05:600c:46cb:b0:418:a786:3760 with SMTP id q11-20020a05600c46cb00b00418a7863760mr4431478wmo.15.1713685654618; Sun, 21 Apr 2024 00:47:34 -0700 (PDT) Received: from kusa (2a01cb040b6872000000000000000afa.ipv6.abo.wanadoo.fr. [2a01:cb04:b68:7200::afa]) by smtp.gmail.com with ESMTPSA id d5-20020a05600c34c500b0041a33b8f328sm993174wmq.12.2024.04.21.00.47.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 00:47:34 -0700 (PDT) Date: Sun, 21 Apr 2024 09:47:32 +0200 From: Matthieu Bouron To: ffmpeg-devel@ffmpeg.org Message-ID: References: <20240404200725.155067-1-matthieu.bouron@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/jni: fix mixed declaration and code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Apr 15, 2024 at 07:02:36PM +0200, Matthieu Bouron wrote: > On Thu, Apr 04, 2024 at 10:07:25PM +0200, Matthieu Bouron wrote: > > --- > > libavcodec/jni.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/jni.c b/libavcodec/jni.c > > index 1193c608c3..fcb4837413 100644 > > --- a/libavcodec/jni.c > > +++ b/libavcodec/jni.c > > @@ -84,11 +84,13 @@ void *av_jni_get_java_vm(void *log_ctx) > > int av_jni_set_android_app_ctx(void *app_ctx, void *log_ctx) > > { > > #if CONFIG_JNI > > + jobjectRefType type; > > + > > JNIEnv *env = ff_jni_get_env(log_ctx); > > if (!env) > > return AVERROR(EINVAL); > > > > - jobjectRefType type = (*env)->GetObjectRefType(env, app_ctx); > > + type = (*env)->GetObjectRefType(env, app_ctx); > > if (type != JNIGlobalRefType) { > > av_log(log_ctx, AV_LOG_ERROR, "Application context must be passed as a global reference"); > > return AVERROR(EINVAL); > > -- > > 2.44.0 > > > > I will apply the patch in a few days if there is no objection. Patch applied. -- Matthieu B. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".