From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B1B9C4A106 for ; Sat, 20 Apr 2024 16:56:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0704B68D206; Sat, 20 Apr 2024 19:56:56 +0300 (EEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B64668CA55 for ; Sat, 20 Apr 2024 19:56:49 +0300 (EEST) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-41a0979b9e2so2698565e9.3 for ; Sat, 20 Apr 2024 09:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713632207; x=1714237007; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=sqB3lX5sgEeCKbIxcVdk6CvakdwPP2QQCzS6ZGUrJCs=; b=N+kEVzPH11i97mmwfeYhzQo8VAuQUl6uyyoGhpPBcYsdff4ueVdnUERKPu+ZvqWLgX IyqekU+W699S8oeW3bVcTyrgF/pUxHUpfTXCaB4EpJxnqWa25V2Qcz4AH151xbrG7ddM 8fLussloALy7/rLs1UFrvFpzxB6NH2Wl3fHr1NhMVvOJtVHs6K2zoTyiQ1jxfmD1r2ip XE8Fq2YT1zFaRKkSpcUO7qThu7j39MCTWf1CSFuPJjAlx4Ut3e0mRqeMYd7pSPDXOfpi TtbffesWCP3LRrWH/DJJulvY0qmlOemMuWuJEklW+tUCPzcfOjP1+HIjbHDR36dl1KWg W8cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713632207; x=1714237007; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sqB3lX5sgEeCKbIxcVdk6CvakdwPP2QQCzS6ZGUrJCs=; b=vYZwzJhMgs8FJdBnp2lPZv3bx2VGOirMRcXKQZYH+iS2ftQ2LrBiyuYfltlOTdx7SF ElGWFisppeb07bKYnlsuXC/W4XwEJPy56xYZAyLN7TA1FDGqfZryE3WIn4BwKRBjp+E0 D02ZfTXyHBL89s4t3JEcXjYvS2qymr2HVZcIL5oxjTrrkBwg2LBtd3eIa7q8qajdHA2C YIBbzV0ZfF4EdHwpgLIuiOBoPCSlxhnIuDe5TaPhzM4hEQLKLzJmmgLKHBFB0He3S9YG 3JyO3sQ4SdCZhrWL6TUxtbZY6imLEvLFYkr785kMiSYwoVzpxhNyXjKgJ8gqIEbfQThW LZww== X-Gm-Message-State: AOJu0Yy5DqPjtLLvtiGKLfhu7Cwyj7KrwqXZl3Z4t+etdXm+LDCsxC+6 gaBmi998Py42XgBYM5jeLYOWZT84sF4Exo0w7T/jbO1J1/SHNAQGc4eKfg== X-Google-Smtp-Source: AGHT+IHTNjRKJoSHQR95eyBN/zcL0inW67r1WCwJcnw/CkAA/OyLR5HvYN6rN7PMPeEVlh3oCKACYA== X-Received: by 2002:a5d:6c67:0:b0:33e:ca28:bb59 with SMTP id r7-20020a5d6c67000000b0033eca28bb59mr6153180wrz.57.1713632207375; Sat, 20 Apr 2024 09:56:47 -0700 (PDT) Received: from mariano (host-87-17-49-61.retail.telecomitalia.it. [87.17.49.61]) by smtp.gmail.com with ESMTPSA id l9-20020a17090615c900b00a555be38aaasm3581042ejd.164.2024.04.20.09.56.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Apr 2024 09:56:47 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id DB13DBFCE8; Sat, 20 Apr 2024 18:56:45 +0200 (CEST) Date: Sat, 20 Apr 2024 18:56:45 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240420114835.35645-1-stefasab@gmail.com> <20240420114835.35645-3-stefasab@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Saturday 2024-04-20 18:47:58 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > On date Saturday 2024-04-20 15:18:39 +0200, Andreas Rheinhardt wrote: > >> Stefano Sabatini: > >>> Harmonize internal implementation with the mkvextract behavior: > >>> - print PTS in place of DTS values > >>> - ignore NOPTS values > >>> - sort PTS values > >>> --- > >>> libavformat/mkvtimestamp_v2.c | 69 +++++++++++++++++++++++++++++++++-- > >>> 1 file changed, 65 insertions(+), 4 deletions(-) [...] > >> 3. I still don't think that this muxer should exist at all. > > > > I tend to agree. But: > > > > We don't really know why this weird muxer was added, today we have > > better tools for that (we could use ffprobe, or even a bitstream > > filter similar to showinfo to get the same result), but if it was > > added probably there was a reason. So my plan is to make the format a > > bit more useful (DTS => PTS+sort), and possibly deprecate it and point > > to better available tools and drop this in two major releses. > > > > I don't think the point of the format was to really make the behavior > > exactly equal to mkvextract, the thing with TimeScale is probably not > > very important, at least for the original author that was not really > > an issue, he was probably only looking for some way to dump timestamps > > and took free inspiration from mkvtoolnix. > > > > This thing has been added in 1c5670dbb204369477ee1b5d967f9e8b4f4a33b8. I > can't find any discussion in the mailing list archives for this, but the > file description was "extract pts as timecode v2, as defined by > mkvtoolnix" at the time. Furthermore, its author is the one who started > the Matroska muxer. So I think its aim was really to mimic mkvextract. > (I am not certain wrt MKVToolNix handling of fractional millisecond; old > versions of mkvextract may really have simply rounded/truncated to > milliseconds.) > > > If this is true, we might point that this format is not exactly > > equivalent to timestamp_v2 in the doc. > > Which makes this thing even more pointless. I'm not against removing this muxer, but it is something we should do? Removing a working component (even if suboptimal) even without deprecation. Probably if there is agreement about this, especially given that there are better alternatives at this time. If not, I can fix the missing bits so we have a better implementation, but we might want to deprecated and drop later. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".