From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTP id C5C64496EF
for <ffmpegdev@gitmailbox.com>; Thu, 18 Apr 2024 10:04:38 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 45AED68D43C;
Thu, 18 Apr 2024 13:04:36 +0300 (EEST)
Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com
[209.85.208.54])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8000F68D3F1
for <ffmpeg-devel@ffmpeg.org>; Thu, 18 Apr 2024 13:04:29 +0300 (EEST)
Received: by mail-ed1-f54.google.com with SMTP id
4fb4d7f45d1cf-56e37503115so600507a12.1
for <ffmpeg-devel@ffmpeg.org>; Thu, 18 Apr 2024 03:04:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1713434657; x=1714039457; darn=ffmpeg.org;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject
:date:message-id:reply-to;
bh=3ylrLlEYgcvljpGGLMPqBID+WElRZAm4IL1GR3liJII=;
b=lMJQ4X4qF0wo/BvdyP6AvSfn9JSheI0JBHMle+7WCyb5kajK3cjxhSrsN4x9zncXfn
hzNwWkz8qwE48JbS/R2vMa7Z7GHQ1VfMKv9ATtVtHo7D4Q3QW7MukhZsSD34yWFXXz8d
/jt1sVnEcBUOPnO1yYLDrGfs6sMVmvhrTc2Ne+5HoWA4chIA71aFqM//nuSOiNHU2VN+
LwolsOdCVt0kbypxSObjkBnLRj7YyZVGgmf9bpqbn39F8pWqrzRecL6DoYG65jzZuDjP
tAZnGYk1EXGvX9n9+pJ9NPDncBEy/tEa0en2JBYXvX+A7haaokdyJ0d/2hNqEptpxHOY
5BmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1713434657; x=1714039457;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:to:from:date:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=3ylrLlEYgcvljpGGLMPqBID+WElRZAm4IL1GR3liJII=;
b=BEYPUO0krIXlu/VW0Mr18eNYreNJOb6yjEATTp7p13/n4PdDNOLEnoh1XVTbrS/Cyv
vB7fFeBNmUMO83+1V6swkEi68IuwQFnmmde7T4y+MoECQxPSGNTGCicOn1X9H7uERdAE
8s45QpTQPihRxQ1/P173/8zry4J6hYhVutJtV5ErDbNy9/k96HR1PKp292aH6NiL0eHu
98B/BSO39gbW902xfO7y87hIFmrKX15Rw74XEvcmO7NdZ8wkt7mOsOkiNy+ZyvBgdrET
ysHgD2wowjALBs3jQMu2f9AGsgERcT9zQp1hKy+ePTGyp91sPMWQkrpr9Z/Vx3QbDM3F
hVqQ==
X-Gm-Message-State: AOJu0YwHYZx6s8AyjfZPkDMpLNmM76Cm3Om1Mq6YlA1o1lBCdxByXR1b
mO9ZOHnfRlgpBcchp+I11IFMRJ/TKRswrfgjeufd1fQvgfGtiWr7lA7QdA==
X-Google-Smtp-Source: AGHT+IHy1bExmSdCljYJj1YqHLaHxhcyjC6KuZwhLUBS37vGmJVSjpdQj9+30lqUGU7Q11iE9xfdGA==
X-Received: by 2002:a17:906:5394:b0:a52:67ce:c64d with SMTP id
g20-20020a170906539400b00a5267cec64dmr1369616ejo.66.1713434656908;
Thu, 18 Apr 2024 03:04:16 -0700 (PDT)
Received: from mariano (host-87-17-49-61.retail.telecomitalia.it.
[87.17.49.61]) by smtp.gmail.com with ESMTPSA id
jj17-20020a170907985100b00a522a073a64sm667447ejc.187.2024.04.18.03.04.16
for <ffmpeg-devel@ffmpeg.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 18 Apr 2024 03:04:16 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
id 0E042BFCE8; Thu, 18 Apr 2024 12:04:15 +0200 (CEST)
Date: Thu, 18 Apr 2024 12:04:15 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <ZiDwH9GN+Fo3TQOe@mariano>
Mail-Followup-To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
References: <20240416082949.63344-1-stefasab@gmail.com>
<20240416082949.63344-5-stefasab@gmail.com>
<AS8P250MB07449445F47544DC806615E98F082@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
<Zh658Tie4K5XhQVS@mariano>
<AS8P250MB0744CF9D444E1991F256D8808F082@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <AS8P250MB0744CF9D444E1991F256D8808F082@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH 4/6] doc/muxers: add mkvtimestamp_v2
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ZiDwH9GN+Fo3TQOe@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On date Tuesday 2024-04-16 20:09:19 +0200, Andreas Rheinhardt wrote:
> Stefano Sabatini:
> > On date Tuesday 2024-04-16 12:50:19 +0200, Andreas Rheinhardt wrote:
> >> Stefano Sabatini:
> >>> ---
> >>> doc/muxers.texi | 8 ++++++++
> >>> 1 file changed, 8 insertions(+)
> >>>
> >>> diff --git a/doc/muxers.texi b/doc/muxers.texi
> >>> index f94513527d..490d5557bf 100644
> >>> --- a/doc/muxers.texi
> >>> +++ b/doc/muxers.texi
> >>> @@ -2933,6 +2933,14 @@ MicroDVD subtitle format muxer.
> >>>
> >>> This muxer accepts a single @samp{microdvd} subtitles stream.
> >>>
> >>> +@section mkvtimestamp_v2
> >>> +mkvtoolnix v2 timecode format muxer.
> >>> +
> >>> +Write the PTS rawvideo frame to the output, as supported by the
> >>> +@command{mkvextact} tool from the @command{mkvtoolnix} suite.
> >>> +
> >>> +This muxer accepts a single @samp{rawvideo} stream.
> >>> +
> >>> @section mp3
> >>>
> >>> The MP3 muxer writes a raw MP3 stream with the following optional features:
> >>
> >
> >> This is wrong: MKVToolNix switched to "# timestamp format v2" a long
> >> time ago (we still write the old "# timecode format v2" header);
> >> furthermore, MKVToolNix actually uses pts (which it reorders to be
> >> ascending), not dts like our muxer. Furthermore MKVToolNix does not
> >> force a 1ms precision on timestamps.
> >
> > Correct.
> >
> > I compared the output of the muxer and of mkvtoolnix extract
> > timestamp_v2 and I'm not yet clear about the timestamp differences I'm
> > observing (the muxer output maps with the timestamps, the mkvtoolnix
> > timestamps differ by a few ms). But I think also mkvtoolnix use a 1ms
> > timebase.
>
> The accuracy of the timestamps output by mkvextract is determined by the
> TimestampScale of the file in question; it is most often 1ms when the
> file has video.
> You need to provide more details if you want these discrepancies to be
> analyzed.
Probably not worth the effort.
> > Also, IIRC there is no generic way to reorder PTSs, so this might
> > account for another difference which might be difficult to implement
> > generically.
>
> Write them into a buffer and reorder them at the end?
> (No, I have no intention to actually implement this. I am rather leaning
> to "this muxer should not exist".)
I also think we have better tools at this point (one being ffprobe
-show_packets) but we should not drop it before deprecating it.
Plan: av_tree to insert elements in a constant-size buffer or store in
a buffer sorted once at the end. We probably should skip PTS=NA
elements.
Dropping the doc patch as the implementation is broken.
Will apply the rest of the patchset soon.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".