From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 153B249DB8
	for <ffmpegdev@gitmailbox.com>; Wed, 10 Apr 2024 21:22:34 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C453468D0B1;
	Thu, 11 Apr 2024 00:22:30 +0300 (EEST)
Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com
 [209.85.208.52])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 072766800C1
 for <ffmpeg-devel@ffmpeg.org>; Thu, 11 Apr 2024 00:22:24 +0300 (EEST)
Received: by mail-ed1-f52.google.com with SMTP id
 4fb4d7f45d1cf-56e78970853so407637a12.0
 for <ffmpeg-devel@ffmpeg.org>; Wed, 10 Apr 2024 14:22:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1712784143; x=1713388943; darn=ffmpeg.org;
 h=user-agent:in-reply-to:content-disposition:mime-version:references
 :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject
 :date:message-id:reply-to;
 bh=ak/MAbF+I0gRuaXG1fI6EWMWLtQCDtmAUCgixYP0vT0=;
 b=VHUfnj9bq0B6Lwr9aOdIywWh8YCMj/+ikbZPAC+m6Yv+tHXJiyGrSy267/deSpw3JV
 kFf7u9q4tQYB1aj4miIXyg81xalaI4efzTGLkBou8MgNWDnDocU6OjWjXY9m1HT1GzXt
 V6GYQ9GVXSZNA7LfavfKeozM76LC4pN/qP3ONl4wDD4fmUQ6G8mOuc9tYaR73W3zAt3r
 O3uPrH4axuXTSzqePpmQaEANoysJvMJc5QDcTcJ5XSxQ9n7kpIUIP7UFsmiFMhA1Utpt
 u18jsS1V8oHJpIXZWVNXXpRggiPnZqLK/f/FnHANkMdfaCg0iwlMXzpV+fRj1DDQEDw4
 2ObA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1712784143; x=1713388943;
 h=user-agent:in-reply-to:content-disposition:mime-version:references
 :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=ak/MAbF+I0gRuaXG1fI6EWMWLtQCDtmAUCgixYP0vT0=;
 b=e5Zl3B1gx2UDK7y8zaPH95GK9oOUrElfPC6dfuSkA5dnj9TpKyngAdL6Jq+GpYhjVk
 S+qCHagliNNN8QkiHkLvxvf9y7cY3he3gdldudS1y1lHjewnHMIt6jYHaupuQRkSfFNe
 z+boKg7AgFnbi120os1hS7yiFC1FhMr+z1C3VckK/ICPkejT6xVzK/b55FLr5+84/WdM
 QF5kFUN3rVQeL6xSp1R64/vaZ90IJQNip/TbkEhO43L0HuKqMbUCJo9ohL5HQMjxhx9a
 IHkd7je5gaH7lrvb7Bzo91rwFlm//alYsVxAPIS4xeH1qBXckyNs0/tIerA2z8uWL7Ix
 ZaQw==
X-Gm-Message-State: AOJu0YwgQA29TK4K3+6Glpl0KeA22u+65ky0CuiJ4HfZm/up6hhh8abo
 XhJpQjs2y8T7FiEdheKWKijhD+Ns5arBtgZVnbWL7Y4Ps+UhlgGjvtKypw==
X-Google-Smtp-Source: AGHT+IHyKnMuuCTBK+FzupUfCXuHnyE4Ms32n7qI9MrGDp3pyVBOE5aMl3s+60A1Fq8fyaMVWmbHhA==
X-Received: by 2002:a05:6402:3228:b0:56e:5b6d:ac77 with SMTP id
 g40-20020a056402322800b0056e5b6dac77mr770083eda.18.1712784142973; 
 Wed, 10 Apr 2024 14:22:22 -0700 (PDT)
Received: from mariano (host-82-58-28-189.retail.telecomitalia.it.
 [82.58.28.189]) by smtp.gmail.com with ESMTPSA id
 w12-20020aa7dccc000000b0056e62c8e3bcsm43725edu.54.2024.04.10.14.22.22
 for <ffmpeg-devel@ffmpeg.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 10 Apr 2024 14:22:22 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
 id 33A87BFCE8; Wed, 10 Apr 2024 23:22:21 +0200 (CEST)
Date: Wed, 10 Apr 2024 23:22:21 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <ZhcDDb4+QAk1bSkA@mariano>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
References: <20240408222733.1422670-1-asoulier@google.com>
 <ZhZXtjulPrATcF6T@mariano>
 <CA+wrVdYFNv7E4NEh5s+Fkbih+fQEdY3hVkgyvPi9AeLuzN7z7w@mail.gmail.com>
 <AS8P250MB07443711134687B6AD72AD1C8F062@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <AS8P250MB07443711134687B6AD72AD1C8F062@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH] avformat/lc3: Add file format for
 LC3/LC3plus transport
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ZhcDDb4+QAk1bSkA@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On date Wednesday 2024-04-10 20:26:01 +0200, Andreas Rheinhardt wrote:
> Antoine Soulier via ffmpeg-devel:
[...]
> > +#if CONFIG_LC3_DEMUXER
> > +const FFInputFormat ff_lc3_demuxer = {
> > +    .p.name         = "lc3",
> > +    .p.long_name    = NULL_IF_CONFIG_SMALL("LC3 (Low Complexity
> > Communication Codec)"),
> > +    .p.extensions   = "lc3",
> > +    .p.flags        = AVFMT_GENERIC_INDEX,
> > +    .priv_data_size = sizeof(LC3DemuxContext),
> > +    .read_probe     = lc3_read_probe,
> > +    .read_header    = lc3_read_header,
> > +    .read_packet    = lc3_read_packet,
> > +};
> > +#endif
> > +
> > +#if CONFIG_LC3_MUXER
> > +const FFOutputFormat ff_lc3_muxer = {
> > +    .p.name        = "lc3",
> > +    .p.long_name   = NULL_IF_CONFIG_SMALL("LC3 (Low Complexity
> > Communication Codec)"),
> > +    .p.extensions  = "lc3",
> > +    .p.audio_codec = AV_CODEC_ID_LC3,
> > +    .p.video_codec = AV_CODEC_ID_NONE,
> > +    .p.flags       = AVFMT_NOTIMESTAMPS,
> > +    .init          = lc3_muxer_init,
> > +    .write_header  = lc3_write_header,
> > +    .write_packet  = lc3_write_packet,
> > +};
> > +#endif
> 

> You only put the muxer and demuxer inside #if guards. If only one of
> these two is enabled, the other's functions will not be used and lead to
> compiler warnings. This can be fixed by putting all the stuff for only
> the muxer/demuxer inside the #if (see argo_cvg.c for an example).

Note: I pointed to codec2.c, which seems to suffer from the same
issue, argo_cvg.c is indeed a better example.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".