From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 725374A64D for ; Tue, 2 Apr 2024 17:54:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D451068CC1C; Tue, 2 Apr 2024 20:54:30 +0300 (EEST) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B068068CAE2 for ; Tue, 2 Apr 2024 20:54:23 +0300 (EEST) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-56e030624d1so60339a12.2 for ; Tue, 02 Apr 2024 10:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712080463; x=1712685263; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=DuCnygOSBLQqWxrddOESW3rA5kjGgQo6jFXWW4OYvzs=; b=h0YynmkZjBpCxJIwvz5TAyaeuWyzLxcKaHlAuejwGf1ZWhRoFVfxXZRBjl35IFc3NR tOYeo+/0tKIaW5TfNSLQCc3ltvbxBF7VnLm3Hb93laHLTdldipZ9D0jSyIFBT6UWJdHN lok9lqsDZTPU6rEtLe3mne8B/rQNfDaglua9X6wdHibf6xNtKg+LRlK4l+D1OJDeTx6v 2kbiw66koYCzx3F9+byIWF8j5H6d2MgLZWamPV+JjazU7YXz85ZaQJnBZxV9MmQL+/kX RwpoyhMn2jxdf3+UGPsPgIbC9DQhvaPkMTaC4er5QZzAsxm/Pa6NmXHHTHL27shokEQE HDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712080463; x=1712685263; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DuCnygOSBLQqWxrddOESW3rA5kjGgQo6jFXWW4OYvzs=; b=p6a1HkO7sZVPlMwiUwpzKpuK/9S7Sk9bLqYivxhL0tbeI2wanc0aOleHhEUKRsn6Te RzCzdVKif2N4BATSdUJ87mWAZEuT0fGQj9AKPctwHYKlR+tlpn/fSi76UnvOtCe4AXS/ W22G/f/YOYmaBw70N/vtCUWh9//UYWVffyeC1UpVNKws66Yjrrhcl/riB23HvrnN830u gj5hALRjGjnurfqPTyAVh9uiXBS+Y3DYpdGfYdMFsFEhmDdsmZajK1WczAz9fMwzubIK wsCVdu0IM1EzBT7dhHFyFvwr8U+d4mVb2Hvd6PKDfkasyE/99PkVqdIYlCyZbAQqOE9Z qFqQ== X-Gm-Message-State: AOJu0YxGqe+6ikF+6gaNPZ/rc6ywi1bevN+0utLMZadBTgVcqEDeMiwO Ovhiw7Ih3htaxc6CdJjykJtErNAsSANIt2xYofjEJBjhmjlROfmb X-Google-Smtp-Source: AGHT+IElQeGWkGErdlue5YU/mtulYqX0PEosba21NrfLvbk5KhqFpPtYgTcs29NiSk0Z0rbwsikFRA== X-Received: by 2002:a50:d541:0:b0:56b:e88e:4dd9 with SMTP id f1-20020a50d541000000b0056be88e4dd9mr10515692edj.35.1712080462654; Tue, 02 Apr 2024 10:54:22 -0700 (PDT) Received: from mariano (host-79-42-51-175.retail.telecomitalia.it. [79.42.51.175]) by smtp.gmail.com with ESMTPSA id q18-20020aa7da92000000b0056dfbb73640sm180853eds.2.2024.04.02.10.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:54:22 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 87FB2BFCE8; Tue, 2 Apr 2024 19:54:21 +0200 (CEST) Date: Tue, 2 Apr 2024 19:54:21 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches , Nicolas Gaullier Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Nicolas Gaullier References: <20240329092619.165174-1-nicolas.gaullier@cji.paris> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v6] avformat/demux: Add duration_probesize AVOption X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2024-03-29 11:00:28 +0100, Stefano Sabatini wrote: > On date Friday 2024-03-29 10:26:19 +0100, Nicolas Gaullier wrote: > > Yet another probesize used to get the durations when > > estimate_timings_from_pts is required. It is aimed at users interested > > in better durations probing for itself, or because using > > avformat_find_stream_info indirectly and requiring exact values: for > > concatdec for example, especially if streamcopying above it. > > The current code is a performance trade-off that can fail to get video > > stream durations in a scenario with high bitrates and buffering for > > files ending cleanly (as opposed to live captures): the physical gap > > between the last video packet and the last audio packet is very high in > > such a case. > > > > Default behaviour is unchanged: 250k up to 250k << 6 (step by step). > > Setting this new option has two effects: > > - override the maximum probesize (currently 250k << 6) > > - reduce the number of steps to 1 instead of 6, this is to avoid > > detecting the audio "too early" and failing to reach a video packet. > > Even if a single audio stream duration is found but not the other > > audio/video stream durations, there will be a retry, so at the end the > > full user-overriden probesize will be used as expected by the user. > > > > Signed-off-by: Nicolas Gaullier > > --- > > doc/APIchanges | 3 +++ > > doc/formats.texi | 19 ++++++++++++++++++- > > libavformat/avformat.h | 16 ++++++++++++++-- > > libavformat/demux.c | 13 ++++++++----- > > libavformat/options_table.h | 1 + > > libavformat/version.h | 2 +- > > 6 files changed, 45 insertions(+), 9 deletions(-) > > Looks good to me, will apply in a few days if there are no further > comments. Will apply soon, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".