From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0B69548EEA for ; Sat, 30 Mar 2024 14:55:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1FCF868D3A8; Sat, 30 Mar 2024 16:55:25 +0200 (EET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 188A068D38C for ; Sat, 30 Mar 2024 16:55:18 +0200 (EET) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5101cd91017so3287474e87.2 for ; Sat, 30 Mar 2024 07:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711810516; x=1712415316; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=zZ0W14sHPp8E7wdMRMXb4hQBk0E9K0RE3J+Zgnxp2HM=; b=jPzA4uTSvB0+eosVxOPhZOGl1OK0+DtATQU+aX6FriHKIvc9kIx+05jw4y6442yujI 1vshHjgDzw+IXGAC1HaHmmIKLZeIWX6xe5Sh8Tajifc5mncqMsg5YtmlNXIN6cZz4ImT RVDvRzi4X/81jnix7wjMaTE3ivFF777x5OPPIWfhZGkuP1m2iOFcbkjZyEjzOyiuqiK3 ca43fcNQzA+sT0ZjGjUlnJKiUaPO8MvDo4cs99JIdOplcItcZ/5+mHcDeJuZK53HS7AI tvg90rGB7LwUgzvKESxV3DMGrMybe9g7LxhY8bw11B4AyL02CIeu57SHp4Fa7RYH71Pw arDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711810516; x=1712415316; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zZ0W14sHPp8E7wdMRMXb4hQBk0E9K0RE3J+Zgnxp2HM=; b=QxkJgVlWz5hYAR83/5bOSQ5ik9EQe8gIiFs6Tz+b0Tjl9pNvSp57nsNLsmtBFsaTfx fUiJapKjgNQvNU3k0EGngGiCcaTVt5CxB0LzX7AvqAnKNzk8uN3gpKAczbYDlCiprbrl 8wQp3NYNswcO0hOO2wt6+xlxksZV+mz0kOXrQv/jcZQ+Qx7OVLDo0MStCow40yMtPozI BZ9rsbF38wnZFqhyo1/yQCwVNYd7Q+G3B7dxryMiETe52i9whoN3fbxrfesXlQUkyVnP HUqb8nU8aoquOMcF4TrQMSsrGghyrfcY2UoUDJcEGM25HbGVP12h5Xely9w3W06JbYiD id7g== X-Gm-Message-State: AOJu0YxkHLtLoU9K+wGlWwBYH01hl+Qo8u1FWi7HlomAO5M5RdXkBTIV DvwZcMjaPr0yUvh6SUoGoFcWpNi/lrg+sPYqEAEkkPWEimhhrqx3st7KkdSb X-Google-Smtp-Source: AGHT+IH6AXKkN94NDBLCuJiwHWUNgYdu75zzR3sSbcvI1ruV6QfoGcKTBeA4W0LbPrpcGpD0d3BwBA== X-Received: by 2002:ac2:47f8:0:b0:515:acca:d75b with SMTP id b24-20020ac247f8000000b00515accad75bmr3314429lfp.22.1711810516077; Sat, 30 Mar 2024 07:55:16 -0700 (PDT) Received: from mariano (net-93-70-84-101.cust.vodafonedsl.it. [93.70.84.101]) by smtp.gmail.com with ESMTPSA id bg12-20020a170906a04c00b00a4a3580b215sm3167555ejb.80.2024.03.30.07.55.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Mar 2024 07:55:15 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id E78E6BFCE8; Sat, 30 Mar 2024 15:55:13 +0100 (CET) Date: Sat, 30 Mar 2024 15:55:13 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20240328201132.1804716-1-marth64@proxyid.net> <20240328201132.1804716-3-marth64@proxyid.net> <20240330002353.GU6420@pb2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240330002353.GU6420@pb2> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Saturday 2024-03-30 01:23:53 +0100, Michael Niedermayer wrote: > On Thu, Mar 28, 2024 at 03:11:29PM -0500, Marth64 wrote: > [...] > > > +static int rcwt_probe(const AVProbeData *p) > > +{ > > + return p->buf_size > RCWT_HEADER_SIZE && > > + AV_RB16(p->buf) == 0xCCCC && > > + AV_RB8(p->buf + 2) == 0xED && > > + AV_RB16(p->buf + 6) == 0x0001 ? 50 : 0; > > +} > > + > > +const FFInputFormat ff_rcwt_demuxer = { > > + .p.name = "rcwt", > > + .p.long_name = NULL_IF_CONFIG_SMALL("RCWT (Raw Captions With Time)"), > > + .p.extensions = "bin", > > this causes a mp3 i have to be misdetected > ~/videos/sbQ9.bin > (this is a actual file i had not a file crafted for this) > > i think the entry for extensions should be removed (which fixes this) > having a ".bin" is not a strong indication that its rcwt Is this blocking or can it be addressed later? Also, if this needs to be modified the muxer should be as well. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".