Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer
Date: Sat, 30 Mar 2024 15:55:13 +0100
Message-ID: <Zggn0c0NzNrTWATI@mariano> (raw)
In-Reply-To: <20240330002353.GU6420@pb2>

On date Saturday 2024-03-30 01:23:53 +0100, Michael Niedermayer wrote:
> On Thu, Mar 28, 2024 at 03:11:29PM -0500, Marth64 wrote:
> [...]
> 
> > +static int rcwt_probe(const AVProbeData *p)
> > +{
> > +    return p->buf_size > RCWT_HEADER_SIZE   &&
> > +           AV_RB16(p->buf) == 0xCCCC        &&
> > +           AV_RB8(p->buf + 2) == 0xED       &&
> > +           AV_RB16(p->buf + 6) == 0x0001    ? 50 : 0;
> > +}
> > +
> > +const FFInputFormat ff_rcwt_demuxer = {
> > +    .p.name         = "rcwt",
> > +    .p.long_name    = NULL_IF_CONFIG_SMALL("RCWT (Raw Captions With Time)"),
> > +    .p.extensions   = "bin",
> 

> this causes a mp3 i have to be misdetected
> ~/videos/sbQ9.bin
> (this is a actual file i had not a file crafted for this)
> 
> i think the entry for extensions should be removed (which fixes this)
> having a ".bin" is not a strong indication that its rcwt

Is this blocking or can it be addressed later? Also, if this needs to
be modified the muxer should be as well.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".