From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BE5A948E1F for ; Fri, 29 Mar 2024 10:00:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9205168D65D; Fri, 29 Mar 2024 12:00:37 +0200 (EET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B30DC68D55B for ; Fri, 29 Mar 2024 12:00:31 +0200 (EET) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-41551500a7eso1312205e9.2 for ; Fri, 29 Mar 2024 03:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711706431; x=1712311231; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=3tWbHWnxiQm6/AUltD3I01ok/uDAvjE81pO9PnZCEWM=; b=kr2U9vHRfByMfzxQA0GcE04fuxJ0cF2U2uqYSRkJgfuf5uXBo7UV17zT5m0cYSKX2p TXRrU66BKL+wqUJHaIPo12DRZ1nPFvWUBj9X/01fYJ9HuKavl7MZxmyiGHdjjwG3WzWe FaJouX7PZZbrio+8KhyRJHcOC4PPUT6c2yGDdMWlgr+hlmzD81nhYfGLFIcJbcP3Ukku V2qBi48O/xwFOP9p9Ocl6iCM7Y3xMaPU2NGdGNl9vovczjOIpouKPwpYohhQxrDZ6nMp YNFm48FJuRNQjzwZtR494MIIvV+Djy9XoUYBXNPi/UZGlQk9MMh3LuX2CcaWryKlbdXv XIkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711706431; x=1712311231; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3tWbHWnxiQm6/AUltD3I01ok/uDAvjE81pO9PnZCEWM=; b=FQZRLRimYbM2lAQBPU1maBFJTBU8x1Mzw4xhuhYx+g1kGiDwM3oghSuFpx8elmGkNE H1cLHl/ew06JbwKxZ0y6PP4T6fvbFiumGre2hFcccFYRLTj0FHIuvr6rOGyqMVUII9Ym Jt9hpwopsWenNHBu/ntJvvayMVV8aisCgXzSu2QyTftsiSkJBs5NtjIMSdq7FRBTm6Ov C/qMNzOolnm/P8N1ClyQd4Uo/EDPA/hYuANImRaksS7gwvFG+2EWTpk1cePtAQR8s8kT CBkMm5XkUTQRT+T/2qR8KysGzQFRS7GncsfTryRC74kZ/9QaZQNaF8bEyx31iIHC1v1l I1JA== X-Gm-Message-State: AOJu0Yyb3i3UYPIFLrufBiSDn3BAqDpZkTCyc5WLLXaGWDVDbYnR+X4Y 4SaiK4+P8TRRWMkOvjQLePdEAl6XF18bXYLedk1IanDM1AoNbGKxW9PFkYkn X-Google-Smtp-Source: AGHT+IEfACTilJS9ldwGn1mKNoEPZn05Ep8XPP41SUQbjnCTY14wu2zqwQpt4VnVIyCGi9tjfI/tFA== X-Received: by 2002:a05:600c:3554:b0:412:d2dd:4bdd with SMTP id i20-20020a05600c355400b00412d2dd4bddmr1230836wmq.26.1711706430636; Fri, 29 Mar 2024 03:00:30 -0700 (PDT) Received: from mariano (net-93-70-84-101.cust.vodafonedsl.it. [93.70.84.101]) by smtp.gmail.com with ESMTPSA id iv11-20020a05600c548b00b00412e5f32591sm4929315wmb.28.2024.03.29.03.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 03:00:30 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id DFAB4BFCE4; Fri, 29 Mar 2024 11:00:28 +0100 (CET) Date: Fri, 29 Mar 2024 11:00:28 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Nicolas Gaullier References: <20240329092619.165174-1-nicolas.gaullier@cji.paris> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240329092619.165174-1-nicolas.gaullier@cji.paris> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v6] avformat/demux: Add duration_probesize AVOption X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nicolas Gaullier Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2024-03-29 10:26:19 +0100, Nicolas Gaullier wrote: > Yet another probesize used to get the durations when > estimate_timings_from_pts is required. It is aimed at users interested > in better durations probing for itself, or because using > avformat_find_stream_info indirectly and requiring exact values: for > concatdec for example, especially if streamcopying above it. > The current code is a performance trade-off that can fail to get video > stream durations in a scenario with high bitrates and buffering for > files ending cleanly (as opposed to live captures): the physical gap > between the last video packet and the last audio packet is very high in > such a case. > > Default behaviour is unchanged: 250k up to 250k << 6 (step by step). > Setting this new option has two effects: > - override the maximum probesize (currently 250k << 6) > - reduce the number of steps to 1 instead of 6, this is to avoid > detecting the audio "too early" and failing to reach a video packet. > Even if a single audio stream duration is found but not the other > audio/video stream durations, there will be a retry, so at the end the > full user-overriden probesize will be used as expected by the user. > > Signed-off-by: Nicolas Gaullier > --- > doc/APIchanges | 3 +++ > doc/formats.texi | 19 ++++++++++++++++++- > libavformat/avformat.h | 16 ++++++++++++++-- > libavformat/demux.c | 13 ++++++++----- > libavformat/options_table.h | 1 + > libavformat/version.h | 2 +- > 6 files changed, 45 insertions(+), 9 deletions(-) Looks good to me, will apply in a few days if there are no further comments. Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".