Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] examples/decode_filter_audio: Add loop for draining the filtergraph
Date: Wed, 27 Mar 2024 13:04:09 +0100
Message-ID: <ZgQLOcnPu3yUE1HI@mariano> (raw)
In-Reply-To: <1711536691-15749-1-git-send-email-t.rapp@noa-archive.com>

On date Wednesday 2024-03-27 11:51:30 +0100, Tobias Rapp wrote:
> Depending on the filters used the filtergraph can produce trailing data
> after feeding it the last input frame. Update the example to include the
> necessary loop for draining the filtergrap.
> 
> Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
> ---
>  doc/examples/decode_filter_audio.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/doc/examples/decode_filter_audio.c b/doc/examples/decode_filter_audio.c
> index 2046419..196f080 100644
> --- a/doc/examples/decode_filter_audio.c
> +++ b/doc/examples/decode_filter_audio.c
> @@ -279,6 +279,25 @@ int main(int argc, char **argv)
>          }
>          av_packet_unref(packet);
>      }
> +    if (ret == AVERROR_EOF) {
> +        /* signal EOF to the filtergraph */
> +        if (av_buffersrc_add_frame_flags(buffersrc_ctx, NULL, 0) < 0) {
> +            av_log(NULL, AV_LOG_ERROR, "Error while closing the filtergraph\n");
> +            goto end;
> +        }
> +
> +        /* pull remaining frames from the filtergraph */
> +        while (1) {
> +            ret = av_buffersink_get_frame(buffersink_ctx, filt_frame);
> +            if (ret == AVERROR(EAGAIN) || ret == AVERROR_EOF)
> +                break;
> +            if (ret < 0)
> +                goto end;
> +            print_frame(filt_frame);
> +            av_frame_unref(filt_frame);
> +        }
> +    }
> +
>  end:
>      avfilter_graph_free(&filter_graph);
>      avcodec_free_context(&dec_ctx);

Should be fine, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2024-03-27 12:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 10:51 Tobias Rapp
2024-03-27 10:51 ` [FFmpeg-devel] [PATCH 2/2] examples/decode_filter_video: " Tobias Rapp
2024-03-27 12:06   ` Stefano Sabatini
2024-03-27 12:46     ` Tobias Rapp
2024-03-27 12:53       ` Anton Khirnov
2024-03-27 13:04         ` Tobias Rapp
2024-03-28 11:07           ` Tobias Rapp
2024-03-27 12:04 ` Stefano Sabatini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZgQLOcnPu3yUE1HI@mariano \
    --to=stefasab@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git