From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A1CC34A39B for ; Wed, 27 Mar 2024 11:30:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 20E6268D618; Wed, 27 Mar 2024 13:30:15 +0200 (EET) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C3DC268D5CE for ; Wed, 27 Mar 2024 13:30:08 +0200 (EET) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-563cb3ba9daso6834955a12.3 for ; Wed, 27 Mar 2024 04:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711539007; x=1712143807; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=7rh5S5aGlqoIRHJl7tLenBcy6MfYJml6Bm5atQcUotA=; b=gmAM0YS1G3rOLB94Y4gjXz6n3zCOKm1zDWg1tlbIokZ2rqk0Yb1ySzfFCrp2DsJGWl 0QKUg7HzzWO+7/GqDE5NqtSiDg5QuSGjUpd7+bDUEglB90bAQ21n6g53CMU3SRKRJUAF SK4FMivkuq83W5J+lEA26/0cm2AW7KQFofzRQghXtGxLkHA1IRJngI1CXoVXarCTjEY/ U1gQFxEVuKDaUBwv0EiFNJy0jjQxmqxaJQ6RR/O+Ni6t42MnlIVwMDM5GOixWhFbH0bg sW8BUpu5ILco6QIlqN6yAaE7yjjA4uT5tlnEAzh4gbv5S/OGVdopKZJSH0Mub58MGyCn V3MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711539007; x=1712143807; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7rh5S5aGlqoIRHJl7tLenBcy6MfYJml6Bm5atQcUotA=; b=RTb8YSKr2unWOLyGy2Hze1DBmArWyAUn+zUnJhGnmPvk/pf7UjxWzImXXTtpXB9wRu GedmrxiUOz5P29x/rT/N8jyLp+9Z4D3p2mi7n4Q6qgAUufExP6od2yVVex8EjzbnODCS P2InhizoPp/AUbRbC+xy8Lkv8vsUBsIRooEtM2s6rSV/bQqjV+gcq3aRVWfXWmAILJts u66iYZ9FNVmmN6MeoAH4qOqtgzNcJoMAFpFNHmmfJjWCege4kh8ZEcI73oPVywtt8ldl SjBXKrFlJjacPA2zlqO66VI0W7hbDJaYjpClmpH5ncUKn2uUd+pXOct84ifVFmBL8ejh R9UQ== X-Gm-Message-State: AOJu0YyfMjZHetQ4KXQWgtz+gEA7X0YGwYXSWtY0zhGph8EOFQqFDyKw ImJ5mtWIApRMz5aEtzd8H+yQVF1qZGKwfRyfGkBi3vXvXXYOBsx+t3HHLcLb X-Google-Smtp-Source: AGHT+IHRXcHOFNaQh98MOGV0hbNfcbqBruIy51a646ayLht4r941wW+dDCYtCUyhzeEIGmOjoXNpFg== X-Received: by 2002:a50:d49e:0:b0:56c:2a90:9c29 with SMTP id s30-20020a50d49e000000b0056c2a909c29mr806601edi.28.1711539007010; Wed, 27 Mar 2024 04:30:07 -0700 (PDT) Received: from mariano (net-93-70-84-101.cust.vodafonedsl.it. [93.70.84.101]) by smtp.gmail.com with ESMTPSA id b19-20020aa7d493000000b0056a2b87787dsm5200341edr.37.2024.03.27.04.30.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 04:30:06 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 6B140BFCE0; Wed, 27 Mar 2024 12:30:05 +0100 (CET) Date: Wed, 27 Mar 2024 12:30:05 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Mark Samuelson References: <20240326192537.272-1-samuelsonm@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240326192537.272-1-samuelsonm@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Mark Samuelson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2024-03-26 14:25:37 -0500, Mark Samuelson wrote: > --- > libavcodec/mf_utils.h | 5 +++++ > libavcodec/mfenc.c | 19 +++++++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/libavcodec/mf_utils.h b/libavcodec/mf_utils.h > index aebfb9ad21..387c005f38 100644 > --- a/libavcodec/mf_utils.h > +++ b/libavcodec/mf_utils.h > @@ -97,6 +97,11 @@ DEFINE_GUID(ff_CODECAPI_AVEncH264CABACEnable, 0xee6cad62, 0xd305, 0x4248, 0xa > DEFINE_GUID(ff_CODECAPI_AVEncVideoForceKeyFrame, 0x398c1b98, 0x8353, 0x475a, 0x9e, 0xf2, 0x8f, 0x26, 0x5d, 0x26, 0x3, 0x45); > DEFINE_GUID(ff_CODECAPI_AVEncMPVDefaultBPictureCount, 0x8d390aac, 0xdc5c, 0x4200, 0xb5, 0x7f, 0x81, 0x4d, 0x04, 0xba, 0xba, 0xb2); > DEFINE_GUID(ff_CODECAPI_AVScenarioInfo, 0xb28a6e64,0x3ff9,0x446a,0x8a,0x4b,0x0d,0x7a,0x53,0x41,0x32,0x36); > +DEFINE_GUID(ff_CODECAPI_AVEncCommonBufferSize, 0x0db96574, 0xb6a4, 0x4c8b, 0x81, 0x06, 0x37, 0x73, 0xde, 0x03, 0x10, 0xcd); > +DEFINE_GUID(ff_CODECAPI_AVEncCommonMaxBitRate, 0x9651eae4, 0x39b9, 0x4ebf, 0x85, 0xef, 0xd7, 0xf4, 0x44, 0xec, 0x74, 0x65); > +DEFINE_GUID(ff_CODECAPI_AVEncCommonQualityVsSpeed, 0x98332df8, 0x03cd, 0x476b, 0x89, 0xfa, 0x3f, 0x9e, 0x44, 0x2d, 0xec, 0x9f); > +DEFINE_GUID(ff_CODECAPI_AVEncMPVGOPSize, 0x95f31b26, 0x95a4, 0x41aa, 0x93, 0x03, 0x24, 0x6a, 0x7f, 0xc6, 0xee, 0xf1); > +DEFINE_GUID(ff_CODECAPI_AVEncVideoEncodeQP, 0x2cb5696b, 0x23fb, 0x4ce1, 0xa0, 0xf9, 0xef, 0x5b, 0x90, 0xfd, 0x55, 0xca); > > DEFINE_GUID(ff_MF_SA_D3D11_BINDFLAGS, 0xeacf97ad, 0x065c, 0x4408, 0xbe, 0xe3, 0xfd, 0xcb, 0xfd, 0x12, 0x8b, 0xe2); > DEFINE_GUID(ff_MF_SA_D3D11_USAGE, 0xe85fe442, 0x2ca3, 0x486e, 0xa9, 0xc7, 0x10, 0x9d, 0xda, 0x60, 0x98, 0x80); > diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c > index 9225692c51..36f64a93b8 100644 > --- a/libavcodec/mfenc.c > +++ b/libavcodec/mfenc.c > @@ -54,6 +54,8 @@ typedef struct MFContext { > int opt_enc_quality; > int opt_enc_scenario; > int opt_enc_hw; > + int opt_enc_bufferSize; > + int opt_enc_encodeQP; use snake_case > } MFContext; > > static int mf_choose_output_type(AVCodecContext *avctx); > @@ -695,6 +697,21 @@ FF_ENABLE_DEPRECATION_WARNINGS > if (c->opt_enc_quality >= 0) > ICodecAPI_SetValue(c->codec_api, &ff_CODECAPI_AVEncCommonQuality, FF_VAL_VT_UI4(c->opt_enc_quality)); > > + if (avctx->rc_max_rate > 0) > + ICodecAPI_SetValue(c->codec_api, &ff_CODECAPI_AVEncCommonMaxBitRate, FF_VAL_VT_UI4(avctx->rc_max_rate)); > + > + if (avctx->gop_size > 0) > + ICodecAPI_SetValue(c->codec_api, &ff_CODECAPI_AVEncMPVGOPSize, FF_VAL_VT_UI4(avctx->gop_size)); > + > + if(c->opt_enc_bufferSize > 0) > + ICodecAPI_SetValue(c->codec_api, &ff_CODECAPI_AVEncCommonBufferSize, FF_VAL_VT_UI4(c->opt_enc_bufferSize)); > + > + if(avctx->compression_level >= 0) > + ICodecAPI_SetValue(c->codec_api, &ff_CODECAPI_AVEncCommonQualityVsSpeed, FF_VAL_VT_UI4(avctx->compression_level)); > + > + if(c->opt_enc_encodeQP > 15) > + ICodecAPI_SetValue(c->codec_api, &ff_CODECAPI_AVEncVideoEncodeQP, FF_VAL_VT_UI4(c->opt_enc_encodeQP)); > + > // Always set the number of b-frames. Qualcomm's HEVC encoder on SD835 > // defaults this to 1, and that setting is buggy with many of the > // rate control modes. (0 or 2 b-frames works fine with most rate > @@ -1280,6 +1297,8 @@ static const AVOption venc_opts[] = { > > {"quality", "Quality", OFFSET(opt_enc_quality), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 100, VE}, > {"hw_encoding", "Force hardware encoding", OFFSET(opt_enc_hw), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, VE}, > + {"buffer_size", "BufferSize", OFFSET(opt_enc_bufferSize), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE}, > + {"encodeQP", "QualityQP", OFFSET(opt_enc_encodeQP), AV_OPT_TYPE_INT, {.i64 = 15}, 15, 51, VE}, use snake_case and provide meaningful description for the help field _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".