From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3223F4A204 for ; Mon, 25 Mar 2024 08:06:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2DAEF68D44A; Mon, 25 Mar 2024 10:06:36 +0200 (EET) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9FA4968D43D for ; Mon, 25 Mar 2024 10:06:29 +0200 (EET) Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2d109e82bd0so55754141fa.3 for ; Mon, 25 Mar 2024 01:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711353989; x=1711958789; darn=ffmpeg.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y8FapW+uhJ232L7KwfJNpFLFXcVMDwl93tiDIRi471w=; b=dVOFV1p4I+bQeOAKxcHLMrOnNuAtVWPg8mRBtziEko15yjIvliFJee1cnZ7RGpfoUJ Q6GOa9KXRLBuRXiF2bKu4V9rW2YBJJ/zQz3WStljHG07vxX3tT4F4UEGYKUGOYm0110M b4q6hQbz6LtUOsNF/LNXrTA/yWt83gvJk+Mq2zXb33XxR0otuoCBZX62uk8gAJOSMb9G HuWjpO9lQ9uGcFxSaHwB/VRXKJHbEyYqo/8kzk2K+hPPVAQJebJoRjEGpy3N624YjUU+ e9OFmi1ecCCSZ9+GPr2nmY5vr8VQ944HLz+TK7gjBdD8vliQcYDPW//nUvMjWxMF1+En XGtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711353989; x=1711958789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y8FapW+uhJ232L7KwfJNpFLFXcVMDwl93tiDIRi471w=; b=TqShjxZ2cOyjlE70d0OVUYjy4wnu5VIBteDquUTVX7jaU3OCAStzczo7+jZZkEh4qL zo2AESLdBvJ5Ise7aTYER8C6Wd9Y8Y2T2gzfwt6Tcs+XhxqQlTDcco6PwebZ6LHiR7uB j4zJXg66YfeAegicZykqVzqBlNO/xu2cKHZm1x+1qDwLkyxEmw3+mhofDZfFP2Ffr1o1 cLZYauVe0IkS7guGUU2qqbeWsA0HP41ku9hQxRJmW+WJgJ2HaTm6DhY2wwI1FCTg9nQ9 +Ao0ubTUK8GFVHUk90HtUnm7tBeOFw8LxEkuVdvgy8Zz1b+cvNyjfF7UC5D0yLytr06T quBw== X-Gm-Message-State: AOJu0Yy6VJ679nypf0vSXu4+DVaOH65u/BuPQN6Sj68kXJxjKvFUTrVz 0SKcFJuZtdawg4PAM6zTav5qpkPhvLGTcfgMZA0QYB6K+HHbeM+0uziK/w66 X-Google-Smtp-Source: AGHT+IEja4Ktp15+KX17s3qNg6u56v7WHTAk5ce9gwbGtl2ZgSK0wJ5Z/tsJWPQtAvM1Lptj6bFOPQ== X-Received: by 2002:a2e:9ccd:0:b0:2d6:9178:894 with SMTP id g13-20020a2e9ccd000000b002d691780894mr4208285ljj.39.1711353988427; Mon, 25 Mar 2024 01:06:28 -0700 (PDT) Received: from kusa (2a01cb040b6872000000000000000afa.ipv6.abo.wanadoo.fr. [2a01:cb04:b68:7200::afa]) by smtp.gmail.com with ESMTPSA id bd21-20020a05600c1f1500b00414850d5df7sm5690539wmb.2.2024.03.25.01.06.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 01:06:28 -0700 (PDT) Date: Mon, 25 Mar 2024 09:06:26 +0100 From: Matthieu Bouron To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/file: Constify android content protocol X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Mar 25, 2024 at 02:55:32AM +0100, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > (The discrepancy between the definition and the declaration > > in protocols.c is actually UB.) > > > > Signed-off-by: Andreas Rheinhardt > > --- > > This and the next patch have not been tested (apart from "it compiles > > when the android content protocol is disabled"). > > > > libavformat/file.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/file.c b/libavformat/file.c > > index dd5819c06f..8f3b35c795 100644 > > --- a/libavformat/file.c > > +++ b/libavformat/file.c > > @@ -670,7 +670,7 @@ done: > > return ret; > > } > > > > -URLProtocol ff_android_content_protocol = { > > +const URLProtocol ff_android_content_protocol = { > > .name = "content", > > .url_open = android_content_open, > > .url_read = file_read, > > Will apply this patchset tomorrow unless there are objections. Patchset tested locally and working as intended. LGTM. Thanks. -- Matthieu B. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".